René's URL Explorer Experiment


Title: bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock by tirkarthi · Pull Request #14117 · python/cpython · GitHub

Open Graph Title: bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock by tirkarthi · Pull Request #14117 · python/cpython

X Title: bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock by tirkarthi · Pull Request #14117 · python/cpython

Description: MagicMock with a function spec will have __code__ object. When it is used a spec to mock.patch then __code__ object which is a MagicMock is used to detect if it's a coroutine. MagicMock.__code__ & 128 returns another MagicMock which is evaluated to True and returned as a coroutine incorrectly. Hence check __code__ to be a CodeType to make sure MagicMock with __code__ is not detected as coroutine. https://bugs.python.org/issue37251

Open Graph Description: MagicMock with a function spec will have __code__ object. When it is used a spec to mock.patch then __code__ object which is a MagicMock is used to detect if it's a coroutine. MagicMock.__code_...

X Description: MagicMock with a function spec will have __code__ object. When it is used a spec to mock.patch then __code__ object which is a MagicMock is used to detect if it's a coroutine. MagicMock.__c...

Opengraph URL: https://github.com/python/cpython/pull/14117

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e10e9bf6-9d8f-ff0b-9f2c-da9dbdade215
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFFE:2BB83B:B3B7DA:F46441:6A5557C4
html-safe-nonce6a6aae47c8e524e923ba82d3dda3277df6c28020b9e838aee024513097544c0f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkZFOjJCQjgzQjpCM0I3REE6RjQ2NDQxOjZBNTU1N0M0IiwidmlzaXRvcl9pZCI6Ijk4NTAzOTIyNzcyNDMyMjc1NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7cc02a7afc8207480a6ab35dcffdde7acd3bb879879bde0890e7228c3c9e3d01
hovercard-subject-tagpull_request:288567521
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/14117/files
twitter:imagehttps://avatars.githubusercontent.com/u/3972343?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3972343?s=400&v=4
og:image:altMagicMock with a function spec will have __code__ object. When it is used a spec to mock.patch then __code__ object which is a MagicMock is used to detect if it's a coroutine. MagicMock.__code_...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release73595e82546ca2415571a2031890ab16ecb3001a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/14117/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14117%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14117%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/14117/files
Reloadhttps://github.com/python/cpython/pull/14117/files
Reloadhttps://github.com/python/cpython/pull/14117/files
Please reload this pagehttps://github.com/python/cpython/pull/14117/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/14117/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
tirkarthihttps://github.com/tirkarthi
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo37251https://github.com/tirkarthi/cpython/tree/bpo37251
Conversation 1 https://github.com/python/cpython/pull/14117
Commits 2 https://github.com/python/cpython/pull/14117/commits
Checks 0 https://github.com/python/cpython/pull/14117/checks
Files changed https://github.com/python/cpython/pull/14117/files
Please reload this pagehttps://github.com/python/cpython/pull/14117/files
bpo-37251: MagicMock with function spec used as a spec in mock.patch should return a MagicMock https://github.com/python/cpython/pull/14117/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/14117/files
1378120 MagicMock with function as spec supplied to mock.patch should return … tirkarthi Jun 15, 2019 https://github.com/python/cpython/pull/14117/commits/13781201f2ec1e744f81f9643566e3de076fbb5f
54537f4 Add NEWS entry tirkarthi Jun 15, 2019 https://github.com/python/cpython/pull/14117/commits/54537f47f920688df204b4b76c02976ba6bf9b0e
Clear filters https://github.com/python/cpython/pull/14117/files
Please reload this pagehttps://github.com/python/cpython/pull/14117/files
Please reload this pagehttps://github.com/python/cpython/pull/14117/files
mock.py https://github.com/python/cpython/pull/14117/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
testasync.py https://github.com/python/cpython/pull/14117/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
2019-06-15-21-52-23.bpo-37251.dYzQt6.rst https://github.com/python/cpython/pull/14117/files#diff-827810bbf63942b3f8e75b65e4242d4f8623b435de5161ac12aacf22ffc8fa93
Lib/unittest/mock.pyhttps://github.com/python/cpython/pull/14117/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
View file https://github.com/tirkarthi/cpython/blob/54537f47f920688df204b4b76c02976ba6bf9b0e/Lib/unittest/mock.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14117/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14117/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
https://github.com/python/cpython/pull/14117/files#diff-347d0254250a1ab7ab8e31b405e2c35b74cd2838df4ee74f1b658a459eb91f1a
Lib/unittest/test/testmock/testasync.pyhttps://github.com/python/cpython/pull/14117/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
View file https://github.com/tirkarthi/cpython/blob/54537f47f920688df204b4b76c02976ba6bf9b0e/Lib/unittest/test/testmock/testasync.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14117/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14117/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
https://github.com/python/cpython/pull/14117/files#diff-508b9898f44acd7e46719a7317694876c83035922a09db5f83b2236db9f34f0a
Misc/NEWS.d/next/Library/2019-06-15-21-52-23.bpo-37251.dYzQt6.rsthttps://github.com/python/cpython/pull/14117/files#diff-827810bbf63942b3f8e75b65e4242d4f8623b435de5161ac12aacf22ffc8fa93
View file https://github.com/tirkarthi/cpython/blob/54537f47f920688df204b4b76c02976ba6bf9b0e/Misc/NEWS.d/next/Library/2019-06-15-21-52-23.bpo-37251.dYzQt6.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14117/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.