René's URL Explorer Experiment


Title: gh-140691: urllib.request: Close FTP control socket if data socket can't connect by encukou · Pull Request #140835 · python/cpython · GitHub

Open Graph Title: gh-140691: urllib.request: Close FTP control socket if data socket can't connect by encukou · Pull Request #140835 · python/cpython

X Title: gh-140691: urllib.request: Close FTP control socket if data socket can't connect by encukou · Pull Request #140835 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Issue: Unclosed socket in urllib when ftp request times out after connect #140691

X Description: Issue: Unclosed socket in urllib when ftp request times out after connect #140691

Opengraph URL: https://github.com/python/cpython/pull/140835

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:88ce6656-e2f7-c3d0-a685-7877c2ef53d8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD6C:211F05:5B517D:7343D2:6B02197F
html-safe-nonce91e22e27ce543789520798d9d5766f7a75713ae6592b7da571fa22edbca92fac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDZDOjIxMUYwNTo1QjUxN0Q6NzM0M0QyOjZCMDIxOTdGIiwidmlzaXRvcl9pZCI6IjQzOTk4ODU0NjIyNTQ0NTI0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac17e9422d36054a2acdb459bc1e6fc87c71cc6280174a6e9bb213203c0781ce9f
hovercard-subject-tagpull_request:2966977183
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/140835/commits
twitter:imagehttps://opengraph.githubassets.com/b49bf23c996467471935e25714ee50495b23cf6ede5756e3c5cc1b6d87d9fe25/python/cpython/pull/140835
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b49bf23c996467471935e25714ee50495b23cf6ede5756e3c5cc1b6d87d9fe25/python/cpython/pull/140835
og:image:altIssue: Unclosed socket in urllib when ftp request times out after connect #140691
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/140835/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140835%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140835%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/140835/commits
Reloadhttps://github.com/python/cpython/pull/140835/commits
Reloadhttps://github.com/python/cpython/pull/140835/commits
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:ftp-warningshttps://github.com/encukou/cpython/tree/ftp-warnings
Conversationhttps://github.com/python/cpython/pull/140835
Commits13 (13)https://github.com/python/cpython/pull/140835/commits
Checkshttps://github.com/python/cpython/pull/140835/checks
Files changedhttps://github.com/python/cpython/pull/140835/files
gh-140691: urllib.request: Close FTP control socket if data socket can't connecthttps://github.com/python/cpython/pull/140835/commits#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:ftp-warningshttps://github.com/encukou/cpython/tree/ftp-warnings
Add a test for unclosed sockethttps://github.com/python/cpython/pull/140835/commits/bd3c98d44ce1da5f5edfe9120eec0c0ce4262c43
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
bd3c98dhttps://github.com/python/cpython/pull/140835/commits/bd3c98d44ce1da5f5edfe9120eec0c0ce4262c43
https://github.com/python/cpython/tree/bd3c98d44ce1da5f5edfe9120eec0c0ce4262c43
Close FTP control connection if transfer connection failshttps://github.com/python/cpython/pull/140835/commits/b0b636a9eee91fda59bb58ec4f92203efa170cda
encukouhttps://github.com/python/cpython/commits?author=encukou
codenamenamhttps://github.com/python/cpython/commits?author=codenamenam
b0b636ahttps://github.com/python/cpython/pull/140835/commits/b0b636a9eee91fda59bb58ec4f92203efa170cda
https://github.com/python/cpython/tree/b0b636a9eee91fda59bb58ec4f92203efa170cda
Remove closed connections from cachehttps://github.com/python/cpython/pull/140835/commits/97c23362c80cdd5cbb8cee927e8920b0c03e2753
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
97c2336https://github.com/python/cpython/pull/140835/commits/97c23362c80cdd5cbb8cee927e8920b0c03e2753
https://github.com/python/cpython/tree/97c23362c80cdd5cbb8cee927e8920b0c03e2753
Add blurbhttps://github.com/python/cpython/pull/140835/commits/3cbf28b1397b3cc3f63e6f8f494ff7499cc6f967
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
3cbf28bhttps://github.com/python/cpython/pull/140835/commits/3cbf28b1397b3cc3f63e6f8f494ff7499cc6f967
https://github.com/python/cpython/tree/3cbf28b1397b3cc3f63e6f8f494ff7499cc6f967
Add the walltime resourcehttps://github.com/python/cpython/pull/140835/commits/20703c487083006d54cc998fe433bb32cbeae9d9
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
20703c4https://github.com/python/cpython/pull/140835/commits/20703c487083006d54cc998fe433bb32cbeae9d9
https://github.com/python/cpython/tree/20703c487083006d54cc998fe433bb32cbeae9d9
Merge in the main branchhttps://github.com/python/cpython/pull/140835/commits/5ee397ea49ff03ca1b4aeaa319ccef981c9b5ee6
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
5ee397ehttps://github.com/python/cpython/pull/140835/commits/5ee397ea49ff03ca1b4aeaa319ccef981c9b5ee6
https://github.com/python/cpython/tree/5ee397ea49ff03ca1b4aeaa319ccef981c9b5ee6
Close non-keepalive connections when discarding themhttps://github.com/python/cpython/pull/140835/commits/57634d3c13e52a996418aa2b16f7c0d4bb6d9f44
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
57634d3https://github.com/python/cpython/pull/140835/commits/57634d3c13e52a996418aa2b16f7c0d4bb6d9f44
https://github.com/python/cpython/tree/57634d3c13e52a996418aa2b16f7c0d4bb6d9f44
Show WarningMessage details in __repr__https://github.com/python/cpython/pull/140835/commits/d329345dda0c4aa26133a5ab0bef7181b74ed921
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
d329345https://github.com/python/cpython/pull/140835/commits/d329345dda0c4aa26133a5ab0bef7181b74ed921
https://github.com/python/cpython/tree/d329345dda0c4aa26133a5ab0bef7181b74ed921
Investigating: turn warnings to errors to get tracebackshttps://github.com/python/cpython/pull/140835/commits/9ca07e811e83fcf1dcb421b81b8bf0482d92e9a8
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
9ca07e8https://github.com/python/cpython/pull/140835/commits/9ca07e811e83fcf1dcb421b81b8bf0482d92e9a8
https://github.com/python/cpython/tree/9ca07e811e83fcf1dcb421b81b8bf0482d92e9a8
import warningshttps://github.com/python/cpython/pull/140835/commits/cd9d5f85fe9e661f57552915241a04427f803ca4
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
cd9d5f8https://github.com/python/cpython/pull/140835/commits/cd9d5f85fe9e661f57552915241a04427f803ca4
https://github.com/python/cpython/tree/cd9d5f85fe9e661f57552915241a04427f803ca4
Don't retry -- network errors skip the test, anywayhttps://github.com/python/cpython/pull/140835/commits/c477938605868831222328fb848743e7d0521550
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
c477938https://github.com/python/cpython/pull/140835/commits/c477938605868831222328fb848743e7d0521550
https://github.com/python/cpython/tree/c477938605868831222328fb848743e7d0521550
Don't turn warnings into errorshttps://github.com/python/cpython/pull/140835/commits/432bac2c953b5b60051b9490f164c4f963307af8
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
432bac2https://github.com/python/cpython/pull/140835/commits/432bac2c953b5b60051b9490f164c4f963307af8
https://github.com/python/cpython/tree/432bac2c953b5b60051b9490f164c4f963307af8
Skip new test on on PPC64LE for nowhttps://github.com/python/cpython/pull/140835/commits/d20a4510864633043430906ce86feb574b759f7a
https://github.com/encukou
encukouhttps://github.com/python/cpython/commits?author=encukou
d20a451https://github.com/python/cpython/pull/140835/commits/d20a4510864633043430906ce86feb574b759f7a
https://github.com/python/cpython/tree/d20a4510864633043430906ce86feb574b759f7a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.