René's URL Explorer Experiment


Title: bpo-35998: Avoid TimeoutError in test_asyncio: test_start_tls_server_1() by asvetlov · Pull Request #14080 · python/cpython · GitHub

Open Graph Title: bpo-35998: Avoid TimeoutError in test_asyncio: test_start_tls_server_1() by asvetlov · Pull Request #14080 · python/cpython

X Title: bpo-35998: Avoid TimeoutError in test_asyncio: test_start_tls_server_1() by asvetlov · Pull Request #14080 · python/cpython

Description: The test was not robust because it used to rely on sock.shutdown(socket.SHUT_RDWR) before sock.close(). Actually, sometimes these socket state changes are merged into the just transition into the socket-closed state on the peer side. I don't want to add sleep(N) between calls, it is the easiest way to add new test flakiness. The start_tls test doesn't need to check proto.eof_received() callback receiving, there are other explicit tests for it. The test is changed to receive TSL encrypted data and send an acknowledgment back before client socket closing. Now everything works smoothly, I don't see any timeout exceptions even under very heavy testing. https://bugs.python.org/issue35998

Open Graph Description: The test was not robust because it used to rely on sock.shutdown(socket.SHUT_RDWR) before sock.close(). Actually, sometimes these socket state changes are merged into the just transition into the s...

X Description: The test was not robust because it used to rely on sock.shutdown(socket.SHUT_RDWR) before sock.close(). Actually, sometimes these socket state changes are merged into the just transition into the s...

Opengraph URL: https://github.com/python/cpython/pull/14080

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:449718d1-bb98-4ec4-53ce-5e2ce61c88d4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id84D0:4DD06:291A:3569:6B021E26
html-safe-nonceaf471199945e98b80ecd0b52903741a7ddbe59ad72e8ce079ee287639a53fabc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NEQwOjRERDA2OjI5MUE6MzU2OTo2QjAyMUUyNiIsInZpc2l0b3JfaWQiOiI5MTI4Mjk5MzY0MTQwMzI2NDM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6099ab6ed4bf208c0ee757aebef68e7a36870cdc7d6946718042218d91879fc9
hovercard-subject-tagpull_request:288349059
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/14080/files
twitter:imagehttps://avatars.githubusercontent.com/u/356399?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/356399?s=400&v=4
og:image:altThe test was not robust because it used to rely on sock.shutdown(socket.SHUT_RDWR) before sock.close(). Actually, sometimes these socket state changes are merged into the just transition into the s...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/14080/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14080%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14080%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/14080/files
Reloadhttps://github.com/python/cpython/pull/14080/files
Reloadhttps://github.com/python/cpython/pull/14080/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
asvetlov:fix-sslhttps://github.com/asvetlov/cpython/tree/fix-ssl
Conversation 12 https://github.com/python/cpython/pull/14080
Commits 2 https://github.com/python/cpython/pull/14080/commits
Checks 0 https://github.com/python/cpython/pull/14080/checks
Files changed https://github.com/python/cpython/pull/14080/files
Please reload this pagehttps://github.com/python/cpython/pull/14080/files
bpo-35998: Avoid TimeoutError in test_asyncio: test_start_tls_server_1() https://github.com/python/cpython/pull/14080/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/14080/files
e048999 Avoid TimeoutError in test_asyncio: test_start_tls_server_1() asvetlov Jun 14, 2019 https://github.com/python/cpython/pull/14080/commits/e048999ca7969718785d5af3bc948b9c00c8a5a0
2a50df0 Drop unused variable asvetlov Jun 14, 2019 https://github.com/python/cpython/pull/14080/commits/2a50df06489879b8266215efc426de4b9580d583
Clear filters https://github.com/python/cpython/pull/14080/files
Please reload this pagehttps://github.com/python/cpython/pull/14080/files
Please reload this pagehttps://github.com/python/cpython/pull/14080/files
test_sslproto.py https://github.com/python/cpython/pull/14080/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
2019-06-14-17-05-49.bpo-35998.yX82oD.rst https://github.com/python/cpython/pull/14080/files#diff-95c74787741845d0d99fa76a6d2fa56af3bebdec0b52ccf0ab27a28daa6518bd
Lib/test/test_asyncio/test_sslproto.pyhttps://github.com/python/cpython/pull/14080/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
View file https://github.com/asvetlov/cpython/blob/2a50df06489879b8266215efc426de4b9580d583/Lib/test/test_asyncio/test_sslproto.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14080/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14080/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/14080/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/14080/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/14080/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
https://github.com/python/cpython/pull/14080/files#diff-b0872a36b23aba6bcdc8de20fae7d2ba78e18885ff8f6b7a5b5e6b2953f0d2a7
Misc/NEWS.d/next/Tests/2019-06-14-17-05-49.bpo-35998.yX82oD.rsthttps://github.com/python/cpython/pull/14080/files#diff-95c74787741845d0d99fa76a6d2fa56af3bebdec0b52ccf0ab27a28daa6518bd
View file https://github.com/asvetlov/cpython/blob/2a50df06489879b8266215efc426de4b9580d583/Misc/NEWS.d/next/Tests/2019-06-14-17-05-49.bpo-35998.yX82oD.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14080/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.