René's URL Explorer Experiment


Title: gh-140691: Close FTP connection on error in urllib.request by codenamenam · Pull Request #140694 · python/cpython · GitHub

Open Graph Title: gh-140691: Close FTP connection on error in urllib.request by codenamenam · Pull Request #140694 · python/cpython

X Title: gh-140691: Close FTP connection on error in urllib.request by codenamenam · Pull Request #140694 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: When FTP request fails after the control connection has been established (e.g., timeout during file retrieval), the connection was not being closed, causing a ResourceWarning. This fix ensures that...

X Description: When FTP request fails after the control connection has been established (e.g., timeout during file retrieval), the connection was not being closed, causing a ResourceWarning. This fix ensures that...

Opengraph URL: https://github.com/python/cpython/pull/140694

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d6a97c8a-b19b-f342-dba2-e57c2cc9d5a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCDD0:2A1EC8:75BFA8:942EA0:6B021053
html-safe-noncec1db11ea21cba204023028879983cfbf429dba484ed7d9d0c97aff7ba7e92d26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDREQwOjJBMUVDODo3NUJGQTg6OTQyRUEwOjZCMDIxMDUzIiwidmlzaXRvcl9pZCI6IjY3MDc5NTM0OTc0Nzc4Nzc4NDMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac888f76f95349ec7c95fd192dff61c1b19993640a6a708bf675f5b2b853c821f4
hovercard-subject-tagpull_request:2953329805
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/140694/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4c729c795e8c24478b15a9bd036b9c0f55b620e97dcd8e560ebc585b3f5b1eee/python/cpython/pull/140694
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4c729c795e8c24478b15a9bd036b9c0f55b620e97dcd8e560ebc585b3f5b1eee/python/cpython/pull/140694
og:image:altWhen FTP request fails after the control connection has been established (e.g., timeout during file retrieval), the connection was not being closed, causing a ResourceWarning. This fix ensures that...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecodenamenam
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/140694#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140694
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140694
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/140694
Reloadhttps://github.com/python/cpython/pull/140694
Reloadhttps://github.com/python/cpython/pull/140694
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
codenamenamhttps://github.com/codenamenam
python:mainhttps://github.com/python/cpython/tree/main
codenamenam:fix-issue-140691https://github.com/codenamenam/cpython/tree/fix-issue-140691
Conversationhttps://github.com/python/cpython/pull/140694
Commits0 (0)https://github.com/python/cpython/pull/140694/commits
Checkshttps://github.com/python/cpython/pull/140694/checks
Files changedhttps://github.com/python/cpython/pull/140694/files
gh-140691: Close FTP connection on error in urllib.requesthttps://github.com/python/cpython/pull/140694#top
codenamenamhttps://github.com/codenamenam
python:mainhttps://github.com/python/cpython/tree/main
codenamenam:fix-issue-140691https://github.com/codenamenam/cpython/tree/fix-issue-140691
https://github.com/codenamenam
codenamenamhttps://github.com/codenamenam
Oct 28, 2025https://github.com/python/cpython/pull/140694#issue-3559386334
Please reload this pagehttps://github.com/python/cpython/pull/140694
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 28, 2025https://github.com/python/cpython/pull/140694#event-20540548741
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 28, 2025 https://github.com/python/cpython/pull/140694#ref-issue-3559101446
Unclosed socket in urllib when ftp request times out after connect #140691 https://github.com/python/cpython/issues/140691
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Oct 28, 2025 https://github.com/python/cpython/pull/140694#pullrequestreview-3386213669
View reviewed changes https://github.com/python/cpython/pull/140694/files
Lib/urllib/request.pyhttps://github.com/python/cpython/pull/140694/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Oct 28, 2025 https://github.com/python/cpython/pull/140694#pullrequestreview-3386214569
View reviewed changes https://github.com/python/cpython/pull/140694/files
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/140694/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
Please reload this pagehttps://github.com/python/cpython/pull/140694
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/140694/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
cmaloneyhttps://github.com/cmaloney
Oct 28, 2025https://github.com/python/cpython/pull/140694#discussion_r2467633624
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Oct 28, 2025 https://github.com/python/cpython/pull/140694#pullrequestreview-3386228988
View reviewed changes https://github.com/python/cpython/pull/140694/files
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/140694/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
cmaloneyhttps://github.com/cmaloney
Oct 28, 2025https://github.com/python/cpython/pull/140694#discussion_r2467637680
Please reload this pagehttps://github.com/python/cpython/pull/140694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/cmaloney
cmaloneyhttps://github.com/cmaloney
Oct 28, 2025 https://github.com/python/cpython/pull/140694#pullrequestreview-3386708324
View reviewed changes https://github.com/python/cpython/pull/140694/files
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/140694/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
cmaloneyhttps://github.com/cmaloney
Oct 28, 2025https://github.com/python/cpython/pull/140694#discussion_r2467971629
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_oncehttps://docs.python.org/3/library/unittest.mock.html#unittest.mock.Mock.assert_called_once
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/encukou
encukouhttps://github.com/encukou
Oct 28, 2025 https://github.com/python/cpython/pull/140694#pullrequestreview-3387995110
View reviewed changes https://github.com/python/cpython/pull/140694/files
Lib/urllib/request.pyhttps://github.com/python/cpython/pull/140694/files#diff-1b72fd8dc0aaa51a5ba3af938d3e3bdea8ab5635c0c2d9e098f9825f5b47b03f
encukouhttps://github.com/encukou
Oct 28, 2025https://github.com/python/cpython/pull/140694#discussion_r2468979346
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/encukou
encukouhttps://github.com/encukou
Oct 28, 2025https://github.com/python/cpython/pull/140694#issuecomment-3455807080
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/codenamenam
codenamenamhttps://github.com/codenamenam
Oct 29, 2025https://github.com/python/cpython/pull/140694#event-20569151094
https://github.com/codenamenam
codenamenamhttps://github.com/codenamenam
force-pushedhttps://github.com/python/cpython/compare/d44e990002544f3440544d88db481860ac3acc9f..f5394c257ce4118394fe5ff561a2b0ad238a8d65
d44e990https://github.com/python/cpython/commit/d44e990002544f3440544d88db481860ac3acc9f
f5394c2https://github.com/python/cpython/commit/f5394c257ce4118394fe5ff561a2b0ad238a8d65
Compare https://github.com/python/cpython/compare/d44e990002544f3440544d88db481860ac3acc9f..f5394c257ce4118394fe5ff561a2b0ad238a8d65
October 29, 2025 03:19https://github.com/python/cpython/pull/140694#event-20569151116
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140694
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/python/cpython/pull/140694/files/d44e990002544f3440544d88db481860ac3acc9f
https://github.com/cmaloney
cmaloney https://github.com/cmaloney
https://github.com/python/cpython/pull/140694/files/d44e990002544f3440544d88db481860ac3acc9f
Please reload this pagehttps://github.com/python/cpython/pull/140694
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/140694
https://github.com/codenamenam
https://github.com/encukou
https://github.com/cmaloney
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.