René's URL Explorer Experiment


Title: [3.7] bpo-36402: Fix threading._shutdown() race condition (GH-13948) (GH-14050) by miss-islington · Pull Request #14054 · python/cpython · GitHub

Open Graph Title: [3.7] bpo-36402: Fix threading._shutdown() race condition (GH-13948) (GH-14050) by miss-islington · Pull Request #14054 · python/cpython

X Title: [3.7] bpo-36402: Fix threading._shutdown() race condition (GH-13948) (GH-14050) by miss-islington · Pull Request #14054 · python/cpython

Description: bpo-36402: Fix threading._shutdown() race condition (GH-13948) Fix a race condition at Python shutdown when waiting for threads. Wait until the Python thread state of all non-daemon threads get deleted (join all non-daemon threads), rather than just wait until Python threads complete. Add threading._shutdown_locks: set of Thread._tstate_lock locks of non-daemon threads used by _shutdown() to wait until all Python thread states get deleted. See Thread._set_tstate_lock(). Add also threading._shutdown_locks_lock to protect access to threading._shutdown_locks. Add test_finalization_shutdown() test. (cherry picked from commit 468e5fe) bpo-36402: Fix threading.Thread._stop() (GH-14047) Remove the _tstate_lock from _shutdown_locks, don't remove None. (cherry picked from commit 6f75c87) (cherry picked from commit e40a97a) Co-authored-by: Victor Stinner vstinner@redhat.com https://bugs.python.org/issue36402

Open Graph Description: bpo-36402: Fix threading._shutdown() race condition (GH-13948) Fix a race condition at Python shutdown when waiting for threads. Wait until the Python thread state of all non-daemon threads get de...

X Description: bpo-36402: Fix threading._shutdown() race condition (GH-13948) Fix a race condition at Python shutdown when waiting for threads. Wait until the Python thread state of all non-daemon threads get de...

Opengraph URL: https://github.com/python/cpython/pull/14054

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:694056a6-f097-c3f5-4949-af3490f4fa93
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC526:23560F:3254945:448132F:6A53EE32
html-safe-noncea157ad3ed226cbb5a096c3a5295766198d9b9f406ac953f7ae9b5a4576fac007
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTI2OjIzNTYwRjozMjU0OTQ1OjQ0ODEzMkY6NkE1M0VFMzIiLCJ2aXNpdG9yX2lkIjoiODAxNjQzMjA3NzUxNDk5MzIwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2372fcdf7bfad6915f2ac0549bbc6d8f9ef47bf3c25acfb81cac3b730f9b4686
hovercard-subject-tagpull_request:287887216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/14054/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altbpo-36402: Fix threading._shutdown() race condition (GH-13948) Fix a race condition at Python shutdown when waiting for threads. Wait until the Python thread state of all non-daemon threads get de...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/14054/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14054%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F14054%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/14054/files
Reloadhttps://github.com/python/cpython/pull/14054/files
Reloadhttps://github.com/python/cpython/pull/14054/files
Please reload this pagehttps://github.com/python/cpython/pull/14054/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/14054/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.7https://github.com/python/cpython/tree/3.7
miss-islington:backport-e40a97a-3.7https://github.com/miss-islington/cpython/tree/backport-e40a97a-3.7
Conversation 1 https://github.com/python/cpython/pull/14054
Commits 1 https://github.com/python/cpython/pull/14054/commits
Checks 0 https://github.com/python/cpython/pull/14054/checks
Files changed https://github.com/python/cpython/pull/14054/files
Please reload this pagehttps://github.com/python/cpython/pull/14054/files
[3.7] bpo-36402: Fix threading._shutdown() race condition (GH-13948) (GH-14050) https://github.com/python/cpython/pull/14054/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/14054/files
247fb9d [3.8] bpo-36402: Fix threading._shutdown() race condition (GH-13948) … vstinner Jun 13, 2019 https://github.com/python/cpython/pull/14054/commits/247fb9d32aa60c9c67a9a5db377a7125310e0cf9
Clear filters https://github.com/python/cpython/pull/14054/files
Please reload this pagehttps://github.com/python/cpython/pull/14054/files
Please reload this pagehttps://github.com/python/cpython/pull/14054/files
test_threading.py https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
threading.py https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
2019-06-11-00-35-02.bpo-36402.b0IJVp.rst https://github.com/python/cpython/pull/14054/files#diff-bcb3d6dab37f72c04117938799b830c4d1f6a1c2d12b4e9b5e63af0ff8d37cf0
Lib/test/test_threading.pyhttps://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
View file https://github.com/miss-islington/cpython/blob/247fb9d32aa60c9c67a9a5db377a7125310e0cf9/Lib/test/test_threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14054/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
https://github.com/python/cpython/pull/14054/files#diff-8b4c7f5f9b60a27c4132899af6fa7157c7f1e57a0b6213bc616fe72fba04c168
Lib/threading.pyhttps://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
View file https://github.com/miss-islington/cpython/blob/247fb9d32aa60c9c67a9a5db377a7125310e0cf9/Lib/threading.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14054/{{ revealButtonHref }}
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
https://github.com/python/cpython/pull/14054/files#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
Misc/NEWS.d/next/Library/2019-06-11-00-35-02.bpo-36402.b0IJVp.rsthttps://github.com/python/cpython/pull/14054/files#diff-bcb3d6dab37f72c04117938799b830c4d1f6a1c2d12b4e9b5e63af0ff8d37cf0
View file https://github.com/miss-islington/cpython/blob/247fb9d32aa60c9c67a9a5db377a7125310e0cf9/Misc/NEWS.d/next/Library/2019-06-11-00-35-02.bpo-36402.b0IJVp.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/14054/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.