René's URL Explorer Experiment


Title: gh-140476: Optimize PySet_Add() for frozenset in free-threading by yoney · Pull Request #140440 · python/cpython · GitHub

Open Graph Title: gh-140476: Optimize PySet_Add() for frozenset in free-threading by yoney · Pull Request #140440 · python/cpython

X Title: gh-140476: Optimize PySet_Add() for frozenset in free-threading by yoney · Pull Request #140440 · python/cpython

Description: In the fbthrift-python benchmarks, we observed a performance regression when comparing Python 3.14t to 3.14, particularly during Thrift struct initialization and deserialization. The regression was linked to the use of the PySet_Add() API for populating set and frozenset objects, where a critical section is always applied—even when the set is uniquely referenced during the initialization phase. By skipping the critical section for uniquely referenced frozenset, we were able to reduce the regression. In a micro-benchmark specifically targeting PySet_Add(), we observed a 19% performance improvement on Intel Broadwell systems and around 27% improvement on ARM/GH200 systems. cc: @mpage @colesbury @Yhg1s Issue: gh-140476

Open Graph Description: In the fbthrift-python benchmarks, we observed a performance regression when comparing Python 3.14t to 3.14, particularly during Thrift struct initialization and deserialization. The regression was...

X Description: In the fbthrift-python benchmarks, we observed a performance regression when comparing Python 3.14t to 3.14, particularly during Thrift struct initialization and deserialization. The regression was...

Opengraph URL: https://github.com/python/cpython/pull/140440

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a0b328eb-a75a-3d29-2b60-0bf8864a1854
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA10:A70A9:2166B34:2BED964:6B0241E0
html-safe-nonceb7c6cfa57163ea73d13a63926686bbe3f8f8ab03d2a3344488446177a32f250b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTEwOkE3MEE5OjIxNjZCMzQ6MkJFRDk2NDo2QjAyNDFFMCIsInZpc2l0b3JfaWQiOiI3MTkwOTU4MDExOTgzMjE3MTIwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac04888f0ed51ba4cca529ac678adb43970afcdc638ef2f724c99c98b1ca1aeaf2
hovercard-subject-tagpull_request:2935134950
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/140440/files
twitter:imagehttps://avatars.githubusercontent.com/u/2095011?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2095011?s=400&v=4
og:image:altIn the fbthrift-python benchmarks, we observed a performance regression when comparing Python 3.14t to 3.14, particularly during Thrift struct initialization and deserialization. The regression was...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/140440/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140440%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140440%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/140440/files
Reloadhttps://github.com/python/cpython/pull/140440/files
Reloadhttps://github.com/python/cpython/pull/140440/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
yoney:ft_set_frozensethttps://github.com/yoney/cpython/tree/ft_set_frozenset
Conversation 15 https://github.com/python/cpython/pull/140440
Commits 6 https://github.com/python/cpython/pull/140440/commits
Checks 0 https://github.com/python/cpython/pull/140440/checks
Files changed https://github.com/python/cpython/pull/140440/files
Please reload this pagehttps://github.com/python/cpython/pull/140440/files
gh-140476: Optimize PySet_Add() for frozenset in free-threading https://github.com/python/cpython/pull/140440/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/140440/files
d1aaf9a Optimize PySet_Add for uniquely referenced sets in free-threading yoney Oct 21, 2025 https://github.com/python/cpython/pull/140440/commits/d1aaf9aa257b3877425a279ccb6ee984fda6c153
37ac4ce Improve comments yoney Oct 22, 2025 https://github.com/python/cpython/pull/140440/commits/37ac4ce442fe622dd41410dabd272cec7026d3af
48a4017 Add news entry yoney Oct 22, 2025 https://github.com/python/cpython/pull/140440/commits/48a4017a4080f028abfd503f25beb63b223d7f4f
0932e16 Only for frozenset yoney Oct 23, 2025 https://github.com/python/cpython/pull/140440/commits/0932e1641181891ca904149183f8b4dc1508740f
68ecfe5 Fix the condition yoney Oct 23, 2025 https://github.com/python/cpython/pull/140440/commits/68ecfe52617d8ff43d46e8b84e9b82fda85b8c1e
c22066f Merge branch 'main' into ft_set_frozenset kumaraditya303 Nov 2, 2025 https://github.com/python/cpython/pull/140440/commits/c22066f2bbacba0e8f97efcb18e571e05de51b18
Clear filters https://github.com/python/cpython/pull/140440/files
Please reload this pagehttps://github.com/python/cpython/pull/140440/files
Please reload this pagehttps://github.com/python/cpython/pull/140440/files
2025-10-22-12-48-05.gh-issue-140476.F3-d1P.rst https://github.com/python/cpython/pull/140440/files#diff-f5340f7664091fa7552643e4395cc08e470d468d75f2693c5611f79163e274d6
setobject.c https://github.com/python/cpython/pull/140440/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
Misc/NEWS.d/next/Core_and_Builtins/2025-10-22-12-48-05.gh-issue-140476.F3-d1P.rsthttps://github.com/python/cpython/pull/140440/files#diff-f5340f7664091fa7552643e4395cc08e470d468d75f2693c5611f79163e274d6
View file https://github.com/yoney/cpython/blob/c22066f2bbacba0e8f97efcb18e571e05de51b18/Misc/NEWS.d/next/Core_and_Builtins/2025-10-22-12-48-05.gh-issue-140476.F3-d1P.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/140440/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L216
Objects/setobject.chttps://github.com/python/cpython/pull/140440/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
View file https://github.com/yoney/cpython/blob/c22066f2bbacba0e8f97efcb18e571e05de51b18/Objects/setobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/140440/{{ revealButtonHref }}
https://github.com/python/cpython/pull/140440/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com/python/cpython/pull/140440/files#diff-537c6127e75079330edcb3775b0b9c2e4aeb34530dfe224ef2c96c3acb42111f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.