Title: gh-140239: Check for statx on Android by jbosboom · Pull Request #140395 · python/cpython · GitHub
Open Graph Title: gh-140239: Check for statx on Android by jbosboom · Pull Request #140395 · python/cpython
X Title: gh-140239: Check for statx on Android by jbosboom · Pull Request #140395 · python/cpython
Description: #140249 inadvertently disabled checking for statx on Android because MACHDEP is "android" on Android. You can verify this by looking at the logs from the Android runner from #140249. This is a cross-compile. In the "Configure build Python" logs, MACHDEP is linux and configure checks for statx; in the "Configure host Python" logs, MACHDEP is android and configure doesn't check for statx (would be just after checking for writev). Base the check for statx on ac_sys_system instead, which is Linux-android on Android, Linux on other Linux distributions, and AIX on AIX (which has an incompatible function named statx that prompted #140249). Before merging: Please look at the Android build log to make sure both the build and host Python configure check for statx. (The host Python check will result in no because the Android CI uses Android API level 24 and statx was introduced in Android API level 30.) Verified, the host Python configure checks for statx. People are building for API levels higher than 30, given issue #123014, so this PR is not theoretical. If the Android buildbots still exist and use API level 30 or higher (#123014 indicates they "will" use 34), please run the Android buildbots to make sure the tests pass. (I can't do this myself.) cc @ayappanec as author of #140249 cc @vstinner as reviewer of statx-related PRs cc @mhsmith as Android buildbot operator and Android maintainer (There's a "$MACHDEP" != linux check just below the code this PR changes, which does not exclude Android as may have been intended. Android introduced lchmod in API level 36. lchmod delegates to fchmodat with AT_SYMLINK_NOFOLLOW, and fchmodat has code that should work on non-symlinks and give the correct errno for symlinks, so I think the behavior is acceptable, but we aren't testing it. That can be a separate issue/PR if it's a problem.) Issue: gh-140239
Open Graph Description: #140249 inadvertently disabled checking for statx on Android because MACHDEP is "android" on Android. You can verify this by looking at the logs from the Android runner from #140249. Th...
X Description: #140249 inadvertently disabled checking for statx on Android because MACHDEP is "android" on Android. You can verify this by looking at the logs from the Android runner from #140...
Opengraph URL: https://github.com/python/cpython/pull/140395
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f6ad8240-bf5a-70a1-fde7-5a63e3aa90b3 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CE1C:5348:1F34361:2CE63E2:6A565AA8 |
| html-safe-nonce | baf92796efe2fe55c3934ac0074133a92693a53680e528c6ce33b7cde2058933 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTFDOjUzNDg6MUYzNDM2MToyQ0U2M0UyOjZBNTY1QUE4IiwidmlzaXRvcl9pZCI6IjY1NjMyMDgzMDY0MDc5MjIzNDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 337a6eb2be2362d273c6c06fd97673480dd5a6a2df72c5a5dfde052661f88e0c |
| hovercard-subject-tag | pull_request:2931979865 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/140395/files |
| twitter:image | https://avatars.githubusercontent.com/u/7757340?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/7757340?s=400&v=4 |
| og:image:alt | #140249 inadvertently disabled checking for statx on Android because MACHDEP is "android" on Android. You can verify this by looking at the logs from the Android runner from #140249. Th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 6a3afe34dff341ad10912db44becf282289d7f2af20576241738530fbb28de01 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | b71002134df95575e9f6c2945a64d454b0be181e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width