René's URL Explorer Experiment


Title: gh-116738: Make _suggestions module thread-safe by yoney · Pull Request #140321 · python/cpython · GitHub

Open Graph Title: gh-116738: Make _suggestions module thread-safe by yoney · Pull Request #140321 · python/cpython

X Title: gh-116738: Make _suggestions module thread-safe by yoney · Pull Request #140321 · python/cpython

Description: Added a critical section to protect the candidates list in the free-threading build, addressing two possible issues below: In the free-threading build, PyList_GetItem() could fail and return NULL....

Open Graph Description: Added a critical section to protect the candidates list in the free-threading build, addressing two possible issues below: In the free-threading build, PyList_GetItem() could fail and return NULL....

X Description: Added a critical section to protect the candidates list in the free-threading build, addressing two possible issues below: In the free-threading build, PyList_GetItem() could fail and return NULL....

Opengraph URL: https://github.com/python/cpython/pull/140321

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e4123b3e-4f69-378c-cfd1-ea441b813afa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCBBA:388B78:14B97C:1ADC6C:696AD6A8
html-safe-nonce82defac3a1cea92f4e5943753d797e7df6e62504137658db96185e977bb42c5a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQkJBOjM4OEI3ODoxNEI5N0M6MUFEQzZDOjY5NkFENkE4IiwidmlzaXRvcl9pZCI6Ijg0NTA3NjkyOTQxMDk0NjcyOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac40bad86208c9123e41182ed128dcc6917613556ef4f59c7ee622ecb3a9cd64c1
hovercard-subject-tagpull_request:2927328188
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/140321/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b66792397329d90f051852821957f31a59b16ac51736d3dc257a09bc98ad9262/python/cpython/pull/140321
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b66792397329d90f051852821957f31a59b16ac51736d3dc257a09bc98ad9262/python/cpython/pull/140321
og:image:altAdded a critical section to protect the candidates list in the free-threading build, addressing two possible issues below: In the free-threading build, PyList_GetItem() could fail and return NULL....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyoney
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/140321#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140321
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140321
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/140321
Reloadhttps://github.com/python/cpython/pull/140321
Reloadhttps://github.com/python/cpython/pull/140321
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/140321
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/140321
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/140321#issue-comment-box
corona10https://github.com/corona10
python:mainhttps://github.com/python/cpython/tree/main
yoney:ft_suggestionshttps://github.com/yoney/cpython/tree/ft_suggestions
gh-116738: Make _suggestions module thread-safe https://github.com/python/cpython/pull/140321#top
corona10https://github.com/corona10
python:mainhttps://github.com/python/cpython/tree/main
yoney:ft_suggestionshttps://github.com/yoney/cpython/tree/ft_suggestions
Conversation 7 https://github.com/python/cpython/pull/140321
Commits 2 https://github.com/python/cpython/pull/140321/commits
Checks 51 https://github.com/python/cpython/pull/140321/checks
Files changed 4 https://github.com/python/cpython/pull/140321/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/yoney
yoneyhttps://github.com/yoney
Oct 19, 2025https://github.com/python/cpython/pull/140321#issue-3529482965
Please reload this pagehttps://github.com/python/cpython/pull/140321
cpython/Modules/_suggestions.chttps://github.com/python/cpython/blob/bedaea05987738c4c6b958d19cec9621bec09f07/Modules/_suggestions.c#L31-L33
bedaea0https://github.com/python/cpython/commit/bedaea05987738c4c6b958d19cec9621bec09f07
cpython/Python/suggestions.chttps://github.com/python/cpython/blob/bedaea05987738c4c6b958d19cec9621bec09f07/Python/suggestions.c#L150-L153
bedaea0https://github.com/python/cpython/commit/bedaea05987738c4c6b958d19cec9621bec09f07
@mpagehttps://github.com/mpage
@colesburyhttps://github.com/colesbury
Audit all built-in modules for thread safety #116738https://github.com/python/cpython/issues/116738
Please reload this pagehttps://github.com/python/cpython/pull/140321
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _suggestions module thread-safehttps://github.com/python/cpython/pull/140321/commits/f9cef6b021dba02a6fe79f8ff02172a17cbed78c
f9cef6bhttps://github.com/python/cpython/pull/140321/commits/f9cef6b021dba02a6fe79f8ff02172a17cbed78c
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 19, 2025 https://github.com/python/cpython/pull/140321#ref-issue-2184479275
Audit all built-in modules for thread safety #116738 https://github.com/python/cpython/issues/116738
https://github.com/yoney
pythongh-116738https://github.com/python/cpython/issues/116738
: Remove module reference from NEWShttps://github.com/python/cpython/pull/140321/commits/b6937c2d994f14227d6a5f0d3369d29bacd54310
b6937c2https://github.com/python/cpython/pull/140321/commits/b6937c2d994f14227d6a5f0d3369d29bacd54310
https://github.com/yoney
yoneyhttps://github.com/yoney
October 19, 2025 04:44https://github.com/python/cpython/pull/140321#event-20363739464
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 19, 2025https://github.com/python/cpython/pull/140321#event-20363739556
https://github.com/corona10
corona10https://github.com/corona10
Oct 19, 2025 https://github.com/python/cpython/pull/140321#pullrequestreview-3354539634
View reviewed changes https://github.com/python/cpython/pull/140321/files/b6937c2d994f14227d6a5f0d3369d29bacd54310
Modules/_suggestions.chttps://github.com/python/cpython/pull/140321/files/b6937c2d994f14227d6a5f0d3369d29bacd54310#diff-b78a1c274df173a72761bfb3e6a4660a1f5bdba3bb0c9da67dfc1adfff800f7d
corona10https://github.com/corona10
Oct 19, 2025https://github.com/python/cpython/pull/140321#discussion_r2443328650
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/140321
yoneyhttps://github.com/yoney
Oct 20, 2025https://github.com/python/cpython/pull/140321#discussion_r2443678210
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@corona10https://github.com/corona10
Please reload this pagehttps://github.com/python/cpython/pull/140321
corona10https://github.com/corona10
Oct 20, 2025https://github.com/python/cpython/pull/140321#discussion_r2445141928
Please reload this pagehttps://github.com/python/cpython/pull/140321
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@yoneyhttps://github.com/yoney
cpython/Include/cpython/listobject.hhttps://github.com/python/cpython/blob/f11ec6e643f54f4ee698f7dfc878812a315f2af4/Include/cpython/listobject.h#L40
f11ec6ehttps://github.com/python/cpython/commit/f11ec6e643f54f4ee698f7dfc878812a315f2af4
Please reload this pagehttps://github.com/python/cpython/pull/140321
yoneyhttps://github.com/yoney
Oct 20, 2025https://github.com/python/cpython/pull/140321#discussion_r2445386262
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@corona10https://github.com/corona10
cpython/Objects/listobject.chttps://github.com/python/cpython/blob/f11ec6e643f54f4ee698f7dfc878812a315f2af4/Objects/listobject.c#L384-L397
f11ec6ehttps://github.com/python/cpython/commit/f11ec6e643f54f4ee698f7dfc878812a315f2af4
Please reload this pagehttps://github.com/python/cpython/pull/140321
corona10https://github.com/corona10
Oct 22, 2025https://github.com/python/cpython/pull/140321#discussion_r2450018919
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/140321
https://github.com/corona10
corona10https://github.com/corona10
Oct 22, 2025 https://github.com/python/cpython/pull/140321#pullrequestreview-3363145124
View reviewed changes https://github.com/python/cpython/pull/140321/files/b6937c2d994f14227d6a5f0d3369d29bacd54310
corona10https://github.com/corona10
https://github.com/python/cpython/pull/140321#pullrequestreview-3363145124
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/140321
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 22, 2025https://github.com/python/cpython/pull/140321#event-20417628430
https://github.com/corona10
corona10https://github.com/corona10
b3a3843https://github.com/python/cpython/commit/b3a38438d83245e52dff80f348c7fde539333cea
Oct 22, 2025https://github.com/python/cpython/pull/140321#event-20417631798
Please reload this pagehttps://github.com/python/cpython/pull/140321
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 22, 2025https://github.com/python/cpython/pull/140321#event-20417632252
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Oct 22, 2025https://github.com/python/cpython/pull/140321#issuecomment-3430026535
b3a3843https://github.com/python/cpython/commit/b3a38438d83245e52dff80f348c7fde539333cea
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/725/builds/12157https://buildbot.python.org/#/builders/725/builds/12157
b3a3843https://github.com/python/cpython/commit/b3a38438d83245e52dff80f348c7fde539333cea
https://buildbot.python.org/#/builders/725/builds/12157https://buildbot.python.org/#/builders/725/builds/12157
Please reload this pagehttps://github.com/python/cpython/pull/140321
https://github.com/yoney
yoneyhttps://github.com/yoney
October 28, 2025 15:51https://github.com/python/cpython/pull/140321#event-20557783973
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Nov 20, 2025https://github.com/python/cpython/pull/140321#event-21066734158
StanFromIrelandhttps://github.com/StanFromIreland
Dec 6, 2025 https://github.com/python/cpython/pull/140321#ref-commit-e78b5c9
https://github.com/yoney
https://github.com/StanFromIreland
pythongh-116738https://github.com/python/cpython/issues/116738
: Make _suggestions module thread-safe (https://github.com/StanFromIreland/cpython/commit/e78b5c996ab57e3c18be95de4f111a5b3618f061
pythongh-140321https://github.com/python/cpython/pull/140321
)https://github.com/StanFromIreland/cpython/commit/e78b5c996ab57e3c18be95de4f111a5b3618f061
e78b5c9https://github.com/StanFromIreland/cpython/commit/e78b5c996ab57e3c18be95de4f111a5b3618f061
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F140321
https://github.com/corona10
corona10 https://github.com/corona10
https://github.com/python/cpython/pull/140321/files/b6937c2d994f14227d6a5f0d3369d29bacd54310
topic-free-threading https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atopic-free-threading
Please reload this pagehttps://github.com/python/cpython/pull/140321
https://github.com/yoney
https://github.com/bedevere-bot
https://github.com/corona10
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.