René's URL Explorer Experiment


Title: gh-139877: Use PyBytesWriter in pycore_blocks_output_buffer.h by emmatyping · Pull Request #139976 · python/cpython · GitHub

Open Graph Title: gh-139877: Use PyBytesWriter in pycore_blocks_output_buffer.h by emmatyping · Pull Request #139976 · python/cpython

X Title: gh-139877: Use PyBytesWriter in pycore_blocks_output_buffer.h by emmatyping · Pull Request #139976 · python/cpython

Description: Currently, the _BlocksOutputBuffer code creates a list of bytes objects to handle the output data from compression libraries. This ends up being slow due to the output buffer code needing to copy each bytes element of the list into the final bytes object buffer at the end of compression. The new PyBytesWriter API introduced in PEP 782 is an ergonomic and fast method of writing data into a buffer that will later turn into a bytes object. Benchmarks show that using the PyBytesWriter API is 10-30% faster for decompression across a variety of settings. The performance gains are greatest when the decompressor is very performant, such as for Zstandard. Otherwise the decompressor can bottleneck decompression and the gains are more modest, but still sizable (e.g. zlib)! Issue: gh-139877

Open Graph Description: Currently, the _BlocksOutputBuffer code creates a list of bytes objects to handle the output data from compression libraries. This ends up being slow due to the output buffer code needing to copy e...

X Description: Currently, the _BlocksOutputBuffer code creates a list of bytes objects to handle the output data from compression libraries. This ends up being slow due to the output buffer code needing to copy e...

Opengraph URL: https://github.com/python/cpython/pull/139976

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:7b55fbd4-203d-8110-85dc-fd7e0dad6dda
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD506:2D40DE:2DCD0B4:3A56FB5:6B01F8CE
html-safe-noncefacfb9200449abec12ad8e5744b8477307b1472618842585c9ebd8df311c79ba
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTA2OjJENDBERToyRENEMEI0OjNBNTZGQjU6NkIwMUY4Q0UiLCJ2aXNpdG9yX2lkIjoiNDY4Mzc1Mjk1MTUxOTUwODY4NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac264323ed236d5466e3211b33a418e016039a23dde9154d5aca38ca8d521e7e90
hovercard-subject-tagpull_request:2907169663
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/139976/files
twitter:imagehttps://avatars.githubusercontent.com/u/9504279?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/9504279?s=400&v=4
og:image:altCurrently, the _BlocksOutputBuffer code creates a list of bytes objects to handle the output data from compression libraries. This ends up being slow due to the output buffer code needing to copy e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/139976/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139976%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139976%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/139976/files
Reloadhttps://github.com/python/cpython/pull/139976/files
Reloadhttps://github.com/python/cpython/pull/139976/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
emmatypinghttps://github.com/emmatyping
python:mainhttps://github.com/python/cpython/tree/main
emmatyping:output-buffer-use-pybyteswriterhttps://github.com/emmatyping/cpython/tree/output-buffer-use-pybyteswriter
Conversation 19 https://github.com/python/cpython/pull/139976
Commits 7 https://github.com/python/cpython/pull/139976/commits
Checks 0 https://github.com/python/cpython/pull/139976/checks
Files changed https://github.com/python/cpython/pull/139976/files
Please reload this pagehttps://github.com/python/cpython/pull/139976/files
gh-139877: Use PyBytesWriter in pycore_blocks_output_buffer.h https://github.com/python/cpython/pull/139976/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/139976/files
086c79a Use PyBytesWriter in pycore_blocks_output_buffer.h emmatyping Oct 12, 2025 https://github.com/python/cpython/pull/139976/commits/086c79ab9a053e8b34253d6ed297718b88cbb3bc
29a8230 Fix lint emmatyping Oct 12, 2025 https://github.com/python/cpython/pull/139976/commits/29a8230e5060a47396a93156849eaed3baedd26b
ffd48e4 Cast data buffer to char * for Windows emmatyping Oct 12, 2025 https://github.com/python/cpython/pull/139976/commits/ffd48e406ee28a94cbd0afa905fb30564f554200
2336d0e Respond to review from Bénédikt emmatyping Oct 13, 2025 https://github.com/python/cpython/pull/139976/commits/2336d0e5c2fbc26f7cf2f5754c52fdd2b2421e66
dfd1c25 Respond to more review from Bénédikt emmatyping Oct 13, 2025 https://github.com/python/cpython/pull/139976/commits/dfd1c25b83f8efe39e8be09e9e1eda7b205ea50a
e5f3661 Update Include/internal/pycore_blocks_output_buffer.h emmatyping Oct 13, 2025 https://github.com/python/cpython/pull/139976/commits/e5f3661b6931cca86775bc7787116f8c829bf195
029c53c Refactor block size calculation emmatyping Oct 13, 2025 https://github.com/python/cpython/pull/139976/commits/029c53c192c9569366f87ec53bf472355378c346
Clear filters https://github.com/python/cpython/pull/139976/files
Please reload this pagehttps://github.com/python/cpython/pull/139976/files
Please reload this pagehttps://github.com/python/cpython/pull/139976/files
pycore_blocks_output_buffer.h https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
_bz2module.c https://github.com/python/cpython/pull/139976/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
_lzmamodule.c https://github.com/python/cpython/pull/139976/files#diff-604739065f6d9a2f56bed1e9d1fd56b51e212e9acd630a92ccac9fe8390fa4d9
buffer.h https://github.com/python/cpython/pull/139976/files#diff-b411ab1ada83e68fe0942b294e8ed9e52e81a2e4dacb2ec38250e0f9738ac2a9
compressor.c https://github.com/python/cpython/pull/139976/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
decompressor.c https://github.com/python/cpython/pull/139976/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
zlibmodule.c https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
Include/internal/pycore_blocks_output_buffer.hhttps://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
View file https://github.com/emmatyping/cpython/blob/029c53c192c9569366f87ec53bf472355378c346/Include/internal/pycore_blocks_output_buffer.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
Please reload this pagehttps://github.com/python/cpython/pull/139976/files
Please reload this pagehttps://github.com/python/cpython/pull/139976/files
https://github.com/python/cpython/pull/139976/files#diff-137d424d36904214cf556dd06f59386410f53a13f222a46ceeed30b7a9f6c234
Modules/_bz2module.chttps://github.com/python/cpython/pull/139976/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
View file https://github.com/emmatyping/cpython/blob/029c53c192c9569366f87ec53bf472355378c346/Modules/_bz2module.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139976/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/139976/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/139976/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/139976/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
Modules/_lzmamodule.chttps://github.com/python/cpython/pull/139976/files#diff-604739065f6d9a2f56bed1e9d1fd56b51e212e9acd630a92ccac9fe8390fa4d9
View file https://github.com/emmatyping/cpython/blob/029c53c192c9569366f87ec53bf472355378c346/Modules/_lzmamodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139976/files#diff-604739065f6d9a2f56bed1e9d1fd56b51e212e9acd630a92ccac9fe8390fa4d9
https://github.com/python/cpython/pull/139976/files#diff-604739065f6d9a2f56bed1e9d1fd56b51e212e9acd630a92ccac9fe8390fa4d9
https://github.com/python/cpython/pull/139976/files#diff-604739065f6d9a2f56bed1e9d1fd56b51e212e9acd630a92ccac9fe8390fa4d9
https://github.com/python/cpython/pull/139976/files#diff-604739065f6d9a2f56bed1e9d1fd56b51e212e9acd630a92ccac9fe8390fa4d9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L665
Modules/_zstd/buffer.hhttps://github.com/python/cpython/pull/139976/files#diff-b411ab1ada83e68fe0942b294e8ed9e52e81a2e4dacb2ec38250e0f9738ac2a9
View file https://github.com/emmatyping/cpython/blob/029c53c192c9569366f87ec53bf472355378c346/Modules/_zstd/buffer.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139976/files#diff-b411ab1ada83e68fe0942b294e8ed9e52e81a2e4dacb2ec38250e0f9738ac2a9
https://github.com/python/cpython/pull/139976/files#diff-b411ab1ada83e68fe0942b294e8ed9e52e81a2e4dacb2ec38250e0f9738ac2a9
https://github.com/python/cpython/pull/139976/files#diff-b411ab1ada83e68fe0942b294e8ed9e52e81a2e4dacb2ec38250e0f9738ac2a9
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L665
Modules/_zstd/compressor.chttps://github.com/python/cpython/pull/139976/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
View file https://github.com/emmatyping/cpython/blob/029c53c192c9569366f87ec53bf472355378c346/Modules/_zstd/compressor.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139976/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/139976/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/139976/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/pull/139976/files#diff-e7579a24d7495a5e7ec25e3834af991e480cacbf1a955ad78ab08148d9304e7d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L665
Modules/_zstd/decompressor.chttps://github.com/python/cpython/pull/139976/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
View file https://github.com/emmatyping/cpython/blob/029c53c192c9569366f87ec53bf472355378c346/Modules/_zstd/decompressor.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139976/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
https://github.com/python/cpython/pull/139976/files#diff-5b717a4e417388ae310008129390ff165e9273f8183293709512e4c4feaa4889
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L656
Modules/zlibmodule.chttps://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
View file https://github.com/emmatyping/cpython/blob/029c53c192c9569366f87ec53bf472355378c346/Modules/zlibmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139976/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com/python/cpython/pull/139976/files#diff-295b58a9ad1abea83244636cd413e54a5114dcaf34df95f8ca5db806fc6ab188
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.