René's URL Explorer Experiment


Title: gh-139935: fix flaky test for test_getlogin by yihong0618 · Pull Request #139936 · python/cpython · GitHub

Open Graph Title: gh-139935: fix flaky test for test_getlogin by yihong0618 · Pull Request #139936 · python/cpython

X Title: gh-139935: fix flaky test for test_getlogin by yihong0618 · Pull Request #139936 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: as info in the issue and diff Issue: Some errors are not caught by test_os.LoginTests.test_getlogin #139935

X Description: as info in the issue and diff Issue: Some errors are not caught by test_os.LoginTests.test_getlogin #139935

Opengraph URL: https://github.com/python/cpython/pull/139936

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6f54c356-2b44-f418-b393-1074c004a0bc
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA6AA:1F372:15E60B:1CE6BF:6A5588BB
html-safe-nonce996d7ad9825233c23804a6f60f6b6d36c3a01c44eb87598e1af61727ff20c9a6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkFBOjFGMzcyOjE1RTYwQjoxQ0U2QkY6NkE1NTg4QkIiLCJ2aXNpdG9yX2lkIjoiOTE2MDQxMzU1NTAzMTc1ODY3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1ee03283b7c7971e87b7e62742ed4177bb6887117dae7ba8610bc57fe70b4820
hovercard-subject-tagpull_request:2906050163
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/139936/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f7768ac6c961b25544d3cc5cf65dcb5c2f09113764ff81c4884db8b38644ad90/python/cpython/pull/139936
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f7768ac6c961b25544d3cc5cf65dcb5c2f09113764ff81c4884db8b38644ad90/python/cpython/pull/139936
og:image:altas info in the issue and diff Issue: Some errors are not caught by test_os.LoginTests.test_getlogin #139935
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameyihong0618
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3215163789b3dc58dba97bd78a30c20c949f477f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/139936#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139936
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139936
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/139936
Reloadhttps://github.com/python/cpython/pull/139936
Reloadhttps://github.com/python/cpython/pull/139936
Please reload this pagehttps://github.com/python/cpython/pull/139936
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/139936
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
Conversationhttps://github.com/python/cpython/pull/139936
Commits5 (5)https://github.com/python/cpython/pull/139936/commits
Checkshttps://github.com/python/cpython/pull/139936/checks
Files changedhttps://github.com/python/cpython/pull/139936/files
gh-139935: fix flaky test for test_getloginhttps://github.com/python/cpython/pull/139936#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
https://github.com/yihong0618
yihong0618https://github.com/yihong0618
Oct 11, 2025https://github.com/python/cpython/pull/139936#issue-3505210866
Please reload this pagehttps://github.com/python/cpython/pull/139936
Some errors are not caught by test_os.LoginTests.test_getlogin #139935https://github.com/python/cpython/issues/139935
Please reload this pagehttps://github.com/python/cpython/pull/139936
https://github.com/yihong0618
fix: flaky test for test_getloginhttps://github.com/python/cpython/pull/139936/commits/55cd97ae977ad12868f84c4ffe9a004ef9b1121c
55cd97ahttps://github.com/python/cpython/pull/139936/commits/55cd97ae977ad12868f84c4ffe9a004ef9b1121c
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 11, 2025https://github.com/python/cpython/pull/139936#event-20221649047
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Oct 11, 2025 https://github.com/python/cpython/pull/139936#ref-issue-3505206593
Some errors are not caught by test_os.LoginTests.test_getlogin #139935 https://github.com/python/cpython/issues/139935
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Oct 11, 2025https://github.com/python/cpython/pull/139936#event-20222891763
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Oct 11, 2025https://github.com/python/cpython/pull/139936#issuecomment-3393094726
Please reload this pagehttps://github.com/python/cpython/pull/139936
https://github.com/yihong0618
yihong0618https://github.com/yihong0618
Oct 11, 2025https://github.com/python/cpython/pull/139936#issuecomment-3393095387
Please reload this pagehttps://github.com/python/cpython/pull/139936
Please reload this pagehttps://github.com/python/cpython/pull/139936
yihong0618https://github.com/yihong0618
October 11, 2025 17:17https://github.com/python/cpython/pull/139936#commits-pushed-9881bf8
https://github.com/yihong0618
fix: drop no need news apply commentshttps://github.com/python/cpython/pull/139936/commits/9881bf8cc71d5630d93c53d3b1d382a0a5eb9cb0
9881bf8https://github.com/python/cpython/pull/139936/commits/9881bf8cc71d5630d93c53d3b1d382a0a5eb9cb0
https://github.com/yihong0618
fix: apply comments for all errorshttps://github.com/python/cpython/pull/139936/commits/779c396090a43df91b2908750344fbe97de6fe7f
779c396https://github.com/python/cpython/pull/139936/commits/779c396090a43df91b2908750344fbe97de6fe7f
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Oct 11, 2025 https://github.com/python/cpython/pull/139936#pullrequestreview-3327019621
View reviewed changes https://github.com/python/cpython/pull/139936/files/779c396090a43df91b2908750344fbe97de6fe7f
Lib/test/test_os/test_os.pyhttps://github.com/python/cpython/pull/139936/files/779c396090a43df91b2908750344fbe97de6fe7f#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
Please reload this pagehttps://github.com/python/cpython/pull/139936
yihong0618https://github.com/yihong0618
October 11, 2025 20:02https://github.com/python/cpython/pull/139936#commits-pushed-b4599e3
https://github.com/yihong0618
https://github.com/picnixz
Update Lib/test/test_os/test_os.pyhttps://github.com/python/cpython/pull/139936/commits/b4599e39ff26b6b20ffa98202511823e9ccacb92
b4599e3https://github.com/python/cpython/pull/139936/commits/b4599e39ff26b6b20ffa98202511823e9ccacb92
https://github.com/yihong0618
fix: change the name by commentshttps://github.com/python/cpython/pull/139936/commits/62f1577534ebfb288fda753522039771b4c8e283
62f1577https://github.com/python/cpython/pull/139936/commits/62f1577534ebfb288fda753522039771b4c8e283
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Oct 11, 2025 https://github.com/python/cpython/pull/139936#pullrequestreview-3327026697
View reviewed changes https://github.com/python/cpython/pull/139936/files/62f1577534ebfb288fda753522039771b4c8e283
Lib/test/test_os/test_os.pyhttps://github.com/python/cpython/pull/139936/files/62f1577534ebfb288fda753522039771b4c8e283#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
picnixzhttps://github.com/picnixz
Oct 11, 2025https://github.com/python/cpython/pull/139936#discussion_r2422766133
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139936
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Oct 11, 2025 https://github.com/python/cpython/pull/139936#pullrequestreview-3327026897
View reviewed changes https://github.com/python/cpython/pull/139936/files/62f1577534ebfb288fda753522039771b4c8e283
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Oct 11, 2025https://github.com/python/cpython/pull/139936#event-20223870056
https://github.com/picnixz
picnixzhttps://github.com/picnixz
October 11, 2025 12:09https://github.com/python/cpython/pull/139936#event-20223901985
https://github.com/picnixz
picnixzhttps://github.com/picnixz
897a36bhttps://github.com/python/cpython/commit/897a36baddb3611865a839c6345315da689c52a1
Oct 11, 2025https://github.com/python/cpython/pull/139936#event-20224028140
Please reload this pagehttps://github.com/python/cpython/pull/139936
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Oct 11, 2025https://github.com/python/cpython/pull/139936#event-20224028627
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Oct 11, 2025 https://github.com/python/cpython/pull/139936#pullrequestreview-3327157222
View reviewed changes https://github.com/python/cpython/pull/139936/files/62f1577534ebfb288fda753522039771b4c8e283
Lib/test/test_os/test_os.pyhttps://github.com/python/cpython/pull/139936/files/62f1577534ebfb288fda753522039771b4c8e283#diff-0c3c0e7d77a166e9089c5ddcc9d2db7c4fab9528044dec1fda4b3a6be569f784
vstinnerhttps://github.com/vstinner
Oct 11, 2025https://github.com/python/cpython/pull/139936#discussion_r2422832475
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139936
picnixzhttps://github.com/picnixz
Oct 11, 2025https://github.com/python/cpython/pull/139936#discussion_r2422836861
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139936
picnixzhttps://github.com/picnixz
Oct 11, 2025https://github.com/python/cpython/pull/139936#discussion_r2422838760
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139936
yihong0618https://github.com/yihong0618
Oct 11, 2025https://github.com/python/cpython/pull/139936#discussion_r2422846397
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139936
picnixzhttps://github.com/picnixz
Oct 11, 2025https://github.com/python/cpython/pull/139936#discussion_r2422860272
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139936
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139936
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/139936/files/62f1577534ebfb288fda753522039771b4c8e283
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/139936/files/62f1577534ebfb288fda753522039771b4c8e283
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/139936
https://github.com/yihong0618
https://github.com/picnixz
https://github.com/vstinner
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.