René's URL Explorer Experiment


Title: gh-139819: rlcompleter – avoid suggesting attributes not accessible on instances by ttw225 · Pull Request #139820 · python/cpython · GitHub

Open Graph Title: gh-139819: rlcompleter – avoid suggesting attributes not accessible on instances by ttw225 · Pull Request #139820 · python/cpython

X Title: gh-139819: rlcompleter – avoid suggesting attributes not accessible on instances by ttw225 · Pull Request #139820 · python/cpython

Description: Fix tab-completion suggesting names that are not accessible on instances (e.g., Enum members showing __name__). Change In rlcompleter.attr_matches(), when getattr(thisobject, word, None) is None, only add the candidate if hasattr(thisobject, word) is true. Effect Removes bogus suggestions without affecting valid completions. Bogus suggestions ['Color.BLUE.__iter__', 'Color.BLUE.__getitem__', 'Color.BLUE.__members__', 'Color.BLUE.__contains__', 'Color.BLUE.__qualname__', 'Color.BLUE.__len__', 'Color.BLUE.__name__'] # Additionally seen among bogus suggestions: 'Enum.__abstractmethods__' Issue: gh-139819

Open Graph Description: Fix tab-completion suggesting names that are not accessible on instances (e.g., Enum members showing __name__). Change In rlcompleter.attr_matches(), when getattr(thisobject, word, None) is None, o...

X Description: Fix tab-completion suggesting names that are not accessible on instances (e.g., Enum members showing __name__). Change In rlcompleter.attr_matches(), when getattr(thisobject, word, None) is None, o...

Opengraph URL: https://github.com/python/cpython/pull/139820

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9f9cbdbc-7f7b-cdb2-62c2-34cc00004427
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA09E:1BB425:2CB807A:3CCD1C8:6A53C9A5
html-safe-noncebd51bbbc979e816b0cd994aef640c6f824a20cd61dedbcb91983a94bed802b74
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDlFOjFCQjQyNToyQ0I4MDdBOjNDQ0QxQzg6NkE1M0M5QTUiLCJ2aXNpdG9yX2lkIjoiNzU1MDQwODE0NTcxMTEyMjg1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace931ec4d8b09c551731f6926e0503e2685633dec26c1d9167a79dea640af56dd
hovercard-subject-tagpull_request:2899304034
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/139820/files
twitter:imagehttps://avatars.githubusercontent.com/u/35064951?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/35064951?s=400&v=4
og:image:altFix tab-completion suggesting names that are not accessible on instances (e.g., Enum members showing __name__). Change In rlcompleter.attr_matches(), when getattr(thisobject, word, None) is None, o...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/139820/changes#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139820%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139820%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/139820/changes
Reloadhttps://github.com/python/cpython/pull/139820/changes
Reloadhttps://github.com/python/cpython/pull/139820/changes
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ethanfurmanhttps://github.com/ethanfurman
python:mainhttps://github.com/python/cpython/tree/main
ttw225:fix/rlcompleterhttps://github.com/ttw225/cpython/tree/fix/rlcompleter
Conversation 5 https://github.com/python/cpython/pull/139820
Commits 9 https://github.com/python/cpython/pull/139820/commits
Checks 50 https://github.com/python/cpython/pull/139820/checks
Files changed https://github.com/python/cpython/pull/139820/files
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
gh-139819: rlcompleter – avoid suggesting attributes not accessible on instances https://github.com/python/cpython/pull/139820/changes#top
Show all changes 9 commits https://github.com/python/cpython/pull/139820/files
8466abc fix(Lib/rlcompleter): prevent suggesting non-existent attributes ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/8466abcc81ad852f444a0d324b08867d70e92f0c
1655dc6 docs(NEWS.d): gh-issue-139819 ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/1655dc62578c40daa5c7f947f707d4787b8d035f
394432e refactor(Lib/rlcompleter.py): Simplify conditional expression ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/394432e72c9e6787750638d512bdb7604a1468e5
d567f83 test(test_rlcompleter): adjust test_excessive_getattr call count expe… ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/d567f83898f01ec8944fabd44c515a13c355678f
ad6ff8e fix(Lib/rlcompleter): handle unassigned __slots__ attributes in compl… ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/ad6ff8eba4e18df69a5f43c920e96550a34da24d
8d98bab refactor(Lib/rlcompleter): use sentinel to properly handle None-value… ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/8d98babad7415132abb3f6144b08257e0ced3985
14bd61e test(test_rlcompleter): update test_excessive_getattr for sentinel ap… ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/14bd61e61fb972a958df49f1c5d2deebcae7c99f
76e32a3 test(test_rlcompleter): remove unintended test_enum_member_completion… ttw225 Oct 9, 2025 https://github.com/python/cpython/pull/139820/commits/76e32a3482543f1b2d67f158e44ab93bb85a6d30
7482968 Merge branch 'main' into fix/rlcompleter ethanfurman Jun 8, 2026 https://github.com/python/cpython/pull/139820/commits/7482968f1495d7826f868928107d70dff4b2ef2c
Clear filters https://github.com/python/cpython/pull/139820/files
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
rlcompleter.py https://github.com/python/cpython/pull/139820/changes#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
test_rlcompleter.py https://github.com/python/cpython/pull/139820/changes#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
2025-10-09-12-13-29.gh-issue-139819.YxUDyH.rst https://github.com/python/cpython/pull/139820/changes#diff-c6020a34790bba495a2aaf5d757f1a9d4fc495efbf57fe3c47940822ec86351f
Lib/rlcompleter.pyhttps://github.com/python/cpython/pull/139820/changes#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
View file https://github.com/ttw225/cpython/blob/7482968f1495d7826f868928107d70dff4b2ef2c/Lib/rlcompleter.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139820/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139820/changes#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
danielhollashttps://github.com/danielhollas
Jun 9, 2026https://github.com/python/cpython/pull/139820/changes#r3383624838
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
Viicoshttps://github.com/Viicos
Jun 10, 2026https://github.com/python/cpython/pull/139820/changes#r3386410787
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#151222https://github.com/python/cpython/pull/151222
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
https://github.com/python/cpython/pull/139820/changes#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
https://github.com/python/cpython/pull/139820/changes#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
https://github.com/python/cpython/pull/139820/changes#diff-4c595af1c40cad3e9df9558541803a1e3b09173e61cd6ebcc7999baf2c77a876
Lib/test/test_rlcompleter.pyhttps://github.com/python/cpython/pull/139820/changes#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
View file https://github.com/ttw225/cpython/blob/7482968f1495d7826f868928107d70dff4b2ef2c/Lib/test/test_rlcompleter.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139820/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139820/changes#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
https://github.com/python/cpython/pull/139820/changes#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
https://github.com/python/cpython/pull/139820/changes#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
https://github.com/python/cpython/pull/139820/changes#diff-1fca42d4e5423d0d1cc14f41f8f79319eaec3aa51d6810e04b2fea720a99eb18
Misc/NEWS.d/next/Library/2025-10-09-12-13-29.gh-issue-139819.YxUDyH.rsthttps://github.com/python/cpython/pull/139820/changes#diff-c6020a34790bba495a2aaf5d757f1a9d4fc495efbf57fe3c47940822ec86351f
View file https://github.com/ttw225/cpython/blob/7482968f1495d7826f868928107d70dff4b2ef2c/Misc/NEWS.d/next/Library/2025-10-09-12-13-29.gh-issue-139819.YxUDyH.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139820/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/139820/changes
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.