René's URL Explorer Experiment


Title: gh-139269: Fix unaligned memory access in JIT code patching functions by ashm-dev · Pull Request #139271 · python/cpython · GitHub

Open Graph Title: gh-139269: Fix unaligned memory access in JIT code patching functions by ashm-dev · Pull Request #139271 · python/cpython

X Title: gh-139269: Fix unaligned memory access in JIT code patching functions by ashm-dev · Pull Request #139271 · python/cpython

Description: This PR fixes a series of misaligned memory access errors in the JIT engine that were causing segmentation faults when running tests with AddressSanitizer (ASan) and UndefinedBehaviorSanitizer (UBSan) enabled. The unsafe direct pointer casts in patch_32, patch_32r, patch_64, and patch_x86_64_32rx have been replaced with memcpy to ensure safe, alignment-agnostic memory operations. Issue: gh-139269

Open Graph Description: This PR fixes a series of misaligned memory access errors in the JIT engine that were causing segmentation faults when running tests with AddressSanitizer (ASan) and UndefinedBehaviorSanitizer (UBS...

X Description: This PR fixes a series of misaligned memory access errors in the JIT engine that were causing segmentation faults when running tests with AddressSanitizer (ASan) and UndefinedBehaviorSanitizer (UBS...

Opengraph URL: https://github.com/python/cpython/pull/139271

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e6b09c36-d401-db05-975c-acc5bff4d0e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC446:34CAB:4A31246:5E973B1:6B02667A
html-safe-noncefc6d4876eaf29b18f214f7ec80899359d3eac130e16ef01189f6e5142851dfdf
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDQ2OjM0Q0FCOjRBMzEyNDY6NUU5NzNCMTo2QjAyNjY3QSIsInZpc2l0b3JfaWQiOiI4MzkyOTgwMTEwOTk4OTIyODc0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacbeea7892814cc1345bc2d450e2ba41bfc156d11750d0f1656bd591cc1edde1c3
hovercard-subject-tagpull_request:2854091742
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/139271/files
twitter:imagehttps://avatars.githubusercontent.com/u/173620149?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/173620149?s=400&v=4
og:image:altThis PR fixes a series of misaligned memory access errors in the JIT engine that were causing segmentation faults when running tests with AddressSanitizer (ASan) and UndefinedBehaviorSanitizer (UBS...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/139271/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139271%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139271%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/139271/files
Reloadhttps://github.com/python/cpython/pull/139271/files
Reloadhttps://github.com/python/cpython/pull/139271/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Fidget-Spinnerhttps://github.com/Fidget-Spinner
python:mainhttps://github.com/python/cpython/tree/main
ashm-dev:gh-139269https://github.com/ashm-dev/cpython/tree/gh-139269
Conversation 54 https://github.com/python/cpython/pull/139271
Commits 22 https://github.com/python/cpython/pull/139271/commits
Checks 0 https://github.com/python/cpython/pull/139271/checks
Files changed https://github.com/python/cpython/pull/139271/files
Please reload this pagehttps://github.com/python/cpython/pull/139271/files
gh-139269: Fix unaligned memory access in JIT code patching functions https://github.com/python/cpython/pull/139271/files#top
Show all changes 22 commits https://github.com/python/cpython/pull/139271/files
2f49286 Use memcpy for patching values instead of direct assignment ashm-dev Sep 23, 2025 https://github.com/python/cpython/pull/139271/commits/2f49286258b7338d4ac0a23de83208005fbcabaf
f6765ba Add news entry for JIT unaligned store fix in patch_* functions ashm-dev Sep 23, 2025 https://github.com/python/cpython/pull/139271/commits/f6765bab79646cadd49b7f844d7e0811a1f2bc3f
b036772 Merge branch 'main' into gh-139269 ashm-dev Sep 23, 2025 https://github.com/python/cpython/pull/139271/commits/b0367728e02bc87deb16de32736325729f9463b1
c45d0cc Remove unused local variables from patch functions ashm-dev Sep 23, 2025 https://github.com/python/cpython/pull/139271/commits/c45d0ccb91ee195bc81d94d266bb86e1568980eb
cf3c01b Merge remote-tracking branch 'upstream/main' into gh-139269 ashm-dev Sep 23, 2025 https://github.com/python/cpython/pull/139271/commits/cf3c01b24f84ad287673176a968075e7cccbc45b
827aa7e Merge branch 'main' into gh-139269 ashm-dev Sep 24, 2025 https://github.com/python/cpython/pull/139271/commits/827aa7e2ed63643a0dc161599ad929e0f92f54a4
684ff40 Fix UB in JIT patch_* functions with unaligned store ashm-dev Sep 24, 2025 https://github.com/python/cpython/pull/139271/commits/684ff40a0ce12012bc852b459e863c9822f0730d
2c1339b Merge remote-tracking branch 'upstream/main' into gh-139269 ashm-dev Sep 24, 2025 https://github.com/python/cpython/pull/139271/commits/2c1339b2a583e5b79b537c1f48cf1b1ef220d9c6
b5a8686 Update Misc/NEWS.d/next/Core_and_Builtins/2025-09-23-21-01-12.gh-issu… ashm-dev Sep 24, 2025 https://github.com/python/cpython/pull/139271/commits/b5a86861e86299e6b045b275d8b1623dc98022e8
d266ac0 Merge remote-tracking branch 'upstream/main' into gh-139269 ashm-dev Sep 24, 2025 https://github.com/python/cpython/pull/139271/commits/d266ac0fdee4f6a206e7481b234b6de10b818105
f075c91 Merge branch 'main' into gh-139269 ashm-dev Sep 28, 2025 https://github.com/python/cpython/pull/139271/commits/f075c91ff9fcbf5a192760b6ffd36a7010363670
d19cf62 Use memcpy in set_bits to avoid alignment issues ashm-dev Sep 28, 2025 https://github.com/python/cpython/pull/139271/commits/d19cf627842ba469cfb142185e61b86cbf226e50
c2cf365 Merge remote-tracking branch 'upstream/main' into gh-139269 ashm-dev Sep 28, 2025 https://github.com/python/cpython/pull/139271/commits/c2cf365177372f4c2eff3cc15452c0ea64086adf
c36c2b7 Merge branch 'main' into gh-139269 ashm-dev Sep 29, 2025 https://github.com/python/cpython/pull/139271/commits/c36c2b7854798a5dec3268b435e94e191a4d5113
1e35b61 Track global and builtins dependencies for LOAD_GLOBAL ashm-dev Sep 29, 2025 https://github.com/python/cpython/pull/139271/commits/1e35b6195cba3efdbb3651076bd274c5f8e77d44
3f327a5 Merge branch 'main' into gh-139269 ashm-dev Sep 29, 2025 https://github.com/python/cpython/pull/139271/commits/3f327a585c38893ed16b508caef51ef9dd2ec6a2
39bcc4c Remove comments marking proposed fix in LOAD_GLOBAL case ashm-dev Sep 29, 2025 https://github.com/python/cpython/pull/139271/commits/39bcc4ce61d0addb20edacf010efc921a7bea638
5e6670e Merge remote-tracking branch 'upstream/main' into gh-139269 ashm-dev Oct 8, 2025 https://github.com/python/cpython/pull/139271/commits/5e6670e63cebefde36051ae3495d091e2e1c3355
44e9cf7 remove LOAD_GLOBAL ashm-dev Oct 8, 2025 https://github.com/python/cpython/pull/139271/commits/44e9cf74ab63eb2fc36ca3ee757f9869894ca981
3ddbcf2 Merge remote-tracking branch 'upstream/main' into gh-139270 ashm-dev Oct 9, 2025 https://github.com/python/cpython/pull/139271/commits/3ddbcf287ee8b1dab74a5bd82c6dbd3e819a9512
71ea00a Merge remote-tracking branch 'upstream/main' into gh-139269 ashm-dev Oct 10, 2025 https://github.com/python/cpython/pull/139271/commits/71ea00a5c1461e344cad40998028290ee45d62ce
3b819af Merge remote-tracking branch 'upstream/main' into gh-139271 ashm-dev Oct 10, 2025 https://github.com/python/cpython/pull/139271/commits/3b819afb9dc11ef2ac2a9f729138fd297a579292
Clear filters https://github.com/python/cpython/pull/139271/files
Please reload this pagehttps://github.com/python/cpython/pull/139271/files
Please reload this pagehttps://github.com/python/cpython/pull/139271/files
2025-09-23-21-01-12.gh-issue-139269.1rIaxy.rst https://github.com/python/cpython/pull/139271/files#diff-7fc8b1af6829e1f206355b8033e1c88dfb0c6def5fd0fe036530ca0983fcd6f2
jit.c https://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
Misc/NEWS.d/next/Core_and_Builtins/2025-09-23-21-01-12.gh-issue-139269.1rIaxy.rsthttps://github.com/python/cpython/pull/139271/files#diff-7fc8b1af6829e1f206355b8033e1c88dfb0c6def5fd0fe036530ca0983fcd6f2
View file https://github.com/ashm-dev/cpython/blob/3b819afb9dc11ef2ac2a9f729138fd297a579292/Misc/NEWS.d/next/Core_and_Builtins/2025-09-23-21-01-12.gh-issue-139269.1rIaxy.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139271/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L291
Python/jit.chttps://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
View file https://github.com/ashm-dev/cpython/blob/3b819afb9dc11ef2ac2a9f729138fd297a579292/Python/jit.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/139271/{{ revealButtonHref }}
https://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
https://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
https://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
https://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
https://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
Please reload this pagehttps://github.com/python/cpython/pull/139271/files
https://github.com/python/cpython/pull/139271/files#diff-d62eca10c65b7e30ce4e711d63b1e6c921c8b90bd4fb08c672d0806025e6d5e0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.