René's URL Explorer Experiment


Title: gh-136003: Close file descriptors in test by encukou · Pull Request #139225 · python/cpython · GitHub

Open Graph Title: gh-136003: Close file descriptors in test by encukou · Pull Request #139225 · python/cpython

X Title: gh-136003: Close file descriptors in test by encukou · Pull Request #139225 · python/cpython

Description: This should fix FD leaks introduced in GH-136004 Issue: Some pre-finalization callbacks can create other callbacks #136003

Open Graph Description: This should fix FD leaks introduced in GH-136004 Issue: Some pre-finalization callbacks can create other callbacks #136003

X Description: This should fix FD leaks introduced in GH-136004 Issue: Some pre-finalization callbacks can create other callbacks #136003

Opengraph URL: https://github.com/python/cpython/pull/139225

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:782cc1f9-a2ff-d7d3-5e42-f798963743ec
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1CE:C16D8:355F2A:4B7BE6:696A4400
html-safe-nonce9ca2556913e026ffca9c408f646dc7a754a5342151743ece2720d23e0488c028
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUNFOkMxNkQ4OjM1NUYyQTo0QjdCRTY6Njk2QTQ0MDAiLCJ2aXNpdG9yX2lkIjoiODk3OTU3MjQ0MjAxODc1OTY4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6208ea0829deccb8fcdea8cbba4832593cfa8b70789698d0f2b0af1c77161dac
hovercard-subject-tagpull_request:2848862384
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/139225/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/58e6480daa4bf907388daf59072761855f50c358fc644717914965ded1bbfa5c/python/cpython/pull/139225
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/58e6480daa4bf907388daf59072761855f50c358fc644717914965ded1bbfa5c/python/cpython/pull/139225
og:image:altThis should fix FD leaks introduced in GH-136004 Issue: Some pre-finalization callbacks can create other callbacks #136003
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/139225#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139225
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139225
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/139225
Reloadhttps://github.com/python/cpython/pull/139225
Reloadhttps://github.com/python/cpython/pull/139225
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/139225
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/139225
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/139225#issue-comment-box
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:unleak-136003https://github.com/encukou/cpython/tree/unleak-136003
gh-136003: Close file descriptors in test https://github.com/python/cpython/pull/139225#top
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
encukou:unleak-136003https://github.com/encukou/cpython/tree/unleak-136003
Conversation 4 https://github.com/python/cpython/pull/139225
Commits 1 https://github.com/python/cpython/pull/139225/commits
Checks 51 https://github.com/python/cpython/pull/139225/checks
Files changed 1 https://github.com/python/cpython/pull/139225/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 22, 2025https://github.com/python/cpython/pull/139225#issue-3440264704
Please reload this pagehttps://github.com/python/cpython/pull/139225
GH-136004https://github.com/python/cpython/pull/136004
Some pre-finalization callbacks can create other callbacks #136003https://github.com/python/cpython/issues/136003
Please reload this pagehttps://github.com/python/cpython/pull/139225
https://github.com/encukou
Close file descriptors in test_pending_call_creates_thread_subinterpr…https://github.com/python/cpython/pull/139225/commits/4f73b8cb89d8ec5898d2886730ad454dc484fdcb
4f73b8chttps://github.com/python/cpython/pull/139225/commits/4f73b8cb89d8ec5898d2886730ad454dc484fdcb
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Sep 22, 2025https://github.com/python/cpython/pull/139225#event-19834532854
https://github.com/encukou
encukouhttps://github.com/encukou
September 22, 2025 10:34https://github.com/python/cpython/pull/139225#event-19834533007
https://github.com/encukou
encukouhttps://github.com/encukou
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/a756a4b95341cda63298fb5628b56c32f43f4f1e/.github/CODEOWNERS#L339
September 22, 2025 10:34https://github.com/python/cpython/pull/139225#event-19834533203
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 22, 2025https://github.com/python/cpython/pull/139225#event-19834534093
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 22, 2025 https://github.com/python/cpython/pull/139225#ref-issue-3180667722
Some pre-finalization callbacks can create other callbacks #136003 https://github.com/python/cpython/issues/136003
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 22, 2025https://github.com/python/cpython/pull/139225#event-19834586008
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 22, 2025 https://github.com/python/cpython/pull/139225#pullrequestreview-3251829654
View reviewed changes https://github.com/python/cpython/pull/139225/files/4f73b8cb89d8ec5898d2886730ad454dc484fdcb
ZeroIntensityhttps://github.com/ZeroIntensity
https://github.com/python/cpython/pull/139225#pullrequestreview-3251829654
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139225
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 22, 2025https://github.com/python/cpython/pull/139225#event-19834718709
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 22, 2025https://github.com/python/cpython/pull/139225#issuecomment-3318203902
Please reload this pagehttps://github.com/python/cpython/pull/139225
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 22, 2025https://github.com/python/cpython/pull/139225#issuecomment-3318204089
@encukouhttps://github.com/encukou
4f73b8chttps://github.com/python/cpython/commit/4f73b8cb89d8ec5898d2886730ad454dc484fdcb
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139225%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139225%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/139225
https://github.com/encukou
encukouhttps://github.com/encukou
61e54e5https://github.com/python/cpython/commit/61e54e52ea48b6716d705294a18c6ac22d90741f
Sep 22, 2025https://github.com/python/cpython/pull/139225#event-19835680194
Please reload this pagehttps://github.com/python/cpython/pull/139225
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 22, 2025https://github.com/python/cpython/pull/139225#event-19835681342
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 22, 2025 https://github.com/python/cpython/pull/139225#ref-pullrequest-3434794995
GH-137218: Fix Makefile to handle FreeBSD (fix for JIT stencil changes) #139170 https://github.com/python/cpython/pull/139170
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 22, 2025https://github.com/python/cpython/pull/139225#issuecomment-3318660687
61e54e5https://github.com/python/cpython/commit/61e54e52ea48b6716d705294a18c6ac22d90741f
the buildbot page in the devguidehttps://devguide.python.org/buildbots/
https://buildbot.python.org/#/builders/506/builds/11471https://buildbot.python.org/#/builders/506/builds/11471
61e54e5https://github.com/python/cpython/commit/61e54e52ea48b6716d705294a18c6ac22d90741f
https://buildbot.python.org/#/builders/506/builds/11471https://buildbot.python.org/#/builders/506/builds/11471
Please reload this pagehttps://github.com/python/cpython/pull/139225
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139225
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/139225/files/4f73b8cb89d8ec5898d2886730ad454dc484fdcb
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/139225
https://github.com/encukou
https://github.com/bedevere-bot
https://github.com/ZeroIntensity
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.