René's URL Explorer Experiment


Title: bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies by tirkarthi · Pull Request #13921 · python/cpython · GitHub

Open Graph Title: bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies by tirkarthi · Pull Request #13921 · python/cpython

X Title: bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookies by tirkarthi · Pull Request #13921 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Handle time comparison for cookies with expires attribute when CookieJar.make_cookies is called. Co-authored-by: Demian Brecht demianbrecht@gmail.com https://bugs.python.org/issue12144 Automerge-...

X Description: Handle time comparison for cookies with expires attribute when CookieJar.make_cookies is called. Co-authored-by: Demian Brecht demianbrecht@gmail.com https://bugs.python.org/issue12144 Automerge-...

Mail addresses
demianbrecht@gmail.com

Opengraph URL: https://github.com/python/cpython/pull/13921

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c3ed3850-1bef-603a-3ee0-b81ec72e6c34
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC668:30A1AE:395CB38:4F459A4:6A54C170
html-safe-nonceaeff65b7d27d79ee670ba357a0514614da243cedf60a54168470a17c35636f78
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjY4OjMwQTFBRTozOTVDQjM4OjRGNDU5QTQ6NkE1NEMxNzAiLCJ2aXNpdG9yX2lkIjoiNzYwMjIxMzE2MDc2NzI0MjYwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e95819694ed31a500614e453d37d2d828c865c640becdb254121d6ebf994884
hovercard-subject-tagpull_request:286420768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13921/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aa9de0d3f20dc84be995323af149eeec29af0ceec2a53e3c85730cb90065c0d9/python/cpython/pull/13921
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa9de0d3f20dc84be995323af149eeec29af0ceec2a53e3c85730cb90065c0d9/python/cpython/pull/13921
og:image:altHandle time comparison for cookies with expires attribute when CookieJar.make_cookies is called. Co-authored-by: Demian Brecht demianbrecht@gmail.com https://bugs.python.org/issue12144 Automerge-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametirkarthi
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release69f9664dd5e7a82ba8ab1b4cb7f5a2f09333ab38
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13921#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13921
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13921
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13921
Reloadhttps://github.com/python/cpython/pull/13921
Reloadhttps://github.com/python/cpython/pull/13921
Please reload this pagehttps://github.com/python/cpython/pull/13921
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13921
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo12144https://github.com/tirkarthi/cpython/tree/bpo12144
Conversationhttps://github.com/python/cpython/pull/13921
Commits2 (2)https://github.com/python/cpython/pull/13921/commits
Checkshttps://github.com/python/cpython/pull/13921/checks
Files changedhttps://github.com/python/cpython/pull/13921/files
bpo-12144: Handle cookies with expires attribute in CookieJar.make_cookieshttps://github.com/python/cpython/pull/13921#top
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo12144https://github.com/tirkarthi/cpython/tree/bpo12144
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
Jun 8, 2019https://github.com/python/cpython/pull/13921#issue-453819488
Please reload this pagehttps://github.com/python/cpython/pull/13921
https://bugs.python.org/issue12144https://bugs.python.org/issue12144
@asvetlovhttps://github.com/asvetlov
Please reload this pagehttps://github.com/python/cpython/pull/13921
tirkarthihttps://github.com/tirkarthi
June 8, 2019 23:22https://github.com/python/cpython/pull/13921#commits-pushed-a4d647b
https://github.com/tirkarthi
https://github.com/demianbrecht
Ensure cookies with expires attribute are handled in make_cookies.https://github.com/python/cpython/pull/13921/commits/a4d647b2a6015697a2db92591b1e4c3da0ced8a1
a4d647bhttps://github.com/python/cpython/pull/13921/commits/a4d647b2a6015697a2db92591b1e4c3da0ced8a1
https://github.com/tirkarthi
Add NEWS entryhttps://github.com/python/cpython/pull/13921/commits/d5f8cd4410985fe82ca3eba1e9aef0ac02741d01
d5f8cd4https://github.com/python/cpython/pull/13921/commits/d5f8cd4410985fe82ca3eba1e9aef0ac02741d01
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jun 8, 2019https://github.com/python/cpython/pull/13921#event-2399063244
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 8, 2019https://github.com/python/cpython/pull/13921#event-2399063256
https://github.com/mangrisano
mangrisanohttps://github.com/mangrisano
Jun 12, 2019 https://github.com/python/cpython/pull/13921#pullrequestreview-248670836
View reviewed changes https://github.com/python/cpython/pull/13921/files/d5f8cd4410985fe82ca3eba1e9aef0ac02741d01
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jun 12, 2019https://github.com/python/cpython/pull/13921#event-2406883441
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
Sep 13, 2019https://github.com/python/cpython/pull/13921#event-2632030772
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
Sep 13, 2019 https://github.com/python/cpython/pull/13921#pullrequestreview-287958881
View reviewed changes https://github.com/python/cpython/pull/13921/files/d5f8cd4410985fe82ca3eba1e9aef0ac02741d01
asvetlovhttps://github.com/asvetlov
https://github.com/python/cpython/pull/13921#pullrequestreview-287958881
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13921
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 13, 2019https://github.com/python/cpython/pull/13921#event-2632031548
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
bb41147https://github.com/python/cpython/commit/bb41147eab15a2958f4ad38261e5bf608f6ace1b
Sep 13, 2019https://github.com/python/cpython/pull/13921#event-2632031642
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 13, 2019https://github.com/python/cpython/pull/13921#issuecomment-531201688
@tirkarthihttps://github.com/tirkarthi
Please reload this pagehttps://github.com/python/cpython/pull/13921
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 13, 2019https://github.com/python/cpython/pull/13921#event-2632031723
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 13, 2019https://github.com/python/cpython/pull/13921#issuecomment-531201725
GH-16088https://github.com/python/cpython/pull/16088
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/13921
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Sep 13, 2019https://github.com/python/cpython/pull/13921#event-2632032044
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 13, 2019https://github.com/python/cpython/pull/13921#issuecomment-531201754
GH-16089https://github.com/python/cpython/pull/16089
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/13921
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 13, 2019https://github.com/python/cpython/pull/13921#issuecomment-531201760
@tirkarthihttps://github.com/tirkarthi
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/13921
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Sep 13, 2019https://github.com/python/cpython/pull/13921#event-2632032410
miss-islingtonhttps://github.com/miss-islington
Sep 13, 2019 https://github.com/python/cpython/pull/13921#ref-commit-767b103
https://github.com/tirkarthi
https://github.com/miss-islington
bpo-12144: Handle cookies with expires attribute in CookieJar.make_co…https://github.com/miss-islington/cpython/commit/767b1030016d9550cae9aaaef868d535862a199e
767b103https://github.com/miss-islington/cpython/commit/767b1030016d9550cae9aaaef868d535862a199e
pythonGH-13921https://github.com/python/cpython/pull/13921
https://bugs.python.org/issue12144https://bugs.python.org/issue12144
@asvetlovhttps://github.com/asvetlov
bb41147https://github.com/miss-islington/cpython/commit/bb41147eab15a2958f4ad38261e5bf608f6ace1b
miss-islingtonhttps://github.com/miss-islington
Sep 13, 2019 https://github.com/python/cpython/pull/13921#ref-commit-44cb89a
https://github.com/miss-islington
https://github.com/tirkarthi
bpo-12144https://bugs.python.org/issue?@action=redirect&bpo=12144
: Handle cookies with expires attribute in CookieJar.make_co…https://github.com/python/cpython/commit/44cb89a78a308b7a613bdd01539ec84be914d693
44cb89ahttps://github.com/python/cpython/commit/44cb89a78a308b7a613bdd01539ec84be914d693
GH-13921https://github.com/python/cpython/pull/13921
https://bugs.python.org/issue12144https://bugs.python.org/issue12144
@asvetlovhttps://github.com/asvetlov
bb41147https://github.com/python/cpython/commit/bb41147eab15a2958f4ad38261e5bf608f6ace1b
tirkarthihttps://github.com/tirkarthi
Sep 13, 2019 https://github.com/python/cpython/pull/13921#ref-commit-ffc5ad0
https://github.com/tirkarthi
[3.7] bpo-12144: Handle cookies with expires attribute in CookieJar.m…https://github.com/tirkarthi/cpython/commit/ffc5ad02b3e467e1bf5a7d8593baaddc2bab1b66
ffc5ad0https://github.com/tirkarthi/cpython/commit/ffc5ad02b3e467e1bf5a7d8593baaddc2bab1b66
pythonGH-13921https://github.com/python/cpython/pull/13921
https://bugs.python.org/issue12144https://bugs.python.org/issue12144
@asvetlovhttps://github.com/asvetlov
bb41147https://github.com/tirkarthi/cpython/commit/bb41147eab15a2958f4ad38261e5bf608f6ace1b
tirkarthihttps://github.com/tirkarthi
Sep 13, 2019 https://github.com/python/cpython/pull/13921#ref-commit-f190d45
https://github.com/tirkarthi
[3.7] bpo-12144: Handle cookies with expires attribute in CookieJar.m…https://github.com/tirkarthi/cpython/commit/f190d45faa2083e96e87dc7654bc11bde8bd1e64
f190d45https://github.com/tirkarthi/cpython/commit/f190d45faa2083e96e87dc7654bc11bde8bd1e64
pythonGH-13921https://github.com/python/cpython/pull/13921
https://bugs.python.org/issue12144https://bugs.python.org/issue12144
@asvetlovhttps://github.com/asvetlov
bb41147https://github.com/tirkarthi/cpython/commit/bb41147eab15a2958f4ad38261e5bf608f6ace1b
asvetlovhttps://github.com/asvetlov
Sep 13, 2019 https://github.com/python/cpython/pull/13921#ref-commit-e7b7edf
https://github.com/tirkarthi
https://github.com/asvetlov
[3.7]https://github.com/python/cpython/commit/e7b7edf5ebaed14dc68c841a8a98260f1330ef9a
bpo-12144https://bugs.python.org/issue?@action=redirect&bpo=12144
: Handle cookies with expires attribute in CookieJar.…https://github.com/python/cpython/commit/e7b7edf5ebaed14dc68c841a8a98260f1330ef9a
e7b7edfhttps://github.com/python/cpython/commit/e7b7edf5ebaed14dc68c841a8a98260f1330ef9a
GH-13921https://github.com/python/cpython/pull/13921
GH-16092https://github.com/python/cpython/pull/16092
bpo-12144https://bugs.python.org/issue?@action=redirect&bpo=12144
GH-13921https://github.com/python/cpython/pull/13921
https://bugs.python.org/issue12144https://bugs.python.org/issue12144
@asvetlovhttps://github.com/asvetlov
bb41147https://github.com/python/cpython/commit/bb41147eab15a2958f4ad38261e5bf608f6ace1b
bpo-12144https://bugs.python.org/issue?@action=redirect&bpo=12144
GH-13921https://github.com/python/cpython/pull/13921
https://bugs.python.org/issue12144https://bugs.python.org/issue12144
@asvetlovhttps://github.com/asvetlov
bb41147https://github.com/python/cpython/commit/bb41147eab15a2958f4ad38261e5bf608f6ace1b
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13921
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/python/cpython/pull/13921/files/d5f8cd4410985fe82ca3eba1e9aef0ac02741d01
https://github.com/mangrisano
mangrisano https://github.com/mangrisano
https://github.com/python/cpython/pull/13921/files/d5f8cd4410985fe82ca3eba1e9aef0ac02741d01
https://github.com/miss-islington
miss-islington https://github.com/miss-islington
Please reload this pagehttps://github.com/python/cpython/pull/13921
https://github.com/tirkarthi
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/asvetlov
https://github.com/mangrisano
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.