René's URL Explorer Experiment


Title: gh-136003: Skip non-daemon threads when exceptions occur during finalization by ZeroIntensity · Pull Request #139129 · python/cpython · GitHub

Open Graph Title: gh-136003: Skip non-daemon threads when exceptions occur during finalization by ZeroIntensity · Pull Request #139129 · python/cpython

X Title: gh-136003: Skip non-daemon threads when exceptions occur during finalization by ZeroIntensity · Pull Request #139129 · python/cpython

Description: During finalization, we need to mark all non-daemon threads as daemon to quickly shut down threads when sending CTRL^C to the process. This was a minor regression from GH-136004. Issue: Some pre-...

Open Graph Description: During finalization, we need to mark all non-daemon threads as daemon to quickly shut down threads when sending CTRL^C to the process. This was a minor regression from GH-136004. Issue: Some pre-...

X Description: During finalization, we need to mark all non-daemon threads as daemon to quickly shut down threads when sending CTRL^C to the process. This was a minor regression from GH-136004. Issue: Some pre-...

Opengraph URL: https://github.com/python/cpython/pull/139129

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d538eba3-c58f-35bc-2223-2f881e6b95f6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB9BA:22D7C9:D246:11F5B:696A9850
html-safe-nonce9e6c72aede6b8e575494886e6b5e25fd18ad4db91cf7db3dc7f6662cb330dfda
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUJBOjIyRDdDOTpEMjQ2OjExRjVCOjY5NkE5ODUwIiwidmlzaXRvcl9pZCI6IjI4MTYyOTg4NTE5MDk2NzA5OTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac005444dbd8292db54c2b335343ebca88e3dadfe0ebe397b43b31ffac97dc4437
hovercard-subject-tagpull_request:2840488333
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/139129/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b300934cf9b0cad3bef9dba1aec5b6a7ecfd8f451a58f0be77b0bc6b75e66873/python/cpython/pull/139129
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b300934cf9b0cad3bef9dba1aec5b6a7ecfd8f451a58f0be77b0bc6b75e66873/python/cpython/pull/139129
og:image:altDuring finalization, we need to mark all non-daemon threads as daemon to quickly shut down threads when sending CTRL^C to the process. This was a minor regression from GH-136004. Issue: Some pre-...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZeroIntensity
hostnamegithub.com
expected-hostnamegithub.com
Nonec0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release99aab454e5ddc8df30805fb76c114c3008a15842
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/139129#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139129
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139129
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/139129
Reloadhttps://github.com/python/cpython/pull/139129
Reloadhttps://github.com/python/cpython/pull/139129
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/139129
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/139129
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/139129#issue-comment-box
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
ZeroIntensity:fix-threading-interrupthttps://github.com/ZeroIntensity/cpython/tree/fix-threading-interrupt
gh-136003: Skip non-daemon threads when exceptions occur during finalization https://github.com/python/cpython/pull/139129#top
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
ZeroIntensity:fix-threading-interrupthttps://github.com/ZeroIntensity/cpython/tree/fix-threading-interrupt
Conversation 1 https://github.com/python/cpython/pull/139129
Commits 4 https://github.com/python/cpython/pull/139129/commits
Checks 45 https://github.com/python/cpython/pull/139129/checks
Files changed 3 https://github.com/python/cpython/pull/139129/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 18, 2025https://github.com/python/cpython/pull/139129#issue-3430621413
Please reload this pagehttps://github.com/python/cpython/pull/139129
GH-136004https://github.com/python/cpython/pull/136004
Some pre-finalization callbacks can create other callbacks #136003https://github.com/python/cpython/issues/136003
Please reload this pagehttps://github.com/python/cpython/pull/139129
ZeroIntensityhttps://github.com/ZeroIntensity
September 18, 2025 10:07https://github.com/python/cpython/pull/139129#commits-pushed-8f9e675
https://github.com/ZeroIntensity
Ignore non-daemon threads when KeyboardInterrupt is sent during final…https://github.com/python/cpython/pull/139129/commits/8f9e6759203f4a32b8a813e697d9d06c9707dfd7
8f9e675https://github.com/python/cpython/pull/139129/commits/8f9e6759203f4a32b8a813e697d9d06c9707dfd7
https://github.com/ZeroIntensity
Add a test case.https://github.com/python/cpython/pull/139129/commits/2f5073ce77ec401eb5f7fedf5dc315d9e46ee0b1
2f5073chttps://github.com/python/cpython/pull/139129/commits/2f5073ce77ec401eb5f7fedf5dc315d9e46ee0b1
https://github.com/ZeroIntensity
Remove flaky part of test.https://github.com/python/cpython/pull/139129/commits/34b8b7ebd83de1c9dd583f47d8b24d0b418e628d
34b8b7ehttps://github.com/python/cpython/pull/139129/commits/34b8b7ebd83de1c9dd583f47d8b24d0b418e628d
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
code ownerhttps://github.com/python/cpython/blob/b0a8073f1b31aa0f49dca9ec49a78e5e9060c7d2/.github/CODEOWNERS#L299
September 18, 2025 14:23https://github.com/python/cpython/pull/139129#event-19777073719
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
sprint https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Asprint
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19777073861
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprint 2024https://github.com/orgs/python/projects/32
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19777074780
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprint 2024https://github.com/orgs/python/projects/32
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19777075681
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19777075024
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 18, 2025 https://github.com/python/cpython/pull/139129#ref-issue-3180667722
Some pre-finalization callbacks can create other callbacks #136003 https://github.com/python/cpython/issues/136003
https://github.com/ZeroIntensity
SKip the test on Windows.https://github.com/python/cpython/pull/139129/commits/3455f0535089a8f7c5b06132e1cedcaa90172748
3455f05https://github.com/python/cpython/pull/139129/commits/3455f0535089a8f7c5b06132e1cedcaa90172748
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Sep 18, 2025 https://github.com/python/cpython/pull/139129#pullrequestreview-3241166578
View reviewed changes https://github.com/python/cpython/pull/139129/files/3455f0535089a8f7c5b06132e1cedcaa90172748
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
https://github.com/python/cpython/pull/139129#pullrequestreview-3241166578
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/139129
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19781566546
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprint 2024https://github.com/orgs/python/projects/32
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19781567098
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19781566756
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
3eec897https://github.com/python/cpython/commit/3eec8977528dbbd22f9c0873930507fd97053843
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19784593170
Please reload this pagehttps://github.com/python/cpython/pull/139129
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
September 18, 2025 20:04https://github.com/python/cpython/pull/139129#event-19784593704
https://github.com/apps/github-project-automation
github-project-automationhttps://github.com/apps/github-project-automation
Sprint 2024https://github.com/orgs/python/projects/32
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19784594361
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 18, 2025https://github.com/python/cpython/pull/139129#event-19784594078
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Oct 7, 2025 https://github.com/python/cpython/pull/139129#ref-issue-3490798392
Thread.join() cannot be interrupted by Ctrl+C on Windows #139689 https://github.com/python/cpython/issues/139689
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F139129
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/python/cpython/pull/139129/files/3455f0535089a8f7c5b06132e1cedcaa90172748
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
sprint https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Asprint
Sprint 2024 https://github.com/orgs/python/projects/32
Please reload this pagehttps://github.com/python/cpython/pull/139129
https://github.com/ZeroIntensity
https://github.com/ericsnowcurrently
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.