René's URL Explorer Experiment


Title: [3.14] gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations (GH-138953) by JelleZijlstra · Pull Request #138989 · python/cpython · GitHub

Open Graph Title: [3.14] gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations (GH-138953) by JelleZijlstra · Pull Request #138989 · python/cpython

X Title: [3.14] gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations (GH-138953) by JelleZijlstra · Pull Request #138989 · python/cpython

Description: This issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...

Open Graph Description: This issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...

X Description: This issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...

Opengraph URL: https://github.com/python/cpython/pull/138989

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f8a73ffb-087f-3362-d7ba-d7b6acef079d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE52C:2A6D10:14C96C8:1AD3CE9:696B1DB7
html-safe-nonce93a8fd860e821910d9af214e8454e31c56227b53e009d074ff11eaf1055e8af0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTJDOjJBNkQxMDoxNEM5NkM4OjFBRDNDRTk6Njk2QjFEQjciLCJ2aXNpdG9yX2lkIjoiNDMwMzM3NTc5MTQ2NzIwODExOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5a8c8377593bd48c9c91aded88d5c40928fb897638c85126ea905def38fe4fee
hovercard-subject-tagpull_request:2833322782
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/138989/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ca533481c70af21b79c68a345bc0f68ddb1366823f195d2cab14477c1f415a8a/python/cpython/pull/138989
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ca533481c70af21b79c68a345bc0f68ddb1366823f195d2cab14477c1f415a8a/python/cpython/pull/138989
og:image:altThis issue appears specifically for TypedDicts because the TypedDict constructor code converts string annotations to ForwardRef objects, and those are not evaluated properly by the get_type_hints()...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138989#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138989
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138989
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138989
Reloadhttps://github.com/python/cpython/pull/138989
Reloadhttps://github.com/python/cpython/pull/138989
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138989
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/138989
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/138989#issue-comment-box
hugovkhttps://github.com/hugovk
python:3.14https://github.com/python/cpython/tree/3.14
JelleZijlstra:backport-6d6aba2-3.14https://github.com/JelleZijlstra/cpython/tree/backport-6d6aba2-3.14
[3.14] gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations (GH-138953) https://github.com/python/cpython/pull/138989#top
hugovkhttps://github.com/hugovk
python:3.14https://github.com/python/cpython/tree/3.14
JelleZijlstra:backport-6d6aba2-3.14https://github.com/JelleZijlstra/cpython/tree/backport-6d6aba2-3.14
Conversation 0 https://github.com/python/cpython/pull/138989
Commits 1 https://github.com/python/cpython/pull/138989/commits
Checks 49 https://github.com/python/cpython/pull/138989/checks
Files changed 3 https://github.com/python/cpython/pull/138989/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Sep 16, 2025https://github.com/python/cpython/pull/138989#issue-3422567706
Please reload this pagehttps://github.com/python/cpython/pull/138989
GH-137227https://github.com/python/cpython/pull/137227
GH-138949https://github.com/python/cpython/issues/138949
6d6aba2https://github.com/python/cpython/commit/6d6aba252301cdf9d5ae3189629e1e43101dd58f
ForwardRef.evaluate() mishandles type_params #137226https://github.com/python/cpython/issues/137226
Please reload this pagehttps://github.com/python/cpython/pull/138989
https://github.com/JelleZijlstra
[3.14]https://github.com/python/cpython/pull/138989/commits/25ab548444a8b152247e6152f968b1cc70556d1d
pythongh-137226https://github.com/python/cpython/issues/137226
: Fix get_type_hints() on generic TypedDict wit…https://github.com/python/cpython/pull/138989/commits/25ab548444a8b152247e6152f968b1cc70556d1d
25ab548https://github.com/python/cpython/pull/138989/commits/25ab548444a8b152247e6152f968b1cc70556d1d
pythonGH-138953https://github.com/python/cpython/pull/138953
pythonGH-137227https://github.com/python/cpython/pull/137227
pythonGH-138949https://github.com/python/cpython/issues/138949
6d6aba2https://github.com/JelleZijlstra/cpython/commit/6d6aba252301cdf9d5ae3189629e1e43101dd58f
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
AlexWaygoodhttps://github.com/AlexWaygood
code ownerhttps://github.com/python/cpython/blob/284ab76d4ecf32c486f99237e0024ff3a57fd9bf/.github/CODEOWNERS#L251
September 16, 2025 14:34https://github.com/python/cpython/pull/138989#event-19728498982
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 16, 2025https://github.com/python/cpython/pull/138989#event-19728500304
ForwardRef.evaluate() mishandles type_params #137226 https://github.com/python/cpython/issues/137226
gh-137226: Fix get_type_hints() on generic TypedDict with stringified annotations #138953 https://github.com/python/cpython/pull/138953
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
Sep 16, 2025 https://github.com/python/cpython/pull/138989#pullrequestreview-3230554317
View reviewed changes https://github.com/python/cpython/pull/138989/files/25ab548444a8b152247e6152f968b1cc70556d1d
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 16, 2025https://github.com/python/cpython/pull/138989#event-19729765307
https://github.com/AlexWaygood
AlexWaygoodhttps://github.com/AlexWaygood
hugovkhttps://github.com/hugovk
Sep 16, 2025https://github.com/python/cpython/pull/138989#event-19729772489
https://github.com/hugovk
hugovkhttps://github.com/hugovk
6038447https://github.com/python/cpython/commit/6038447d99663b0434a4f2c545c0543e9a81fdc3
Sep 17, 2025https://github.com/python/cpython/pull/138989#event-19745622648
Please reload this pagehttps://github.com/python/cpython/pull/138989
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 17, 2025https://github.com/python/cpython/pull/138989#event-19745623726
https://github.com/drhagen
drhagenhttps://github.com/drhagen
Nov 24, 2025 https://github.com/python/cpython/pull/138989#ref-pullrequest-3643848423
Remove internal deprecated keyword argument due to python 3.14 change pydantic/pydantic#12552 https://github.com/pydantic/pydantic/pull/12552
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138989
https://github.com/AlexWaygood
AlexWaygood https://github.com/AlexWaygood
https://github.com/python/cpython/pull/138989/files/25ab548444a8b152247e6152f968b1cc70556d1d
https://github.com/hugovk
hugovk https://github.com/hugovk
Please reload this pagehttps://github.com/python/cpython/pull/138989
https://github.com/JelleZijlstra
https://github.com/AlexWaygood
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.