Title: gh-129813: Use `PyBytesWriter` in `_json:_match_number_unicode` by maurycy · Pull Request #138957 · python/cpython · GitHub
Open Graph Title: gh-129813: Use `PyBytesWriter` in `_json:_match_number_unicode` by maurycy · Pull Request #138957 · python/cpython
X Title: gh-129813: Use `PyBytesWriter` in `_json:_match_number_unicode` by maurycy · Pull Request #138957 · python/cpython
Description: The change is very similar to #138956 Initially, I thought that there's a speed up, but I mixed the JSON files, and it's the reverse: Benchmark json-main json-pybytes json_loads_1000_ints 41.4 us 47.3 us: 1.14x slower json_loads_1000_floats 77.1 us 81.9 us: 1.06x slower Geometric mean (ref) 1.10x slower which makes perfect sense given the conversion: https://github.com/python/cpython/pull/138957/files#diff-efe183ae0b85e5b8d9bbbc588452dd4de80b39fd5c5174ee499ba554217a39edR1110 I mixed up the JSONs; my bad. I'm surprised with the speed up: Benchmark The script: import pyperf import json runner = pyperf.Runner() num_elements = 1000 int_data = json.dumps(list(range(num_elements))) runner.bench_func(f'json_loads_{num_elements}_ints', json.loads, int_data) float_data = json.dumps([float(i) for i in range(num_elements)]) runner.bench_func(f'json_loads_{num_elements}_floats', json.loads, float_data) Where main is 4e00e25 The environment: % ./python -c "import sysconfig; print(sysconfig.get_config_var('CONFIG_ARGS'))" '--enable-lto' '--with-optimizations' sudo ./python -m pyperf system tune ensured. Issue: gh-129813
Open Graph Description: The change is very similar to #138956 Initially, I thought that there's a speed up, but I mixed the JSON files, and it's the reverse: Benchmark json-main json-pybytes json_loads_1000...
X Description: The change is very similar to #138956 Initially, I thought that there's a speed up, but I mixed the JSON files, and it's the reverse: Benchmark json-main json-pybytes json_lo...
Opengraph URL: https://github.com/python/cpython/pull/138957
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d9cc8225-27b9-f103-db2d-eaccd19f9571 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8A2:1AE20C:3A97ED4:4A341BB:6B01F489 |
| html-safe-nonce | 9761db5a25bfbf17839dd6a92a89dbcaa0fc115e65e5ae301040078aba5c84f1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEEyOjFBRTIwQzozQTk3RUQ0OjRBMzQxQkI6NkIwMUY0ODkiLCJ2aXNpdG9yX2lkIjoiNzQ0ODIyMzEyMTMzNDcyNzgxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 597e0d9383b444b6dc5b8eb52e450e57d2640511fef9968cb8f6cf995c90e50d |
| hovercard-subject-tag | pull_request:2831019195 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/138957/files |
| twitter:image | https://avatars.githubusercontent.com/u/5383?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5383?s=400&v=4 |
| og:image:alt | The change is very similar to #138956 Initially, I thought that there's a speed up, but I mixed the JSON files, and it's the reverse: Benchmark json-main json-pybytes json_loads_1000... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width