René's URL Explorer Experiment


Title: bpo-37193: remove thread objects which finished process its request by maru-n · Pull Request #13893 · python/cpython · GitHub

Open Graph Title: bpo-37193: remove thread objects which finished process its request by maru-n · Pull Request #13893 · python/cpython

X Title: bpo-37193: remove thread objects which finished process its request by maru-n · Pull Request #13893 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: In ThreadingMixIn class, it hold child processes on list (self._threads variable) to join it when server is closed. This list also contain thread objects which finished its process. And it will be ...

X Description: In ThreadingMixIn class, it hold child processes on list (self._threads variable) to join it when server is closed. This list also contain thread objects which finished its process. And it will be ...

Opengraph URL: https://github.com/python/cpython/pull/13893

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:2b4610ca-5e81-1a6f-5d16-02144c8b121d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB67C:1D60FB:A3B92:D42FF:6A52DD3D
html-safe-nonce5b1189b9a89e403557543c0c814ce449d355e3b648e53a44e274a96fbc6fc894
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjdDOjFENjBGQjpBM0I5MjpENDJGRjo2QTUyREQzRCIsInZpc2l0b3JfaWQiOiI4MTgxMDQxNjI5NzU2NTc5MTMzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacae749d55701928eecb0d478a8ba00f01625daa852f5650cbff94e6c01a1b0491
hovercard-subject-tagpull_request:286179403
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13893/commits
twitter:imagehttps://opengraph.githubassets.com/7a877a808a06f7e97fde21619d226d722c4bf7aa64348355c832510e31fa82a4/python/cpython/pull/13893
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7a877a808a06f7e97fde21619d226d722c4bf7aa64348355c832510e31fa82a4/python/cpython/pull/13893
og:image:altIn ThreadingMixIn class, it hold child processes on list (self._threads variable) to join it when server is closed. This list also contain thread objects which finished its process. And it will be ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemaru-n
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13893/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13893%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13893%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13893/commits
Reloadhttps://github.com/python/cpython/pull/13893/commits
Reloadhttps://github.com/python/cpython/pull/13893/commits
Please reload this pagehttps://github.com/python/cpython/pull/13893/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13893/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
jaracohttps://github.com/jaraco
python:masterhttps://github.com/python/cpython/tree/master
maru-n:fix-issue-37193https://github.com/maru-n/cpython/tree/fix-issue-37193
Conversationhttps://github.com/python/cpython/pull/13893
Commits18 (18)https://github.com/python/cpython/pull/13893/commits
Checkshttps://github.com/python/cpython/pull/13893/checks
Files changedhttps://github.com/python/cpython/pull/13893/files
bpo-37193: remove thread objects which finished process its requesthttps://github.com/python/cpython/pull/13893/commits#top
jaracohttps://github.com/jaraco
python:masterhttps://github.com/python/cpython/tree/master
maru-n:fix-issue-37193https://github.com/maru-n/cpython/tree/fix-issue-37193
bpo-37193: remove the thread which finished process request from threads listhttps://github.com/python/cpython/pull/13893/commits/b437e8ba4917c77b33e14ca732cd9ce3988d611f
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
b437e8bhttps://github.com/python/cpython/pull/13893/commits/b437e8ba4917c77b33e14ca732cd9ce3988d611f
https://github.com/python/cpython/tree/b437e8ba4917c77b33e14ca732cd9ce3988d611f
rename variable t to thread.https://github.com/python/cpython/pull/13893/commits/94a7bdf20084e13ae84c664d196cfecb669c3f60
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
94a7bdfhttps://github.com/python/cpython/pull/13893/commits/94a7bdf20084e13ae84c664d196cfecb669c3f60
https://github.com/python/cpython/tree/94a7bdf20084e13ae84c664d196cfecb669c3f60
don't remove thread from list if it is daemon.https://github.com/python/cpython/pull/13893/commits/16142cf37845483ee2f1ae14e4735a95392c11b6
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
16142cfhttps://github.com/python/cpython/pull/13893/commits/16142cf37845483ee2f1ae14e4735a95392c11b6
https://github.com/python/cpython/tree/16142cf37845483ee2f1ae14e4735a95392c11b6
use lock to protect self._threads.https://github.com/python/cpython/pull/13893/commits/e6fa24e3db36ef69559e3583b0ea064137befd5d
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
e6fa24ehttps://github.com/python/cpython/pull/13893/commits/e6fa24e3db36ef69559e3583b0ea064137befd5d
https://github.com/python/cpython/tree/e6fa24e3db36ef69559e3583b0ea064137befd5d
use finally block in case of exception from shutdown_request().https://github.com/python/cpython/pull/13893/commits/a70251792fe457af981928076267705ab2484deb
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
a702517https://github.com/python/cpython/pull/13893/commits/a70251792fe457af981928076267705ab2484deb
https://github.com/python/cpython/tree/a70251792fe457af981928076267705ab2484deb
check "not thread.daemon" before lock to avoid holding the lock if it's unnecessary.https://github.com/python/cpython/pull/13893/commits/9daa4178dbe0d7bc7628870897a9f684af62b2db
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
9daa417https://github.com/python/cpython/pull/13893/commits/9daa4178dbe0d7bc7628870897a9f684af62b2db
https://github.com/python/cpython/tree/9daa4178dbe0d7bc7628870897a9f684af62b2db
fix the place of _threads_lock.https://github.com/python/cpython/pull/13893/commits/287cc8cbd18a532dc22b1cc2a35da616ddd33610
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
287cc8chttps://github.com/python/cpython/pull/13893/commits/287cc8cbd18a532dc22b1cc2a35da616ddd33610
https://github.com/python/cpython/tree/287cc8cbd18a532dc22b1cc2a35da616ddd33610
separate code to remove a current thread into a function.https://github.com/python/cpython/pull/13893/commits/68abb0de2e8db7212f21c5a0da78db26dc2ab02c
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
68abb0dhttps://github.com/python/cpython/pull/13893/commits/68abb0de2e8db7212f21c5a0da78db26dc2ab02c
https://github.com/python/cpython/tree/68abb0de2e8db7212f21c5a0da78db26dc2ab02c
check ValueError when removing thread.https://github.com/python/cpython/pull/13893/commits/c7286d1cccad60cafe651df48a95e2fb99680a9a
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
c7286d1https://github.com/python/cpython/pull/13893/commits/c7286d1cccad60cafe651df48a95e2fb99680a9a
https://github.com/python/cpython/tree/c7286d1cccad60cafe651df48a95e2fb99680a9a
fix wrong code which all instance shared same lock.https://github.com/python/cpython/pull/13893/commits/6ac217cb1e7fdb2d9f8749278da4d4bd748f4996
https://github.com/maru-n
maru-nhttps://github.com/python/cpython/commits?author=maru-n
6ac217chttps://github.com/python/cpython/pull/13893/commits/6ac217cb1e7fdb2d9f8749278da4d4bd748f4996
https://github.com/python/cpython/tree/6ac217cb1e7fdb2d9f8749278da4d4bd748f4996
Extract thread management into a _Threads class to encapsulate atomic operations and separate concerns.https://github.com/python/cpython/pull/13893/commits/5ca61a26eba867f3a3b841749e3cb9e388edebd2
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
5ca61a2https://github.com/python/cpython/pull/13893/commits/5ca61a26eba867f3a3b841749e3cb9e388edebd2
https://github.com/python/cpython/tree/5ca61a26eba867f3a3b841749e3cb9e388edebd2
Replace multiple references of 'block_on_close' with one, avoiding the possibility that 'block_on_close' could change during the course of processing requests. Now, there's exactly one _threads obj…https://github.com/python/cpython/pull/13893/commits/fcd11664ee313ce6b82c7c2e428680e0392bc7b5
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
fcd1166https://github.com/python/cpython/pull/13893/commits/fcd11664ee313ce6b82c7c2e428680e0392bc7b5
https://github.com/python/cpython/tree/fcd11664ee313ce6b82c7c2e428680e0392bc7b5
Add docstrings to private classes.https://github.com/python/cpython/pull/13893/commits/cc6e532f8d317d53178e2b86cef74ce457c9c268
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
cc6e532https://github.com/python/cpython/pull/13893/commits/cc6e532f8d317d53178e2b86cef74ce457c9c268
https://github.com/python/cpython/tree/cc6e532f8d317d53178e2b86cef74ce457c9c268
Add test to ensure that a ThreadingTCPServer can be closed without serving any requests.https://github.com/python/cpython/pull/13893/commits/b107b913c17f8eab25be0c1c24edfd25bfbed6a9
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
b107b91https://github.com/python/cpython/pull/13893/commits/b107b913c17f8eab25be0c1c24edfd25bfbed6a9
https://github.com/python/cpython/tree/b107b913c17f8eab25be0c1c24edfd25bfbed6a9
Use _NoThreads as the default value. Fixes AttributeError when server is closed without serving any requests.https://github.com/python/cpython/pull/13893/commits/a1aff7673d947fe63e2f303b1766686602c9e4dc
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
a1aff76https://github.com/python/cpython/pull/13893/commits/a1aff7673d947fe63e2f303b1766686602c9e4dc
https://github.com/python/cpython/tree/a1aff7673d947fe63e2f303b1766686602c9e4dc
Add blurbhttps://github.com/python/cpython/pull/13893/commits/d99817e9ec1428c1ce237d5bc01c6234486ade7c
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
d99817ehttps://github.com/python/cpython/pull/13893/commits/d99817e9ec1428c1ce237d5bc01c6234486ade7c
https://github.com/python/cpython/tree/d99817e9ec1428c1ce237d5bc01c6234486ade7c
Add test capturing failure.https://github.com/python/cpython/pull/13893/commits/7d1f367941c411ce01c4bf5ec5b020680e7c5313
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
7d1f367https://github.com/python/cpython/pull/13893/commits/7d1f367941c411ce01c4bf5ec5b020680e7c5313
https://github.com/python/cpython/tree/7d1f367941c411ce01c4bf5ec5b020680e7c5313
Merge branch 'bpo-37193/test' into fix-issue-37193https://github.com/python/cpython/pull/13893/commits/dadeb0c71460931ce8c525b77e059587472b3021
https://github.com/jaraco
jaracohttps://github.com/python/cpython/commits?author=jaraco
dadeb0chttps://github.com/python/cpython/pull/13893/commits/dadeb0c71460931ce8c525b77e059587472b3021
https://github.com/python/cpython/tree/dadeb0c71460931ce8c525b77e059587472b3021
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.