René's URL Explorer Experiment


Title: [3.8] bpo-37191: Avoid declaration-after-statement in header included from Python.h by encukou · Pull Request #13887 · python/cpython · GitHub

Open Graph Title: [3.8] bpo-37191: Avoid declaration-after-statement in header included from Python.h by encukou · Pull Request #13887 · python/cpython

X Title: [3.8] bpo-37191: Avoid declaration-after-statement in header included from Python.h by encukou · Pull Request #13887 · python/cpython

Description: When compiled with GCC's -Werror=declaration-after-statement ("intermingled declarations" in PEP7), cpython/abstract.h (included from ) errors on vectorcall helper functions added in 3.8.0 Beta 1. It's well within our rights to ignore this: since 3.6 we require intermingled declarations. But, when re-compiling Fedora we've seen several projects fail with this warning (so far: pygobject3, python-dbus, xen; more will likely come). @ambv: Dear Release Manager, should we patch 3.8 to avoid this? The patch is simple, and it would give projects that we(re) dutifully tested with the Alphas one more release to adapt. I don't think it's worth changing for 3.9 (but if we do we should test it). https://bugs.python.org/issue37191

Open Graph Description: When compiled with GCC's -Werror=declaration-after-statement ("intermingled declarations" in PEP7), cpython/abstract.h (included from <Python.h>) errors on vectorcall helper fun...

X Description: When compiled with GCC&#39;s -Werror=declaration-after-statement (&quot;intermingled declarations&quot; in PEP7), cpython/abstract.h (included from &lt;Python.h&gt;) errors on v...

Opengraph URL: https://github.com/python/cpython/pull/13887

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6618893f-89bd-ba3f-28e1-b31cd7aca126
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB60:289E91:121FE5A:1A46924:6A54BEAF
html-safe-nonce5d74f05197b88078eb9f3ae69d35338e9e1c75322c849d062e257597a9d32c0b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjYwOjI4OUU5MToxMjFGRTVBOjFBNDY5MjQ6NkE1NEJFQUYiLCJ2aXNpdG9yX2lkIjoiNTEzMTAyODcxOTcwNDc4NDU1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac93f33341f9f37a04e5cb79245e16e2216c68550e39d9247092f25ad3eabf11ef
hovercard-subject-tagpull_request:286109841
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13887/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altWhen compiled with GCC's -Werror=declaration-after-statement ("intermingled declarations" in PEP7), cpython/abstract.h (included from <Python.h>) errors on vectorcall helper fun...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release69f9664dd5e7a82ba8ab1b4cb7f5a2f09333ab38
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13887/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13887%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13887%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13887/files
Reloadhttps://github.com/python/cpython/pull/13887/files
Reloadhttps://github.com/python/cpython/pull/13887/files
Please reload this pagehttps://github.com/python/cpython/pull/13887/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13887/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:3.8https://github.com/python/cpython/tree/3.8
encukou:intermingled-declarations-38https://github.com/encukou/cpython/tree/intermingled-declarations-38
Conversation 3 https://github.com/python/cpython/pull/13887
Commits 1 https://github.com/python/cpython/pull/13887/commits
Checks 0 https://github.com/python/cpython/pull/13887/checks
Files changed https://github.com/python/cpython/pull/13887/files
Please reload this pagehttps://github.com/python/cpython/pull/13887/files
[3.8] bpo-37191: Avoid declaration-after-statement in header included from Python.h https://github.com/python/cpython/pull/13887/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/13887/files
7d21f49 Avoid declaration-after-statement in header included from Python.h encukou Jun 7, 2019 https://github.com/python/cpython/pull/13887/commits/7d21f49e2a33466a88ecff18c9706f9ce1e5a9e6
Clear filters https://github.com/python/cpython/pull/13887/files
Please reload this pagehttps://github.com/python/cpython/pull/13887/files
Please reload this pagehttps://github.com/python/cpython/pull/13887/files
abstract.h https://github.com/python/cpython/pull/13887/files#diff-cf6158859b32f9548b010233c5c8cd5ef7631a8080a45f8f72f09c61aa898483
2019-06-07-10-47-37.bpo-37191.iGL1_K.rst https://github.com/python/cpython/pull/13887/files#diff-5a608e1decdd14d6cb8035baa8fc38bc6bf4493db80071a454da67bef22209e3
Include/cpython/abstract.hhttps://github.com/python/cpython/pull/13887/files#diff-cf6158859b32f9548b010233c5c8cd5ef7631a8080a45f8f72f09c61aa898483
View file https://github.com/encukou/cpython/blob/7d21f49e2a33466a88ecff18c9706f9ce1e5a9e6/Include/cpython/abstract.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13887/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13887/files#diff-cf6158859b32f9548b010233c5c8cd5ef7631a8080a45f8f72f09c61aa898483
https://github.com/python/cpython/pull/13887/files#diff-cf6158859b32f9548b010233c5c8cd5ef7631a8080a45f8f72f09c61aa898483
https://github.com/python/cpython/pull/13887/files#diff-cf6158859b32f9548b010233c5c8cd5ef7631a8080a45f8f72f09c61aa898483
Misc/NEWS.d/next/C API/2019-06-07-10-47-37.bpo-37191.iGL1_K.rsthttps://github.com/python/cpython/pull/13887/files#diff-5a608e1decdd14d6cb8035baa8fc38bc6bf4493db80071a454da67bef22209e3
View file https://github.com/encukou/cpython/blob/7d21f49e2a33466a88ecff18c9706f9ce1e5a9e6/Misc/NEWS.d/next/C%20API/2019-06-07-10-47-37.bpo-37191.iGL1_K.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13887/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.