René's URL Explorer Experiment


Title: gh-138804: Check type in `shlex.quote` by wiomoc · Pull Request #138809 · python/cpython · GitHub

Open Graph Title: gh-138804: Check type in `shlex.quote` by wiomoc · Pull Request #138809 · python/cpython

X Title: gh-138804: Check type in `shlex.quote` by wiomoc · Pull Request #138809 · python/cpython

Description: Issue: Exception thrown by shlex.quote changed in 3.14 and is not documented #138804

Open Graph Description: Issue: Exception thrown by shlex.quote changed in 3.14 and is not documented #138804

X Description: Issue: Exception thrown by shlex.quote changed in 3.14 and is not documented #138804

Opengraph URL: https://github.com/python/cpython/pull/138809

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b9eeb3e0-80df-4668-f436-45298d953cf3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA29A:30C275:156B71:1E339A:696A04D7
html-safe-nonce91c669cd7cc4e4c0bf41d56edd69ed85d0957ae387ac51402a1734f22c22b0fb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjlBOjMwQzI3NToxNTZCNzE6MUUzMzlBOjY5NkEwNEQ3IiwidmlzaXRvcl9pZCI6IjY1MDQ0Njg0OTExMTEzNjc4OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1af6b76c0d04727831d740f6438ebf91bc11172ced0a445a4651559ab8350851
hovercard-subject-tagpull_request:2820738834
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/138809/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/30f391c8c3371e92a94c584cfddc26a33bd56fbcb82a78d017191e44d4776e7e/python/cpython/pull/138809
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/30f391c8c3371e92a94c584cfddc26a33bd56fbcb82a78d017191e44d4776e7e/python/cpython/pull/138809
og:image:altIssue: Exception thrown by shlex.quote changed in 3.14 and is not documented #138804
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewiomoc
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138809#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138809
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138809
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138809
Reloadhttps://github.com/python/cpython/pull/138809
Reloadhttps://github.com/python/cpython/pull/138809
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138809
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/138809
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/138809#issue-comment-box
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
wiomoc:gh-138804-check-shlex-quote-strhttps://github.com/wiomoc/cpython/tree/gh-138804-check-shlex-quote-str
gh-138804: Check type in shlex.quote https://github.com/python/cpython/pull/138809#top
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
wiomoc:gh-138804-check-shlex-quote-strhttps://github.com/wiomoc/cpython/tree/gh-138804-check-shlex-quote-str
Conversation 12 https://github.com/python/cpython/pull/138809
Commits 3 https://github.com/python/cpython/pull/138809/commits
Checks 45 https://github.com/python/cpython/pull/138809/checks
Files changed https://github.com/python/cpython/pull/138809/files
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/wiomoc
wiomochttps://github.com/wiomoc
Sep 11, 2025https://github.com/python/cpython/pull/138809#issue-3408273164
Please reload this pagehttps://github.com/python/cpython/pull/138809
Exception thrown by shlex.quote changed in 3.14 and is not documented #138804https://github.com/python/cpython/issues/138804
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/wiomoc
pythongh-138804https://github.com/python/cpython/issues/138804
: Check type inhttps://github.com/python/cpython/pull/138809/commits/89e0164125c67bc9be56f7c3d007a960f17c9e24
shlex.quotehttps://github.com/python/cpython/pull/138809/commits/89e0164125c67bc9be56f7c3d007a960f17c9e24
89e0164https://github.com/python/cpython/pull/138809/commits/89e0164125c67bc9be56f7c3d007a960f17c9e24
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 11, 2025 https://github.com/python/cpython/pull/138809#ref-issue-3407708064
Exception thrown by shlex.quote changed in 3.14 and is not documented #138804 https://github.com/python/cpython/issues/138804
https://github.com/wiomoc
wiomochttps://github.com/wiomoc
September 11, 2025 23:12https://github.com/python/cpython/pull/138809#event-19647804488
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 11, 2025https://github.com/python/cpython/pull/138809#event-19647804980
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025 https://github.com/python/cpython/pull/138809#pullrequestreview-3213969588
View reviewed changes https://github.com/python/cpython/pull/138809/files/89e0164125c67bc9be56f7c3d007a960f17c9e24
Lib/test/test_shlex.pyhttps://github.com/python/cpython/pull/138809/files/89e0164125c67bc9be56f7c3d007a960f17c9e24#diff-3ec788a4560db41a92b71a53c773f177a25a74646f3bec1fd345cf892ce9b9af
Please reload this pagehttps://github.com/python/cpython/pull/138809
Misc/NEWS.d/next/Library/2025-09-12-01-01-05.gh-issue-138804.46ZukT.rsthttps://github.com/python/cpython/pull/138809/files/89e0164125c67bc9be56f7c3d007a960f17c9e24#diff-007a2edd36d32cf797d09a9c78c790dd15c94b8e49dc088915a05a5261efbc4c
Please reload this pagehttps://github.com/python/cpython/pull/138809
Lib/shlex.pyhttps://github.com/python/cpython/pull/138809/files/89e0164125c67bc9be56f7c3d007a960f17c9e24#diff-247132f798c75b6319bb86d174c5c31ffb009764dd1d155ec1008a380cf5fa81
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/wiomoc
post reviewhttps://github.com/python/cpython/pull/138809/commits/bd6a9592dbbabf07fc8a08b340f763a925fd85b4
bd6a959https://github.com/python/cpython/pull/138809/commits/bd6a9592dbbabf07fc8a08b340f763a925fd85b4
https://github.com/wiomoc
wiomochttps://github.com/wiomoc
picnixzhttps://github.com/picnixz
September 11, 2025 23:21https://github.com/python/cpython/pull/138809#event-19647910036
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025 https://github.com/python/cpython/pull/138809#pullrequestreview-3213991649
View reviewed changes https://github.com/python/cpython/pull/138809/files/bd6a9592dbbabf07fc8a08b340f763a925fd85b4
picnixzhttps://github.com/picnixz
https://github.com/python/cpython/pull/138809#pullrequestreview-3213991649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@AA-Turnerhttps://github.com/AA-Turner
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 11, 2025https://github.com/python/cpython/pull/138809#event-19647943217
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Sep 12, 2025https://github.com/python/cpython/pull/138809#event-19653067500
https://github.com/StanFromIreland
StanFromIrelandhttps://github.com/StanFromIreland
Sep 12, 2025 https://github.com/python/cpython/pull/138809#pullrequestreview-3214911529
View reviewed changes https://github.com/python/cpython/pull/138809/files/bd6a9592dbbabf07fc8a08b340f763a925fd85b4
StanFromIrelandhttps://github.com/StanFromIreland
https://github.com/python/cpython/pull/138809#pullrequestreview-3214911529
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138809
Misc/NEWS.d/next/Library/2025-09-12-01-01-05.gh-issue-138804.46ZukT.rsthttps://github.com/python/cpython/pull/138809/files/bd6a9592dbbabf07fc8a08b340f763a925fd85b4#diff-007a2edd36d32cf797d09a9c78c790dd15c94b8e49dc088915a05a5261efbc4c
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 12, 2025 https://github.com/python/cpython/pull/138809#pullrequestreview-3216591494
View reviewed changes https://github.com/python/cpython/pull/138809/files/bd6a9592dbbabf07fc8a08b340f763a925fd85b4
Lib/shlex.pyhttps://github.com/python/cpython/pull/138809/files/bd6a9592dbbabf07fc8a08b340f763a925fd85b4#diff-247132f798c75b6319bb86d174c5c31ffb009764dd1d155ec1008a380cf5fa81
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/wiomoc
wording & move type-check post empty checkhttps://github.com/python/cpython/pull/138809/commits/13d95f08dfe66940c2e7157c1c33802474f3de30
13d95f0https://github.com/python/cpython/pull/138809/commits/13d95f08dfe66940c2e7157c1c33802474f3de30
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 12, 2025 https://github.com/python/cpython/pull/138809#pullrequestreview-3218080404
View reviewed changes https://github.com/python/cpython/pull/138809/files/13d95f08dfe66940c2e7157c1c33802474f3de30
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
220c0a8https://github.com/python/cpython/commit/220c0a8156ad5d33a85fda3cc2b80a3e3d424195
Sep 12, 2025https://github.com/python/cpython/pull/138809#event-19666827391
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 12, 2025https://github.com/python/cpython/pull/138809#event-19666827959
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Sep 12, 2025https://github.com/python/cpython/pull/138809#issuecomment-3286408341
@wiomochttps://github.com/wiomoc
@ZeroIntensityhttps://github.com/ZeroIntensity
Please reload this pagehttps://github.com/python/cpython/pull/138809
miss-islingtonhttps://github.com/miss-islington
Sep 12, 2025 https://github.com/python/cpython/pull/138809#ref-commit-e195c01
https://github.com/wiomoc
https://github.com/miss-islington
pythongh-138804https://github.com/python/cpython/issues/138804
: Check type inhttps://github.com/miss-islington/cpython/commit/e195c012b43a407f45f8ff4750a7ae51b1693aac
shlex.quotehttps://github.com/miss-islington/cpython/commit/e195c012b43a407f45f8ff4750a7ae51b1693aac
(https://github.com/miss-islington/cpython/commit/e195c012b43a407f45f8ff4750a7ae51b1693aac
pythonGH-138809https://github.com/python/cpython/pull/138809
)https://github.com/miss-islington/cpython/commit/e195c012b43a407f45f8ff4750a7ae51b1693aac
e195c01https://github.com/miss-islington/cpython/commit/e195c012b43a407f45f8ff4750a7ae51b1693aac
220c0a8https://github.com/miss-islington/cpython/commit/220c0a8156ad5d33a85fda3cc2b80a3e3d424195
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 12, 2025https://github.com/python/cpython/pull/138809#issuecomment-3286409026
GH-138846https://github.com/python/cpython/pull/138846
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Sep 12, 2025https://github.com/python/cpython/pull/138809#event-19666832291
hugovkhttps://github.com/hugovk
Sep 13, 2025 https://github.com/python/cpython/pull/138809#ref-commit-18dfc1d
https://github.com/miss-islington
https://github.com/wiomoc
[3.14]https://github.com/python/cpython/commit/18dfc1d6c4ba9e1cc8fd5c824095abc9bf6918c6
gh-138804https://github.com/python/cpython/issues/138804
: Check type inhttps://github.com/python/cpython/commit/18dfc1d6c4ba9e1cc8fd5c824095abc9bf6918c6
shlex.quotehttps://github.com/python/cpython/commit/18dfc1d6c4ba9e1cc8fd5c824095abc9bf6918c6
(https://github.com/python/cpython/commit/18dfc1d6c4ba9e1cc8fd5c824095abc9bf6918c6
GH-138809https://github.com/python/cpython/pull/138809
) (https://github.com/python/cpython/commit/18dfc1d6c4ba9e1cc8fd5c824095abc9bf6918c6
#138846https://github.com/python/cpython/pull/138846
)https://github.com/python/cpython/commit/18dfc1d6c4ba9e1cc8fd5c824095abc9bf6918c6
18dfc1dhttps://github.com/python/cpython/commit/18dfc1d6c4ba9e1cc8fd5c824095abc9bf6918c6
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138809
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/138809/files/bd6a9592dbbabf07fc8a08b340f763a925fd85b4
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/138809/files/13d95f08dfe66940c2e7157c1c33802474f3de30
https://github.com/StanFromIreland
StanFromIreland https://github.com/StanFromIreland
https://github.com/python/cpython/pull/138809/files/bd6a9592dbbabf07fc8a08b340f763a925fd85b4
Please reload this pagehttps://github.com/python/cpython/pull/138809
https://github.com/wiomoc
https://github.com/picnixz
https://github.com/ZeroIntensity
https://github.com/StanFromIreland
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.