Title: gh-138791: fix crash when visiting a non-consumed timer handler by picnixz · Pull Request #138789 · python/cpython · GitHub
Open Graph Title: gh-138791: fix crash when visiting a non-consumed timer handler by picnixz · Pull Request #138789 · python/cpython
X Title: gh-138791: fix crash when visiting a non-consumed timer handler by picnixz · Pull Request #138789 · python/cpython
Description: In 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two references that are created; one regular and one that is used as client data and sent to Tcl. When the handler is called, this extra reference is cleared and the Tcl handler is destroyed. However, if the object is destroyed before that, this never happens, so we're having a leak. cc @serhiy-storchaka Issue: gh-116946 Issue: gh-138791
Open Graph Description: In 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two...
X Description: In 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two...
Opengraph URL: https://github.com/python/cpython/pull/138789
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files/:range(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9d9dfe7a-1f92-b1f3-dbd4-c4c22b623b40 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 80A4:86FCD:55A0AA2:71E99FE:6993196F |
| html-safe-nonce | 867c1b7e3d60ba6e13de029401f35134aefa0afb997106d86c93eaf4eac3f4d2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEE0Ojg2RkNEOjU1QTBBQTI6NzFFOTlGRTo2OTkzMTk2RiIsInZpc2l0b3JfaWQiOiIzNTg0Mzk0NzM1NjU2MzExMTUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 55499325ea2fd97fe4996e91d5f6469b07e47bccb7c3c8e386dbc9c66c4e00f4 |
| hovercard-subject-tag | pull_request:2818851437 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/138789/files/714274cd68314df1fb29ebc426a9283c732dec99 |
| twitter:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10796600?s=400&v=4 |
| og:image:alt | In 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 1bae9c7d08ea14e1ee9576041777790e900aa7d28044a68c6b15fb7dc65e3f07 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | ac18303b591e6c99c630127127da68fd81b8a705 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width