René's URL Explorer Experiment


Title: gh-138791: fix crash when visiting a non-consumed timer handler by picnixz · Pull Request #138789 · python/cpython · GitHub

Open Graph Title: gh-138791: fix crash when visiting a non-consumed timer handler by picnixz · Pull Request #138789 · python/cpython

X Title: gh-138791: fix crash when visiting a non-consumed timer handler by picnixz · Pull Request #138789 · python/cpython

Description: In 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two...

Open Graph Description: In 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two...

X Description: In 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two...

Opengraph URL: https://github.com/python/cpython/pull/138789

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aa27a5e4-8dba-8ea4-2a9b-a50c24df3264
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id98EA:312517:23C1AB9:3111494:696AC3BE
html-safe-nonce03dc05e77a374e0731cc860020f57409459332449a0f94cf42fd725b0b17c0d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEVBOjMxMjUxNzoyM0MxQUI5OjMxMTE0OTQ6Njk2QUMzQkUiLCJ2aXNpdG9yX2lkIjoiMzIyNjQ4MTc1NjU2MjIzNjc4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1b5ab2e8a0fa552055707807a80a35b4cd3978f9c068855625002cfdaf29a6c1
hovercard-subject-tagpull_request:2818851437
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/138789/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9e0fb0791b8d7f385196cb2f614c9dbb15b9e3d85b9c47e4dfdf110d80fe528f/python/cpython/pull/138789
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9e0fb0791b8d7f385196cb2f614c9dbb15b9e3d85b9c47e4dfdf110d80fe528f/python/cpython/pull/138789
og:image:altIn 283380a, I forgot to take into account the following: a timer handler may not necessarily be destroyed when we deallocate the window. whenever a timer handler is created, there are actually two...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None986b6a1d774985095564e64d6963d11f094da3d0e2bfda2ab1a27d63662eb033
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release89ad2112b9c4e11df6a0c13c8c1f8eedd36b0977
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138789#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138789
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138789
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138789
Reloadhttps://github.com/python/cpython/pull/138789
Reloadhttps://github.com/python/cpython/pull/138789
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138789
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/138789
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/138789#issue-comment-box
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/gc/tk-timer-handler-116946https://github.com/picnixz/cpython/tree/fix/gc/tk-timer-handler-116946
gh-138791: fix crash when visiting a non-consumed timer handler https://github.com/python/cpython/pull/138789#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/gc/tk-timer-handler-116946https://github.com/picnixz/cpython/tree/fix/gc/tk-timer-handler-116946
Conversation 17 https://github.com/python/cpython/pull/138789
Commits 2 https://github.com/python/cpython/pull/138789/commits
Checks 39 https://github.com/python/cpython/pull/138789/checks
Files changed https://github.com/python/cpython/pull/138789/files
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138789#issue-3406174987
Please reload this pagehttps://github.com/python/cpython/pull/138789
283380ahttps://github.com/python/cpython/commit/283380a9417eebf1bf9d3a1e941cef94149712bb
@serhiy-storchakahttps://github.com/serhiy-storchaka
Heap types implemented in C must have Py_TPFLAGS_HAVE_GC and implement tp_traverse #116946https://github.com/python/cpython/issues/116946
Crash with non-consumed Tk timer handler #138791https://github.com/python/cpython/issues/138791
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
fix crash when visiting a non-consumed timer handlerhttps://github.com/python/cpython/pull/138789/commits/714274cd68314df1fb29ebc426a9283c732dec99
714274chttps://github.com/python/cpython/pull/138789/commits/714274cd68314df1fb29ebc426a9283c732dec99
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 11, 2025https://github.com/python/cpython/pull/138789#event-19635024485
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 11, 2025https://github.com/python/cpython/pull/138789#event-19635025290
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 11, 2025 https://github.com/python/cpython/pull/138789#ref-issue-2191475400
Heap types implemented in C must have Py_TPFLAGS_HAVE_GC and implement tp_traverse #116946 https://github.com/python/cpython/issues/116946
https://github.com/picnixz
picnixzhttps://github.com/picnixz
serhiy-storchakahttps://github.com/serhiy-storchaka
September 11, 2025 11:48https://github.com/python/cpython/pull/138789#event-19635090326
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138789#event-19635601072
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 11, 2025 https://github.com/python/cpython/pull/138789#ref-issue-3406269070
Crash with non-consumed Tk timer handler #138791 https://github.com/python/cpython/issues/138791
https://github.com/picnixz
add regression testhttps://github.com/python/cpython/pull/138789/commits/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
3873fd5https://github.com/python/cpython/pull/138789/commits/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
https://github.com/picnixz
picnixzhttps://github.com/picnixz
force-pushedhttps://github.com/python/cpython/compare/5f568a8ad7b4538f0c66dcc5aee00694b7739e5f..3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
5f568a8https://github.com/python/cpython/commit/5f568a8ad7b4538f0c66dcc5aee00694b7739e5f
3873fd5https://github.com/python/cpython/commit/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
Compare https://github.com/python/cpython/compare/5f568a8ad7b4538f0c66dcc5aee00694b7739e5f..3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
September 11, 2025 12:21https://github.com/python/cpython/pull/138789#event-19635872363
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 11, 2025 https://github.com/python/cpython/pull/138789#pullrequestreview-3211247733
View reviewed changes https://github.com/python/cpython/pull/138789/files/714274cd68314df1fb29ebc426a9283c732dec99
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/138789#pullrequestreview-3211247733
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3280468381
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3280954037
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3281088695
Please reload this pagehttps://github.com/python/cpython/pull/138789
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 11, 2025 https://github.com/python/cpython/pull/138789#pullrequestreview-3212265651
View reviewed changes https://github.com/python/cpython/pull/138789/files/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
Modules/_tkinter.chttps://github.com/python/cpython/pull/138789/files/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 11, 2025https://github.com/python/cpython/pull/138789#discussion_r2341369848
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138789
Modules/_tkinter.chttps://github.com/python/cpython/pull/138789/files/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b#diff-e22af16a12488bb5478ce31dcf26da13ba5a95e051b2440a740ab6bc4ab0c4fd
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 11, 2025https://github.com/python/cpython/pull/138789#discussion_r2341374127
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138789
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 11, 2025https://github.com/python/cpython/pull/138789#discussion_r2341460411
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3281436878
#138331https://github.com/python/cpython/pull/138331
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3281560126
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3281703664
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138789
https://github.com/ZeroIntensity
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138789
https://github.com/picnixz
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138789
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 11, 2025 https://github.com/python/cpython/pull/138789#ref-pullrequest-3407937527
Revert "gh-116946: fully implement GC protocol for _tkinter.Tk{app,tt}Object (#138331)" #138807 https://github.com/python/cpython/pull/138807
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3282933941
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/ZeroIntensity
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 11, 2025https://github.com/python/cpython/pull/138789#issuecomment-3282964436
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/python
pythonhttps://github.com/python
Sep 13, 2025https://github.com/python/cpython/pull/138789#event-19674758459
https://github.com/python
pythonhttps://github.com/python
Sep 13, 2025https://github.com/python/cpython/pull/138789#event-19674758584
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 13, 2025https://github.com/python/cpython/pull/138789#issuecomment-3287877096
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 22, 2025https://github.com/python/cpython/pull/138789#issuecomment-3319944733
Please reload this pagehttps://github.com/python/cpython/pull/138789
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 22, 2025https://github.com/python/cpython/pull/138789#event-19843631519
https://github.com/picnixz
picnixzhttps://github.com/picnixz
September 22, 2025 16:08https://github.com/python/cpython/pull/138789#event-19843633473
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138789
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/138789/files/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
https://github.com/python/cpython/pull/138789/files/3873fd5431c03c45c2c7cd33ee3617cae85c3c6b
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/138789
https://github.com/picnixz
https://github.com/serhiy-storchaka
https://github.com/ZeroIntensity
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.