René's URL Explorer Experiment


Title: gh-138720: Make Buffered closed check match flush by cmaloney · Pull Request #138724 · python/cpython · GitHub

Open Graph Title: gh-138720: Make Buffered closed check match flush by cmaloney · Pull Request #138724 · python/cpython

X Title: gh-138720: Make Buffered closed check match flush by cmaloney · Pull Request #138724 · python/cpython

Description: In _io__Buffered_flush_impl the macro CHECK_CLOSED is used to check the buffered* is in a good state to be flushed. That differs slightly from buffered_closed. In some cases, that difference would result in close() (_io__Buffered_close_impl) thinking the file needed to be flushed and closed while flush() thought the file was already closed. This could happen during GC and would result in an unraisable exception. Issue: gh-138720

Open Graph Description: In _io__Buffered_flush_impl the macro CHECK_CLOSED is used to check the buffered* is in a good state to be flushed. That differs slightly from buffered_closed. In some cases, that difference would ...

X Description: In _io__Buffered_flush_impl the macro CHECK_CLOSED is used to check the buffered* is in a good state to be flushed. That differs slightly from buffered_closed. In some cases, that difference would ...

Opengraph URL: https://github.com/python/cpython/pull/138724

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e4b26ee9-3973-1acc-01ef-a82a6c9504a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB412:37BBD6:82D1E8:B1CC7E:6A52AC6A
html-safe-nonce347d791deacc0266ddf6ee783ee2d0c4be4bf45ec4acf88c4f0fbfeb7bd9fdf8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDEyOjM3QkJENjo4MkQxRTg6QjFDQzdFOjZBNTJBQzZBIiwidmlzaXRvcl9pZCI6IjE1ODA1MjExMjc0NjExNzAyODIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacfdb0397281a1a5301e15118c88db00a122be52d59273b9d109e80930ade1d79c
hovercard-subject-tagpull_request:2813752572
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/138724/files
twitter:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/751088?s=400&v=4
og:image:altIn _io__Buffered_flush_impl the macro CHECK_CLOSED is used to check the buffered* is in a good state to be flushed. That differs slightly from buffered_closed. In some cases, that difference would ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138724/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138724%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138724%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138724/files
Reloadhttps://github.com/python/cpython/pull/138724/files
Reloadhttps://github.com/python/cpython/pull/138724/files
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:mainhttps://github.com/python/cpython/tree/main
cmaloney:bufferedrwpair_gchttps://github.com/cmaloney/cpython/tree/bufferedrwpair_gc
Conversation 12 https://github.com/python/cpython/pull/138724
Commits 5 https://github.com/python/cpython/pull/138724/commits
Checks 47 https://github.com/python/cpython/pull/138724/checks
Files changed https://github.com/python/cpython/pull/138724/files
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
gh-138720: Make Buffered closed check match flush https://github.com/python/cpython/pull/138724/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/138724/files
e93877d gh-138720: Make Buffered closed check match flush cmaloney Sep 9, 2025 https://github.com/python/cpython/pull/138724/commits/e93877d141f4214c8e9618b1b241b7aa359f8859
ef75829 add blurb cmaloney Sep 10, 2025 https://github.com/python/cpython/pull/138724/commits/ef75829e19f94fe44fb218b04c81bee8bc150340
c368fd6 Fix docs cmaloney Sep 10, 2025 https://github.com/python/cpython/pull/138724/commits/c368fd602c68d08b4f3a5c4e11a02486666a56b1
a9200d3 try, try, try again cmaloney Sep 10, 2025 https://github.com/python/cpython/pull/138724/commits/a9200d332b522cf0d7b29045c7af5af78a6aff00
60fe309 news: Doesn't actually touch BufferedIOBase, be more accurate for cla… cmaloney Sep 10, 2025 https://github.com/python/cpython/pull/138724/commits/60fe309dbb08a36f49e8663809f6713a5b5c0115
Clear filters https://github.com/python/cpython/pull/138724/files
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
test_general.py https://github.com/python/cpython/pull/138724/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
2025-09-09-17-57-49.gh-issue-138720.hAtsm-.rst https://github.com/python/cpython/pull/138724/files#diff-15fea940c8463d2d8349eefd8f629c559a3098f5011ee8fbe67631a92fd9fe2e
bufferedio.c https://github.com/python/cpython/pull/138724/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
Lib/test/test_io/test_general.pyhttps://github.com/python/cpython/pull/138724/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
View file https://github.com/cmaloney/cpython/blob/60fe309dbb08a36f49e8663809f6713a5b5c0115/Lib/test/test_io/test_general.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138724/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138724/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
encukouhttps://github.com/encukou
Sep 17, 2025https://github.com/python/cpython/pull/138724/files#r2355854763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
vstinnerhttps://github.com/vstinner
Sep 17, 2025https://github.com/python/cpython/pull/138724/files#r2355886727
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
cmaloneyhttps://github.com/cmaloney
Sep 17, 2025https://github.com/python/cpython/pull/138724/files#r2356461230
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
encukouhttps://github.com/encukou
Sep 18, 2025https://github.com/python/cpython/pull/138724/files#r2358304942
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
https://github.com/python/cpython/pull/138724/files#diff-2614a0b8891148b52f22187445bc9421cf53282bccd5fb90519b1ff8e344d10e
Misc/NEWS.d/next/Library/2025-09-09-17-57-49.gh-issue-138720.hAtsm-.rsthttps://github.com/python/cpython/pull/138724/files#diff-15fea940c8463d2d8349eefd8f629c559a3098f5011ee8fbe67631a92fd9fe2e
View file https://github.com/cmaloney/cpython/blob/60fe309dbb08a36f49e8663809f6713a5b5c0115/Misc/NEWS.d/next/Library/2025-09-09-17-57-49.gh-issue-138720.hAtsm-.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138724/{{ revealButtonHref }}
Modules/_io/bufferedio.chttps://github.com/python/cpython/pull/138724/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
View file https://github.com/cmaloney/cpython/blob/60fe309dbb08a36f49e8663809f6713a5b5c0115/Modules/_io/bufferedio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138724/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138724/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
https://github.com/python/cpython/pull/138724/files#diff-893faf8dc50d99bfa374e52717f4a7f6a2dd0020fbaa9dfc2cc45464b731d36a
Please reload this pagehttps://github.com/python/cpython/pull/138724/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.