| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7df4b5d7-7a14-df3e-b6eb-868e0f0dc6dd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8802:1F08C5:184F83D:204D9D4:6A5441F4 |
| html-safe-nonce | c478040a74d06820ffd82a6e46b67e082718eb44d7cc582dafee43c0347a26c3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODAyOjFGMDhDNToxODRGODNEOjIwNEQ5RDQ6NkE1NDQxRjQiLCJ2aXNpdG9yX2lkIjoiNjIwMzEzNTQ0MTA2NTIzMDgzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0ee21ace1726316c48f19069b5ecaf9f00ffba2e57ec193702c2e34c2addf565 |
| hovercard-subject-tag | pull_request:285921858 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13870/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/5b069e858815bc75fc8272be0ed67009065e3b052f9d140955f6ccd9b10c3430/python/cpython/pull/13870 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5b069e858815bc75fc8272be0ed67009065e3b052f9d140955f6ccd9b10c3430/python/cpython/pull/13870 |
| og:image:alt | Minor code readability improvement: move the negativity checks for k < 0 in math.comb and math.perm up nearer the top of the functions.
https://bugs.python.org/issue35431 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mdickinson |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/13870#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13870 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13870 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/13870 |
| Reload | https://github.com/python/cpython/pull/13870 |
| Reload | https://github.com/python/cpython/pull/13870 |
| Please reload this page | https://github.com/python/cpython/pull/13870 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/13870 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| mdickinson | https://github.com/mdickinson |
| python:master | https://github.com/python/cpython/tree/master |
| mdickinson:math-comb-math-perm-cleanup | https://github.com/mdickinson/cpython/tree/math-comb-math-perm-cleanup |
| Conversation | https://github.com/python/cpython/pull/13870 |
| Commits1 (1) | https://github.com/python/cpython/pull/13870/commits |
| Checks | https://github.com/python/cpython/pull/13870/checks |
| Files changed | https://github.com/python/cpython/pull/13870/files |
| bpo-35431: Simplify negativity checks in math.comb and math.perm. | https://github.com/python/cpython/pull/13870#top |
| mdickinson | https://github.com/mdickinson |
| python:master | https://github.com/python/cpython/tree/master |
| mdickinson:math-comb-math-perm-cleanup | https://github.com/mdickinson/cpython/tree/math-comb-math-perm-cleanup |
|
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
| Jun 6, 2019 | https://github.com/python/cpython/pull/13870#issue-453179539 |
| Please reload this page | https://github.com/python/cpython/pull/13870 |
| https://bugs.python.org/issue35431 | https://bugs.python.org/issue35431 |
| Please reload this page | https://github.com/python/cpython/pull/13870 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Jun 6, 2019 | https://github.com/python/cpython/pull/13870#event-2395275170 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jun 6, 2019 | https://github.com/python/cpython/pull/13870#event-2395275320 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 6, 2019 | https://github.com/python/cpython/pull/13870#event-2395275491 |
| https://github.com/mangrisano |
| mangrisano | https://github.com/mangrisano |
|
Jun 6, 2019
| https://github.com/python/cpython/pull/13870#pullrequestreview-246815647 |
|
View reviewed changes
| https://github.com/python/cpython/pull/13870/files |
|
| https://github.com/mdickinson |
| Simplify negativity checks in math.comb and math.perm. | https://github.com/python/cpython/pull/13870/commits/7c310cf75439e192e0725f563f9e71d7cfbc9120 |
| 7c310cf | https://github.com/python/cpython/pull/13870/commits/7c310cf75439e192e0725f563f9e71d7cfbc9120 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
| force-pushed | https://github.com/python/cpython/compare/c9bc1891c2984a3e763e350c98a5255fcb04af5d..7c310cf75439e192e0725f563f9e71d7cfbc9120 |
| c9bc189 | https://github.com/python/cpython/commit/c9bc1891c2984a3e763e350c98a5255fcb04af5d |
| 7c310cf | https://github.com/python/cpython/commit/7c310cf75439e192e0725f563f9e71d7cfbc9120 |
|
Compare
| https://github.com/python/cpython/compare/c9bc1891c2984a3e763e350c98a5255fcb04af5d..7c310cf75439e192e0725f563f9e71d7cfbc9120 |
| June 9, 2019 13:12 | https://github.com/python/cpython/pull/13870#event-2399419420 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
|
needs backport to 3.8
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22 |
| Jun 9, 2019 | https://github.com/python/cpython/pull/13870#event-2399420415 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
| 45e0411 | https://github.com/python/cpython/commit/45e0411eee023b21acf1615e995d26058d66c0f1 |
| Jun 16, 2019 | https://github.com/python/cpython/pull/13870#event-2415814677 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Jun 16, 2019 | https://github.com/python/cpython/pull/13870#issuecomment-502438481 |
| @mdickinson | https://github.com/mdickinson |
| Please reload this page | https://github.com/python/cpython/pull/13870 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 16, 2019 | https://github.com/python/cpython/pull/13870#event-2415814692 |
| https://github.com/mdickinson |
| mdickinson | https://github.com/mdickinson |
| June 16, 2019 10:06 | https://github.com/python/cpython/pull/13870#event-2415814728 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jun 16, 2019 | https://github.com/python/cpython/pull/13870#issuecomment-502438509 |
| GH-14125 | https://github.com/python/cpython/pull/14125 |
| 3.8 branch | https://github.com/python/cpython/tree/3.8 |
| Please reload this page | https://github.com/python/cpython/pull/13870 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.8
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22 |
| Jun 16, 2019 | https://github.com/python/cpython/pull/13870#event-2415814825 |
| mdickinson | https://github.com/mdickinson |
|
Jun 16, 2019
| https://github.com/python/cpython/pull/13870#ref-commit-599f7ec |
|
| https://github.com/miss-islington |
|
| https://github.com/mdickinson |
| Simplify negativity checks in math.comb and math.perm. ( | https://github.com/python/cpython/commit/599f7ecb70f1b9714c702322b235b4d8155205ae |
| GH-13870 | https://github.com/python/cpython/pull/13870 |
| ) ( | https://github.com/python/cpython/commit/599f7ecb70f1b9714c702322b235b4d8155205ae |
| #1… | https://github.com/python/cpython/pull/14125 |
| 599f7ec | https://github.com/python/cpython/commit/599f7ecb70f1b9714c702322b235b4d8155205ae |
| …4125 | https://github.com/python/cpython/pull/14125 |
| 45e0411 | https://github.com/python/cpython/commit/45e0411eee023b21acf1615e995d26058d66c0f1 |
| lisroach | https://github.com/lisroach |
|
Sep 10, 2019
| https://github.com/python/cpython/pull/13870#ref-commit-62c72a9 |
|
| https://github.com/mdickinson |
|
| https://github.com/lisroach |
| Simplify negativity checks in math.comb and math.perm. ( | https://github.com/lisroach/cpython/commit/62c72a9cb8c7d52324a14514d26fda1320aaeec0 |
| pythonGH-13870 | https://github.com/python/cpython/pull/13870 |
| ) | https://github.com/lisroach/cpython/commit/62c72a9cb8c7d52324a14514d26fda1320aaeec0 |
| 62c72a9 | https://github.com/lisroach/cpython/commit/62c72a9cb8c7d52324a14514d26fda1320aaeec0 |
| DinoV | https://github.com/DinoV |
|
Jan 14, 2020
| https://github.com/python/cpython/pull/13870#ref-commit-07eaae4 |
|
| https://github.com/mdickinson |
|
| https://github.com/DinoV |
| Simplify negativity checks in math.comb and math.perm. ( | https://github.com/DinoV/cpython/commit/07eaae49cec595932e9c0b1a0e154542f03343c5 |
| pythonGH-13870 | https://github.com/python/cpython/pull/13870 |
| ) | https://github.com/DinoV/cpython/commit/07eaae49cec595932e9c0b1a0e154542f03343c5 |
| 07eaae4 | https://github.com/DinoV/cpython/commit/07eaae49cec595932e9c0b1a0e154542f03343c5 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13870 |
|
| https://github.com/mangrisano |
|
mangrisano
| https://github.com/mangrisano |
|
| https://github.com/python/cpython/pull/13870/files/c9bc1891c2984a3e763e350c98a5255fcb04af5d |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/13870 |
|
| https://github.com/mdickinson |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/mangrisano |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |