René's URL Explorer Experiment


Title: gh-130168: pyrepl can messup and poll is not thread safe by yihong0618 · Pull Request #138617 · python/cpython · GitHub

Open Graph Title: gh-130168: pyrepl can messup and poll is not thread safe by yihong0618 · Pull Request #138617 · python/cpython

X Title: gh-130168: pyrepl can messup and poll is not thread safe by yihong0618 · Pull Request #138617 · python/cpython

Description: This fix issue 130168 but for this one it contains two issues: the first one is for poll here is not thread safe more can check. ##53111 and the second one is for the prepare and restore the error message will mess up. and for the default pyrepl >= 3.13 the input is wrote in python different from the old one this patch make the error same which is can't re-enter readline like python3.12 before this patch: after this patch: which not mess up anything cc @gaogaotiantian can you help to check? Thank you very much. Issue: gh-130168

Open Graph Description: This fix issue 130168 but for this one it contains two issues: the first one is for poll here is not thread safe more can check. ##53111 and the second one is for the prepare and restore the error ...

X Description: This fix issue 130168 but for this one it contains two issues: the first one is for poll here is not thread safe more can check. ##53111 and the second one is for the prepare and restore the error ...

Opengraph URL: https://github.com/python/cpython/pull/138617

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f82905af-c391-b102-a0a0-462d72db43be
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8072:C257A:8483BF:BC0461:6A510608
html-safe-nonce092eb87b82812caabcc617a9db4f0ca2f988d935ff2b749e6a4a4767401a6a6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDcyOkMyNTdBOjg0ODNCRjpCQzA0NjE6NkE1MTA2MDgiLCJ2aXNpdG9yX2lkIjoiMzg3Nzg5MTIyNzA1NjY3MDIxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3ea64fb10267ed2fd3853cd050a9bb052d97efec8b092cbb0c68b5e501450f42
hovercard-subject-tagpull_request:2806008371
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/138617/files
twitter:imagehttps://avatars.githubusercontent.com/u/15976103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15976103?s=400&v=4
og:image:altThis fix issue 130168 but for this one it contains two issues: the first one is for poll here is not thread safe more can check. ##53111 and the second one is for the prepare and restore the error ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None38906a4da4e3e9fd88dfeacee232f5932c0c5f7495de3b4efc53ddfac7173d12
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release90441ea9b98e7491aa6ebcd135fccce4e2396f48
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138617/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138617%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138617%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138617/files
Reloadhttps://github.com/python/cpython/pull/138617/files
Reloadhttps://github.com/python/cpython/pull/138617/files
Please reload this pagehttps://github.com/python/cpython/pull/138617/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138617/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
yihong0618https://github.com/yihong0618
python:mainhttps://github.com/python/cpython/tree/main
Conversation 36 https://github.com/python/cpython/pull/138617
Commits 10 https://github.com/python/cpython/pull/138617/commits
Checks 49 https://github.com/python/cpython/pull/138617/checks
Files changed https://github.com/python/cpython/pull/138617/files
Please reload this pagehttps://github.com/python/cpython/pull/138617/files
gh-130168: pyrepl can messup and poll is not thread safe https://github.com/python/cpython/pull/138617/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/138617/files
0609120 fix: pyrepl can messup and poll is not thread safe yihong0618 Sep 7, 2025 https://github.com/python/cpython/pull/138617/commits/0609120434b6be5a223a8b816ee7ddca7498315e
ffc77f2 fix: mypy type check yihong0618 Sep 7, 2025 https://github.com/python/cpython/pull/138617/commits/ffc77f2b9750d6d29f72874b30348a9a94f6a9dd
8fa9c19 fix: apply suggestions from code review yihong0618 Sep 7, 2025 https://github.com/python/cpython/pull/138617/commits/8fa9c19ac1f5ab81c0502586c8b0b24465e70b84
78d7416 fix: __svtermstate default None yihong0618 Sep 7, 2025 https://github.com/python/cpython/pull/138617/commits/78d741629bee518b350b2e009c13f2c59b2402cc
ca27ae4 fix: drop cleanup part for new test yihong0618 Sep 7, 2025 https://github.com/python/cpython/pull/138617/commits/ca27ae4d0977020354a6c0d125046f6988bbf70c
b194f8f fix: forget to add clean up back yihong0618 Sep 7, 2025 https://github.com/python/cpython/pull/138617/commits/b194f8fae6b22f2adda6526ad7da93ad6c01cadd
e43fc60 Merge branch 'main' into hy/close_new_repl_error_mess yihong0618 Sep 17, 2025 https://github.com/python/cpython/pull/138617/commits/e43fc60d4cb8b0fea39ff46a8ca552a18e1e7a7e
5d83648 fix: tests failed by wrong conflict fix yihong0618 Sep 17, 2025 https://github.com/python/cpython/pull/138617/commits/5d83648eed320a6e7dcfaac2ee806afc0f4f0d3f
b3a41eb Merge branch 'main' into hy/close_new_repl_error_mess yihong0618 Sep 17, 2025 https://github.com/python/cpython/pull/138617/commits/b3a41eb8ebfaa5c08baa6b5914760e366eb1b984
17877b6 fix: merge regress yihong0618 Sep 25, 2025 https://github.com/python/cpython/pull/138617/commits/17877b634ed7c25626fcc16d501d129ef2fb5b2c
Clear filters https://github.com/python/cpython/pull/138617/files
Please reload this pagehttps://github.com/python/cpython/pull/138617/files
Please reload this pagehttps://github.com/python/cpython/pull/138617/files
unix_console.py https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
test_unix_console.py https://github.com/python/cpython/pull/138617/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
2025-09-07-19-47-35.gh-issue-130168.qvtlOZ.rst https://github.com/python/cpython/pull/138617/files#diff-2c18eae4277c51955f6cd34d68921c35e75e32941d4e4b9c6bbdd1c92c75c117
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L561
Lib/_pyrepl/unix_console.pyhttps://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
View file https://github.com/python/cpython/blob/17877b634ed7c25626fcc16d501d129ef2fb5b2c/Lib/_pyrepl/unix_console.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138617/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
picnixzhttps://github.com/picnixz
Sep 29, 2025https://github.com/python/cpython/pull/138617/files#r2387363062
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138617/files
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138617/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L562
Lib/test/test_pyrepl/test_unix_console.pyhttps://github.com/python/cpython/pull/138617/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
View file https://github.com/python/cpython/blob/17877b634ed7c25626fcc16d501d129ef2fb5b2c/Lib/test/test_pyrepl/test_unix_console.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138617/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138617/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
https://github.com/python/cpython/pull/138617/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
https://github.com/python/cpython/pull/138617/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
https://github.com/python/cpython/pull/138617/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
Misc/NEWS.d/next/Library/2025-09-07-19-47-35.gh-issue-130168.qvtlOZ.rsthttps://github.com/python/cpython/pull/138617/files#diff-2c18eae4277c51955f6cd34d68921c35e75e32941d4e4b9c6bbdd1c92c75c117
View file https://github.com/python/cpython/blob/17877b634ed7c25626fcc16d501d129ef2fb5b2c/Misc/NEWS.d/next/Library/2025-09-07-19-47-35.gh-issue-130168.qvtlOZ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138617/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/138617/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.