René's URL Explorer Experiment


Title: gh-138514: getpass: restrict `echo_char` to a single ASCII character by bkjoh · Pull Request #138591 · python/cpython · GitHub

Open Graph Title: gh-138514: getpass: restrict `echo_char` to a single ASCII character by bkjoh · Pull Request #138591 · python/cpython

X Title: gh-138514: getpass: restrict `echo_char` to a single ASCII character by bkjoh · Pull Request #138591 · python/cpython

Description: Fixes gh-138514. 📚 Documentation preview 📚: https://cpython-previews--138591.org.readthedocs.build/

Open Graph Description: Fixes gh-138514. 📚 Documentation preview 📚: https://cpython-previews--138591.org.readthedocs.build/

X Description: Fixes gh-138514. 📚 Documentation preview 📚: https://cpython-previews--138591.org.readthedocs.build/

Opengraph URL: https://github.com/python/cpython/pull/138591

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:647d31d2-a157-47a2-9d15-c43c0a3ee09b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE0C6:1D8CC3:13500CA:1A3D679:6A521CAF
html-safe-nonceb71b9d0bd461ea8b2283adccacabcb856b85b357552044d96b30491b42f2c216
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMEM2OjFEOENDMzoxMzUwMENBOjFBM0Q2Nzk6NkE1MjFDQUYiLCJ2aXNpdG9yX2lkIjoiNzY2ODYwNDcyNjU3MzkzMTY5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac523f76ca5b66095da86efed3be228a945622ec7df2168d5b9200d0ea0f7f5f77
hovercard-subject-tagpull_request:2805256917
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/138591/files
twitter:imagehttps://avatars.githubusercontent.com/u/16676218?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16676218?s=400&v=4
og:image:altFixes gh-138514. 📚 Documentation preview 📚: https://cpython-previews--138591.org.readthedocs.build/
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138591/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138591%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138591%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138591/files
Reloadhttps://github.com/python/cpython/pull/138591/files
Reloadhttps://github.com/python/cpython/pull/138591/files
Please reload this pagehttps://github.com/python/cpython/pull/138591/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138591/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
Conversation 40 https://github.com/python/cpython/pull/138591
Commits 32 https://github.com/python/cpython/pull/138591/commits
Checks 51 https://github.com/python/cpython/pull/138591/checks
Files changed https://github.com/python/cpython/pull/138591/files
Please reload this pagehttps://github.com/python/cpython/pull/138591/files
gh-138514: getpass: restrict echo_char to a single ASCII character https://github.com/python/cpython/pull/138591/files#top
Show all changes 32 commits https://github.com/python/cpython/pull/138591/files
7d412d9 Accept only single character with getpass.getpass(echo_char) (see: gh… bkjoh Sep 6, 2025 https://github.com/python/cpython/pull/138591/commits/7d412d9ae32921df22d6adb445199b1943dee1b9
a99e900 accept suggestion to reword blurb bkjoh Sep 6, 2025 https://github.com/python/cpython/pull/138591/commits/a99e90003c5d1ae37fbf5aff9b9dbf8f2e413829
bbd741a reword echo_char description per suggestion bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/bbd741ae9ae59576fe6c6e94dc6a6cc3d0cf4d60
4338c9f reword echo_char error message per suggestion bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/4338c9ff86429105a019ef0ba5ed005410911024
37a0a72 reword getpass echo_char news per suggestion bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/37a0a7293ac28e38899f30270545666919f8c9ea
b063e33 fix getpass echo_char spacing per suggestion bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/b063e33afbead1745874930644cf7b45458701ad
5151819 Merge branch 'main' into gh-138514-fix-getpass-echo-char bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/515181937d5adbc918d53f3e7754b7d138a18a20
fcda047 remove bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/fcda047f5de20bc7d9eb27986fd26d099f63925a
4eb5701 modify bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/4eb57011f555a91eb176d4c5fe3552b3b4d66e6b
a183a71 Merge branch 'main' into gh-138514-fix-getpass-echo-char bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/a183a71ee17ccfd43d348f9588d070430c6b7bcc
e8d08f8 modify TypeError message bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/e8d08f8115865b3fa15e720bc65ddca9a2440c97
749cc7d modify TypeError message again bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/749cc7d961910baf1106a36531100bdef0b99f10
a6aed93 add comma to ValueError message bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/a6aed9356168a32ca5bfebce64420a9642069ca1
8385bc5 Merge branch 'main' into gh-138514-fix-getpass-echo-char bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/8385bc58a4c500158ed3c003ab926ce42c6a1d89
d1281cb Merge branch 'main' into gh-138514-fix-getpass-echo-char bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/d1281cbecbe7d1c4baa1a9f3e437e426f4175763
7253600 accept suggestion from picnixz bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/7253600d767b7da9bfc8c0f0b692140ee567088f
cf0cc73 accept language suggestion from picnixz bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/cf0cc7368740992eb73bf77166e4a78f38c01aab
58f86cd accept spacing suggestion from picnixz bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/58f86cdeb60cb6f7550aee5b5136b52fcf494e58
6bb99d3 accept leftover artifact removal suggestion from picnixz bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/6bb99d3fb4ece19bbdef97af61c2c731237a1833
fde711f add new line per suggestion bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/fde711ff958a5b9d70e0c470ed8ffa5d3cd838c1
acc7bca use subTest for getpass echo_char tests bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/acc7bca86fa2bb9716279ae0d3ad2b8ae34e6baa
461fd5b switch to one-liner style bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/461fd5b970367b9bde21964a89a393859ea42f66
301ef46 use @support.subTests syntax bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/301ef46a9df0e42213b4dcf3451d34aa23480fd8
6e148e5 match style bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/6e148e58fd5718074d60362f28e1a88eb5ec3914
caded77 match style further bkjoh Sep 10, 2025 https://github.com/python/cpython/pull/138591/commits/caded776184fec339b3853db5daaf80ae96058da
981d49d remove too-verbose comments bkjoh Sep 11, 2025 https://github.com/python/cpython/pull/138591/commits/981d49de80c33ab4ef49a567586303c08ae14af0
07534ce remove too-verbose comments bkjoh Sep 11, 2025 https://github.com/python/cpython/pull/138591/commits/07534ce03f5de1fb2a40e4f39cb254843c55d249
2203e03 simplify non-ascii tests using ascii bkjoh Sep 11, 2025 https://github.com/python/cpython/pull/138591/commits/2203e03db2176dbcf8f47bea87e57363b7bec7a7
6485375 test every non-printable ascii byte bkjoh Sep 11, 2025 https://github.com/python/cpython/pull/138591/commits/6485375ce96c2ea2455f9c829fc1f76ca68668c8
2e7bd33 Merge branch 'main' into gh-138514-fix-getpass-echo-char bkjoh Sep 11, 2025 https://github.com/python/cpython/pull/138591/commits/2e7bd339f00400b3e6cefb484b677af9dffb5eb5
3629a53 remove s characters bkjoh Sep 11, 2025 https://github.com/python/cpython/pull/138591/commits/3629a53a10776b5357c1778c72f6cf383608301b
e2ba1b7 Merge branch 'main' into gh-138514-fix-getpass-echo-char bkjoh Sep 11, 2025 https://github.com/python/cpython/pull/138591/commits/e2ba1b7589518bd71b7a8fd9579286234139f8fc
Clear filters https://github.com/python/cpython/pull/138591/files
Please reload this pagehttps://github.com/python/cpython/pull/138591/files
Please reload this pagehttps://github.com/python/cpython/pull/138591/files
getpass.rst https://github.com/python/cpython/pull/138591/files#diff-a539e906f12f8eb221f1d81caf82e4ceb2f0d5cf30b8505c73b6a366a5752bf4
getpass.py https://github.com/python/cpython/pull/138591/files#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
test_getpass.py https://github.com/python/cpython/pull/138591/files#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
ACKS https://github.com/python/cpython/pull/138591/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2025-09-06-11-26-21.gh-issue-138514.66ltOb.rst https://github.com/python/cpython/pull/138591/files#diff-f309a76342502fb6c9a3bb6024de7d86e1b8a722e65c605cafcbe575a1f3e5b0
Doc/library/getpass.rsthttps://github.com/python/cpython/pull/138591/files#diff-a539e906f12f8eb221f1d81caf82e4ceb2f0d5cf30b8505c73b6a366a5752bf4
View file https://github.com/python/cpython/blob/e2ba1b7589518bd71b7a8fd9579286234139f8fc/Doc/library/getpass.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138591/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138591/files#diff-a539e906f12f8eb221f1d81caf82e4ceb2f0d5cf30b8505c73b6a366a5752bf4
https://github.com/python/cpython/pull/138591/files#diff-a539e906f12f8eb221f1d81caf82e4ceb2f0d5cf30b8505c73b6a366a5752bf4
Lib/getpass.pyhttps://github.com/python/cpython/pull/138591/files#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
View file https://github.com/python/cpython/blob/e2ba1b7589518bd71b7a8fd9579286234139f8fc/Lib/getpass.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138591/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138591/files#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
https://github.com/python/cpython/pull/138591/files#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
https://github.com/python/cpython/pull/138591/files#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
https://github.com/python/cpython/pull/138591/files#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
View file https://github.com/python/cpython/blob/e2ba1b7589518bd71b7a8fd9579286234139f8fc/Lib/test/test_getpass.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138591/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138591/files#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Misc/ACKShttps://github.com/python/cpython/pull/138591/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/python/cpython/blob/e2ba1b7589518bd71b7a8fd9579286234139f8fc/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138591/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138591/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/138591/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Library/2025-09-06-11-26-21.gh-issue-138514.66ltOb.rsthttps://github.com/python/cpython/pull/138591/files#diff-f309a76342502fb6c9a3bb6024de7d86e1b8a722e65c605cafcbe575a1f3e5b0
View file https://github.com/python/cpython/blob/e2ba1b7589518bd71b7a8fd9579286234139f8fc/Misc/NEWS.d/next/Library/2025-09-06-11-26-21.gh-issue-138514.66ltOb.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138591/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/138591/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.