René's URL Explorer Experiment


Title: gh-138514: getpass: restrict `echo_char` to a single ASCII character by bkjoh · Pull Request #138591 · python/cpython · GitHub

Open Graph Title: gh-138514: getpass: restrict `echo_char` to a single ASCII character by bkjoh · Pull Request #138591 · python/cpython

X Title: gh-138514: getpass: restrict `echo_char` to a single ASCII character by bkjoh · Pull Request #138591 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Fixes gh-138514. 📚 Documentation preview 📚: https://cpython-previews--138591.org.readthedocs.build/

X Description: Fixes gh-138514. 📚 Documentation preview 📚: https://cpython-previews--138591.org.readthedocs.build/

Opengraph URL: https://github.com/python/cpython/pull/138591

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e389e740-b339-3005-7e14-65ad598344fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD7C6:2B1946:FF6926:15A5CA4:6A520737
html-safe-nonce2cf6248bec80a611634ddc2a36360ef5ff8ca579d51785cea312a263d75b9deb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0M2OjJCMTk0NjpGRjY5MjY6MTVBNUNBNDo2QTUyMDczNyIsInZpc2l0b3JfaWQiOiI1MjU3MjE0NzkwMTQxNjA5NzgzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacd480e796b635805816f1b0392f19475d86ab811346ab7c2cb7a891a30d870b69
hovercard-subject-tagpull_request:2805256917
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/138591/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/685893e9f41be123863611b0dff521366b85afeb860d9aaba3fb137d4b772823/python/cpython/pull/138591
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/685893e9f41be123863611b0dff521366b85afeb860d9aaba3fb137d4b772823/python/cpython/pull/138591
og:image:altFixes gh-138514. 📚 Documentation preview 📚: https://cpython-previews--138591.org.readthedocs.build/
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebkjoh
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138591#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138591
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138591
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138591
Reloadhttps://github.com/python/cpython/pull/138591
Reloadhttps://github.com/python/cpython/pull/138591
Please reload this pagehttps://github.com/python/cpython/pull/138591
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138591
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
Conversationhttps://github.com/python/cpython/pull/138591
Commits32 (32)https://github.com/python/cpython/pull/138591/commits
Checkshttps://github.com/python/cpython/pull/138591/checks
Files changedhttps://github.com/python/cpython/pull/138591/files
gh-138514: getpass: restrict echo_char to a single ASCII characterhttps://github.com/python/cpython/pull/138591#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 6, 2025https://github.com/python/cpython/pull/138591#issue-3390611589
Please reload this pagehttps://github.com/python/cpython/pull/138591
gh-138514https://github.com/python/cpython/issues/138514
https://cpython-previews--138591.org.readthedocs.build/https://cpython-previews--138591.org.readthedocs.build/
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
Accept only single character with getpass.getpass(echo_char) (see:https://github.com/python/cpython/pull/138591/commits/7d412d9ae32921df22d6adb445199b1943dee1b9
gh…https://github.com/python/cpython/issues/138514
7d412d9https://github.com/python/cpython/pull/138591/commits/7d412d9ae32921df22d6adb445199b1943dee1b9
…-138514https://github.com/python/cpython/issues/138514
https://github.com/apps/python-cla-bot
python-cla-bothttps://github.com/apps/python-cla-bot
Sep 6, 2025https://github.com/python/cpython/pull/138591#issuecomment-3262809808
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://cla.python.org/
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 6, 2025 https://github.com/python/cpython/pull/138591#ref-issue-3385499212
getpass's echo_char should be restricted to a single ASCII character #138514 https://github.com/python/cpython/issues/138514
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 6, 2025https://github.com/python/cpython/pull/138591#event-19545801982
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 6, 2025 https://github.com/python/cpython/pull/138591#pullrequestreview-3193486761
View reviewed changes https://github.com/python/cpython/pull/138591/files/7d412d9ae32921df22d6adb445199b1943dee1b9
picnixzhttps://github.com/picnixz
https://github.com/python/cpython/pull/138591#pullrequestreview-3193486761
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138591
Doc/library/getpass.rsthttps://github.com/python/cpython/pull/138591/files/7d412d9ae32921df22d6adb445199b1943dee1b9#diff-a539e906f12f8eb221f1d81caf82e4ceb2f0d5cf30b8505c73b6a366a5752bf4
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/getpass.pyhttps://github.com/python/cpython/pull/138591/files/7d412d9ae32921df22d6adb445199b1943dee1b9#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/getpass.pyhttps://github.com/python/cpython/pull/138591/files/7d412d9ae32921df22d6adb445199b1943dee1b9#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/getpass.pyhttps://github.com/python/cpython/pull/138591/files/7d412d9ae32921df22d6adb445199b1943dee1b9#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
Please reload this pagehttps://github.com/python/cpython/pull/138591
Misc/NEWS.d/next/Library/2025-09-06-11-26-21.gh-issue-138514.66ltOb.rsthttps://github.com/python/cpython/pull/138591/files/7d412d9ae32921df22d6adb445199b1943dee1b9#diff-f309a76342502fb6c9a3bb6024de7d86e1b8a722e65c605cafcbe575a1f3e5b0
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 6, 2025https://github.com/python/cpython/pull/138591#issuecomment-3263024635
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
https://github.com/picnixz
accept suggestion to reword blurbhttps://github.com/python/cpython/pull/138591/commits/a99e90003c5d1ae37fbf5aff9b9dbf8f2e413829
a99e900https://github.com/python/cpython/pull/138591/commits/a99e90003c5d1ae37fbf5aff9b9dbf8f2e413829
https://github.com/brianschubert
brianschuberthttps://github.com/brianschubert
Sep 7, 2025 https://github.com/python/cpython/pull/138591#pullrequestreview-3194569070
View reviewed changes https://github.com/python/cpython/pull/138591/files/a99e90003c5d1ae37fbf5aff9b9dbf8f2e413829
Misc/NEWS.d/next/Library/2025-09-06-11-26-21.gh-issue-138514.66ltOb.rsthttps://github.com/python/cpython/pull/138591/files/a99e90003c5d1ae37fbf5aff9b9dbf8f2e413829#diff-f309a76342502fb6c9a3bb6024de7d86e1b8a722e65c605cafcbe575a1f3e5b0
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 9, 2025https://github.com/python/cpython/pull/138591#issuecomment-3269831004
Please reload this pagehttps://github.com/python/cpython/pull/138591
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 10, 2025https://github.com/python/cpython/pull/138591#issuecomment-3272754334
Please reload this pagehttps://github.com/python/cpython/pull/138591
Please reload this pagehttps://github.com/python/cpython/pull/138591
bkjohhttps://github.com/bkjoh
September 9, 2025 20:24https://github.com/python/cpython/pull/138591#commits-pushed-bbd741a
https://github.com/bkjoh
https://github.com/picnixz
reword echo_char description per suggestionhttps://github.com/python/cpython/pull/138591/commits/bbd741ae9ae59576fe6c6e94dc6a6cc3d0cf4d60
bbd741ahttps://github.com/python/cpython/pull/138591/commits/bbd741ae9ae59576fe6c6e94dc6a6cc3d0cf4d60
https://github.com/bkjoh
https://github.com/picnixz
reword echo_char error message per suggestionhttps://github.com/python/cpython/pull/138591/commits/4338c9ff86429105a019ef0ba5ed005410911024
4338c9fhttps://github.com/python/cpython/pull/138591/commits/4338c9ff86429105a019ef0ba5ed005410911024
https://github.com/bkjoh
https://github.com/brianschubert
reword getpass echo_char news per suggestionhttps://github.com/python/cpython/pull/138591/commits/37a0a7293ac28e38899f30270545666919f8c9ea
37a0a72https://github.com/python/cpython/pull/138591/commits/37a0a7293ac28e38899f30270545666919f8c9ea
https://github.com/bkjoh
https://github.com/picnixz
fix getpass echo_char spacing per suggestionhttps://github.com/python/cpython/pull/138591/commits/b063e33afbead1745874930644cf7b45458701ad
b063e33https://github.com/python/cpython/pull/138591/commits/b063e33afbead1745874930644cf7b45458701ad
https://github.com/bkjoh
Merge branch 'main' intohttps://github.com/python/cpython/pull/138591/commits/515181937d5adbc918d53f3e7754b7d138a18a20
gh-138514https://github.com/python/cpython/issues/138514
-fix-getpass-echo-charhttps://github.com/python/cpython/pull/138591/commits/515181937d5adbc918d53f3e7754b7d138a18a20
5151819https://github.com/python/cpython/pull/138591/commits/515181937d5adbc918d53f3e7754b7d138a18a20
https://github.com/bkjoh
removehttps://github.com/python/cpython/pull/138591/commits/fcda047f5de20bc7d9eb27986fd26d099f63925a
fcda047https://github.com/python/cpython/pull/138591/commits/fcda047f5de20bc7d9eb27986fd26d099f63925a
https://github.com/bkjoh
modifyhttps://github.com/python/cpython/pull/138591/commits/4eb57011f555a91eb176d4c5fe3552b3b4d66e6b
4eb5701https://github.com/python/cpython/pull/138591/commits/4eb57011f555a91eb176d4c5fe3552b3b4d66e6b
https://github.com/bkjoh
Merge branch 'main' intohttps://github.com/python/cpython/pull/138591/commits/a183a71ee17ccfd43d348f9588d070430c6b7bcc
gh-138514https://github.com/python/cpython/issues/138514
-fix-getpass-echo-charhttps://github.com/python/cpython/pull/138591/commits/a183a71ee17ccfd43d348f9588d070430c6b7bcc
a183a71https://github.com/python/cpython/pull/138591/commits/a183a71ee17ccfd43d348f9588d070430c6b7bcc
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 10, 2025https://github.com/python/cpython/pull/138591#issuecomment-3272923999
Please reload this pagehttps://github.com/python/cpython/pull/138591
Please reload this pagehttps://github.com/python/cpython/pull/138591
bkjohhttps://github.com/bkjoh
September 9, 2025 22:32https://github.com/python/cpython/pull/138591#commits-pushed-e8d08f8
https://github.com/bkjoh
modify TypeError messagehttps://github.com/python/cpython/pull/138591/commits/e8d08f8115865b3fa15e720bc65ddca9a2440c97
e8d08f8https://github.com/python/cpython/pull/138591/commits/e8d08f8115865b3fa15e720bc65ddca9a2440c97
https://github.com/bkjoh
modify TypeError message againhttps://github.com/python/cpython/pull/138591/commits/749cc7d961910baf1106a36531100bdef0b99f10
749cc7dhttps://github.com/python/cpython/pull/138591/commits/749cc7d961910baf1106a36531100bdef0b99f10
https://github.com/bkjoh
add comma to ValueError messagehttps://github.com/python/cpython/pull/138591/commits/a6aed9356168a32ca5bfebce64420a9642069ca1
a6aed93https://github.com/python/cpython/pull/138591/commits/a6aed9356168a32ca5bfebce64420a9642069ca1
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
September 10, 2025 02:35https://github.com/python/cpython/pull/138591#event-19602828647
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 10, 2025https://github.com/python/cpython/pull/138591#event-19602829119
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
brianschuberthttps://github.com/brianschubert
picnixzhttps://github.com/picnixz
September 10, 2025 02:37https://github.com/python/cpython/pull/138591#event-19602859330
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 10, 2025https://github.com/python/cpython/pull/138591#issuecomment-3273422551
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 10, 2025 https://github.com/python/cpython/pull/138591#pullrequestreview-3204692233
View reviewed changes https://github.com/python/cpython/pull/138591/files/a6aed9356168a32ca5bfebce64420a9642069ca1
Lib/getpass.pyhttps://github.com/python/cpython/pull/138591/files/a6aed9356168a32ca5bfebce64420a9642069ca1#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/getpass.pyhttps://github.com/python/cpython/pull/138591/files/a6aed9356168a32ca5bfebce64420a9642069ca1#diff-3bde66c820a115e5740d481232a0c48331c3856ad4c247a586be98991c08f8cb
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/a6aed9356168a32ca5bfebce64420a9642069ca1#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/a6aed9356168a32ca5bfebce64420a9642069ca1#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/a6aed9356168a32ca5bfebce64420a9642069ca1#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/a6aed9356168a32ca5bfebce64420a9642069ca1#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
September 10, 2025 15:21https://github.com/python/cpython/pull/138591#event-19615809526
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 10, 2025https://github.com/python/cpython/pull/138591#event-19615810417
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 10, 2025https://github.com/python/cpython/pull/138591#event-19622908273
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138591#issuecomment-3279143081
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://discuss.python.org/c/ideas/6https://discuss.python.org/c/ideas/6
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025 https://github.com/python/cpython/pull/138591#pullrequestreview-3209797845
View reviewed changes https://github.com/python/cpython/pull/138591/files/caded776184fec339b3853db5daaf80ae96058da
picnixzhttps://github.com/picnixz
https://github.com/python/cpython/pull/138591#pullrequestreview-3209797845
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/caded776184fec339b3853db5daaf80ae96058da#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/caded776184fec339b3853db5daaf80ae96058da#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/caded776184fec339b3853db5daaf80ae96058da#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
Lib/test/test_getpass.pyhttps://github.com/python/cpython/pull/138591/files/caded776184fec339b3853db5daaf80ae96058da#diff-acd0b3af44a7e1cb5c51d62ab92adeb8fdd3b16539f22703e8773d2f2a8cbf3f
Please reload this pagehttps://github.com/python/cpython/pull/138591
bkjohhttps://github.com/bkjoh
September 11, 2025 08:32https://github.com/python/cpython/pull/138591#commits-pushed-981d49d
https://github.com/bkjoh
https://github.com/picnixz
remove too-verbose commentshttps://github.com/python/cpython/pull/138591/commits/981d49de80c33ab4ef49a567586303c08ae14af0
981d49dhttps://github.com/python/cpython/pull/138591/commits/981d49de80c33ab4ef49a567586303c08ae14af0
https://github.com/bkjoh
https://github.com/picnixz
remove too-verbose commentshttps://github.com/python/cpython/pull/138591/commits/07534ce03f5de1fb2a40e4f39cb254843c55d249
07534cehttps://github.com/python/cpython/pull/138591/commits/07534ce03f5de1fb2a40e4f39cb254843c55d249
https://github.com/bkjoh
https://github.com/picnixz
simplify non-ascii tests using asciihttps://github.com/python/cpython/pull/138591/commits/2203e03db2176dbcf8f47bea87e57363b7bec7a7
2203e03https://github.com/python/cpython/pull/138591/commits/2203e03db2176dbcf8f47bea87e57363b7bec7a7
https://github.com/bkjoh
https://github.com/picnixz
test every non-printable ascii bytehttps://github.com/python/cpython/pull/138591/commits/6485375ce96c2ea2455f9c829fc1f76ca68668c8
6485375https://github.com/python/cpython/pull/138591/commits/6485375ce96c2ea2455f9c829fc1f76ca68668c8
https://github.com/bkjoh
Merge branch 'main' intohttps://github.com/python/cpython/pull/138591/commits/2e7bd339f00400b3e6cefb484b677af9dffb5eb5
gh-138514https://github.com/python/cpython/issues/138514
-fix-getpass-echo-charhttps://github.com/python/cpython/pull/138591/commits/2e7bd339f00400b3e6cefb484b677af9dffb5eb5
2e7bd33https://github.com/python/cpython/pull/138591/commits/2e7bd339f00400b3e6cefb484b677af9dffb5eb5
https://github.com/bkjoh
remove s charactershttps://github.com/python/cpython/pull/138591/commits/3629a53a10776b5357c1778c72f6cf383608301b
3629a53https://github.com/python/cpython/pull/138591/commits/3629a53a10776b5357c1778c72f6cf383608301b
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
picnixzhttps://github.com/picnixz
September 11, 2025 13:04https://github.com/python/cpython/pull/138591#event-19636876068
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 11, 2025https://github.com/python/cpython/pull/138591#issuecomment-3280561129
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://discuss.python.org/c/ideas/6https://discuss.python.org/c/ideas/6
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 11, 2025https://github.com/python/cpython/pull/138591#issuecomment-3280563742
Please reload this pagehttps://github.com/python/cpython/pull/138591
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138591#issuecomment-3280696680
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
Merge branch 'main' intohttps://github.com/python/cpython/pull/138591/commits/e2ba1b7589518bd71b7a8fd9579286234139f8fc
gh-138514https://github.com/python/cpython/issues/138514
-fix-getpass-echo-charhttps://github.com/python/cpython/pull/138591/commits/e2ba1b7589518bd71b7a8fd9579286234139f8fc
e2ba1b7https://github.com/python/cpython/pull/138591/commits/e2ba1b7589518bd71b7a8fd9579286234139f8fc
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138591#issuecomment-3281106844
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 11, 2025https://github.com/python/cpython/pull/138591#issuecomment-3281579648
Please reload this pagehttps://github.com/python/cpython/pull/138591
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 11, 2025https://github.com/python/cpython/pull/138591#issuecomment-3281598205
Please reload this pagehttps://github.com/python/cpython/pull/138591
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
bkjohhttps://github.com/bkjoh
Sep 15, 2025https://github.com/python/cpython/pull/138591#issuecomment-3292737609
@picnixzhttps://github.com/picnixz
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 15, 2025https://github.com/python/cpython/pull/138591#issuecomment-3292863086
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 16, 2025 https://github.com/python/cpython/pull/138591#pullrequestreview-3230227835
View reviewed changes https://github.com/python/cpython/pull/138591/files/e2ba1b7589518bd71b7a8fd9579286234139f8fc
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Sep 16, 2025https://github.com/python/cpython/pull/138591#event-19728038941
https://github.com/picnixz
picnixzhttps://github.com/picnixz
ab6893ahttps://github.com/python/cpython/commit/ab6893ab5c04fecf71c94f7d65527df124155df5
Sep 16, 2025https://github.com/python/cpython/pull/138591#event-19728191596
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 16, 2025https://github.com/python/cpython/pull/138591#event-19728193174
https://github.com/picnixz
picnixzhttps://github.com/picnixz
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Sep 16, 2025https://github.com/python/cpython/pull/138591#event-19728195909
https://github.com/apps/miss-islington-app
miss-islington-apphttps://github.com/apps/miss-islington-app
Sep 16, 2025https://github.com/python/cpython/pull/138591#issuecomment-3299005660
@picnixzhttps://github.com/picnixz
Please reload this pagehttps://github.com/python/cpython/pull/138591
miss-islingtonhttps://github.com/miss-islington
Sep 16, 2025 https://github.com/python/cpython/pull/138591#ref-commit-b55324a
https://github.com/bkjoh
https://github.com/picnixz
https://github.com/brianschubert
https://github.com/miss-islington
pythongh-138514https://github.com/python/cpython/issues/138514
: getpass: restricthttps://github.com/miss-islington/cpython/commit/b55324a54656fa5650abe1153096ef67091006d6
echo_charhttps://github.com/miss-islington/cpython/commit/b55324a54656fa5650abe1153096ef67091006d6
to a single ASCII char…https://github.com/miss-islington/cpython/commit/b55324a54656fa5650abe1153096ef67091006d6
b55324ahttps://github.com/miss-islington/cpython/commit/b55324a54656fa5650abe1153096ef67091006d6
pythonGH-138591https://github.com/python/cpython/pull/138591
bf8bbe9https://github.com/miss-islington/cpython/commit/bf8bbe9a813dd9fc2dd14be06df172b7d26ca1af
ab6893ahttps://github.com/miss-islington/cpython/commit/ab6893ab5c04fecf71c94f7d65527df124155df5
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 16, 2025https://github.com/python/cpython/pull/138591#issuecomment-3299006686
GH-138988https://github.com/python/cpython/pull/138988
3.14 branchhttps://github.com/python/cpython/tree/3.14
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
needs backport to 3.14 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.14%22
Sep 16, 2025https://github.com/python/cpython/pull/138591#event-19728202886
hugovkhttps://github.com/hugovk
Sep 17, 2025 https://github.com/python/cpython/pull/138591#ref-commit-37f8a63
https://github.com/miss-islington
https://github.com/bkjoh
https://github.com/picnixz
https://github.com/brianschubert
[3.14]https://github.com/python/cpython/commit/37f8a63e39ac8aaaa5c51032de19d2b6d81be162
gh-138514https://github.com/python/cpython/issues/138514
: getpass: restricthttps://github.com/python/cpython/commit/37f8a63e39ac8aaaa5c51032de19d2b6d81be162
echo_charhttps://github.com/python/cpython/commit/37f8a63e39ac8aaaa5c51032de19d2b6d81be162
to a single ASCII cha…https://github.com/python/cpython/commit/37f8a63e39ac8aaaa5c51032de19d2b6d81be162
37f8a63https://github.com/python/cpython/commit/37f8a63e39ac8aaaa5c51032de19d2b6d81be162
GH-138591https://github.com/python/cpython/pull/138591
#138988https://github.com/python/cpython/pull/138988
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138591
https://github.com/picnixz
picnixz https://github.com/picnixz
https://github.com/python/cpython/pull/138591/files/e2ba1b7589518bd71b7a8fd9579286234139f8fc
https://github.com/brianschubert
brianschubert https://github.com/brianschubert
getpass's echo_char should be restricted to a single ASCII character https://github.com/python/cpython/issues/138514
Please reload this pagehttps://github.com/python/cpython/pull/138591
https://github.com/bkjoh
https://github.com/picnixz
https://github.com/brianschubert
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.