René's URL Explorer Experiment


Title: gh-138479: Ensure that `__typing_subst__` returns a tuple by ZeroIntensity · Pull Request #138482 · python/cpython · GitHub

Open Graph Title: gh-138479: Ensure that `__typing_subst__` returns a tuple by ZeroIntensity · Pull Request #138482 · python/cpython

X Title: gh-138479: Ensure that `__typing_subst__` returns a tuple by ZeroIntensity · Pull Request #138482 · python/cpython

Description: Raise an exception if __typing_subst__ returns a non-tuple object. The test case is a little messy because it's based on fuzzer-generated code, so I can come up with my own repro if people aren't happy with using it. Issue: gh-138479

Open Graph Description: Raise an exception if __typing_subst__ returns a non-tuple object. The test case is a little messy because it's based on fuzzer-generated code, so I can come up with my own repro if people aren...

X Description: Raise an exception if __typing_subst__ returns a non-tuple object. The test case is a little messy because it's based on fuzzer-generated code, so I can come up with my own repro if people ...

Opengraph URL: https://github.com/python/cpython/pull/138482

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:80e16412-f12e-1349-0db8-a0b9c5b110a5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE6E:23DB5F:15DCA51:1B71224:6B025D82
html-safe-noncea10529405afa1fbfeae083a73bf4422087a7ba64fbc663d174ab3077a97fe8bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTZFOjIzREI1RjoxNURDQTUxOjFCNzEyMjQ6NkIwMjVEODIiLCJ2aXNpdG9yX2lkIjoiMzY0NDgxNTc1MTQ4NDk1NjAzNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacead5e4e7d605ce213934ef1bbe2801c635b4d1be1f8b59d25ba28334386764e4
hovercard-subject-tagpull_request:2797243640
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/138482/files
twitter:imagehttps://avatars.githubusercontent.com/u/49501366?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/49501366?s=400&v=4
og:image:altRaise an exception if __typing_subst__ returns a non-tuple object. The test case is a little messy because it's based on fuzzer-generated code, so I can come up with my own repro if people aren...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138482/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138482%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138482%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138482/files
Reloadhttps://github.com/python/cpython/pull/138482/files
Reloadhttps://github.com/python/cpython/pull/138482/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ZeroIntensityhttps://github.com/ZeroIntensity
python:mainhttps://github.com/python/cpython/tree/main
ZeroIntensity:gh-138479-unpack-crashhttps://github.com/ZeroIntensity/cpython/tree/gh-138479-unpack-crash
Conversation 27 https://github.com/python/cpython/pull/138482
Commits 11 https://github.com/python/cpython/pull/138482/commits
Checks 0 https://github.com/python/cpython/pull/138482/checks
Files changed https://github.com/python/cpython/pull/138482/files
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
gh-138479: Ensure that __typing_subst__ returns a tuple https://github.com/python/cpython/pull/138482/files#top
Show all changes 11 commits https://github.com/python/cpython/pull/138482/files
9458120 Validate that the result is a tuple. ZeroIntensity Sep 3, 2025 https://github.com/python/cpython/pull/138482/commits/9458120f62c97e72314ce3a308a579d88be3823b
c70e82e Add a simple test case. ZeroIntensity Sep 3, 2025 https://github.com/python/cpython/pull/138482/commits/c70e82e215ee17bcd54b535e9095e956c6e9b3e0
cb4351b Add blurb. ZeroIntensity Sep 3, 2025 https://github.com/python/cpython/pull/138482/commits/cb4351b5e21dd4d622e92d02f62228b281ecb261
c50846b Fix a reference leak. ZeroIntensity Sep 3, 2025 https://github.com/python/cpython/pull/138482/commits/c50846b66070cf44f4a83ab97d10c99dcbc71111
04d509c Fix use-after-decref. ZeroIntensity Sep 4, 2025 https://github.com/python/cpython/pull/138482/commits/04d509c583d0ad0e6639401c6a66938b16a21708
761812d Fix existing refleak. ZeroIntensity Sep 5, 2025 https://github.com/python/cpython/pull/138482/commits/761812d721b2efad340769dce8bacbb71d32cac5
46b6fa3 Update Lib/test/test_typing.py ZeroIntensity Sep 6, 2025 https://github.com/python/cpython/pull/138482/commits/46b6fa3e2f73011fd4787309d15248a17a02eef6
4445b5a Improve error message. ZeroIntensity Sep 6, 2025 https://github.com/python/cpython/pull/138482/commits/4445b5a7304b55df72a5583ba2e5f79473e1c99d
d80223a Use assertRaisesRegex. ZeroIntensity Sep 7, 2025 https://github.com/python/cpython/pull/138482/commits/d80223a11393e9630c47b13bd8d05d41df1511c8
b8ced40 Add an assertion instead of a comment for newargs. ZeroIntensity Sep 9, 2025 https://github.com/python/cpython/pull/138482/commits/b8ced40742ed033b45d44f617c583a5de4db947f
ff5078e Add a comment. ZeroIntensity Sep 9, 2025 https://github.com/python/cpython/pull/138482/commits/ff5078e9197c768e0fbf6bb2158191d8d28b5e97
Clear filters https://github.com/python/cpython/pull/138482/files
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
test_typing.py https://github.com/python/cpython/pull/138482/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
2025-09-03-17-00-30.gh-issue-138479.qUxgWs.rst https://github.com/python/cpython/pull/138482/files#diff-05ceb010b75566878477969648569b9892e2f59c4d1c9d72ceac516e808f7eb4
genericaliasobject.c https://github.com/python/cpython/pull/138482/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L627
Lib/test/test_typing.pyhttps://github.com/python/cpython/pull/138482/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
View file https://github.com/ZeroIntensity/cpython/blob/ff5078e9197c768e0fbf6bb2158191d8d28b5e97/Lib/test/test_typing.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138482/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138482/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
https://github.com/python/cpython/pull/138482/files#diff-04d29c98076c2d6bb75921ea9becb26a862544d39b71db87b6e354c759b9305d
Misc/NEWS.d/next/Core_and_Builtins/2025-09-03-17-00-30.gh-issue-138479.qUxgWs.rsthttps://github.com/python/cpython/pull/138482/files#diff-05ceb010b75566878477969648569b9892e2f59c4d1c9d72ceac516e808f7eb4
View file https://github.com/ZeroIntensity/cpython/blob/ff5078e9197c768e0fbf6bb2158191d8d28b5e97/Misc/NEWS.d/next/Core_and_Builtins/2025-09-03-17-00-30.gh-issue-138479.qUxgWs.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138482/{{ revealButtonHref }}
Objects/genericaliasobject.chttps://github.com/python/cpython/pull/138482/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
View file https://github.com/ZeroIntensity/cpython/blob/ff5078e9197c768e0fbf6bb2158191d8d28b5e97/Objects/genericaliasobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138482/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138482/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
sobolevnhttps://github.com/sobolevn
Sep 3, 2025https://github.com/python/cpython/pull/138482/files#r2320326182
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 4, 2025https://github.com/python/cpython/pull/138482/files#r2320513961
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
JelleZijlstrahttps://github.com/JelleZijlstra
Sep 5, 2025https://github.com/python/cpython/pull/138482/files#r2326000953
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 6, 2025https://github.com/python/cpython/pull/138482/files#r2326340876
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
JelleZijlstrahttps://github.com/JelleZijlstra
Sep 5, 2025https://github.com/python/cpython/pull/138482/files#r2326002937
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 5, 2025https://github.com/python/cpython/pull/138482/files#r2326122754
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
JelleZijlstrahttps://github.com/JelleZijlstra
Sep 5, 2025https://github.com/python/cpython/pull/138482/files#r2326128424
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
ZeroIntensityhttps://github.com/ZeroIntensity
Sep 5, 2025https://github.com/python/cpython/pull/138482/files#r2326200046
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/138482/files
https://github.com/python/cpython/pull/138482/files#diff-828d12085a29364c67442b193bb62906e3469fbe21367499fd62817f98190014
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.