René's URL Explorer Experiment


Title: gh-116946: Revert GC protocol for immutable empty heap types (GH-138266, GH-138288, GH-138289) by picnixz · Pull Request #138338 · python/cpython · GitHub

Open Graph Title: gh-116946: Revert GC protocol for immutable empty heap types (GH-138266, GH-138288, GH-138289) by picnixz · Pull Request #138338 · python/cpython

X Title: gh-116946: Revert GC protocol for immutable empty heap types (GH-138266, GH-138288, GH-138289) by picnixz · Pull Request #138338 · python/cpython

Description: This reverts commits 9be91f6, 3ea16f9 and 6f1dd95. I mistakenly assumed that immutable empty types also needed to support the GC protocol but this is not the case. Issue: Heap types implemented i...

Open Graph Description: This reverts commits 9be91f6, 3ea16f9 and 6f1dd95. I mistakenly assumed that immutable empty types also needed to support the GC protocol but this is not the case. Issue: Heap types implemented i...

X Description: This reverts commits 9be91f6, 3ea16f9 and 6f1dd95. I mistakenly assumed that immutable empty types also needed to support the GC protocol but this is not the case. Issue: Heap types implemented i...

Opengraph URL: https://github.com/python/cpython/pull/138338

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3f4b1b0f-0f41-cb9d-44b9-17bbdd636998
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCED0:FC316:C1F01D:1057282:696AC041
html-safe-noncebca9c2b8c04409fff67ad3b51e283b2a34236f30540261dd180bb9b2270f9751
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRUQwOkZDMzE2OkMxRjAxRDoxMDU3MjgyOjY5NkFDMDQxIiwidmlzaXRvcl9pZCI6IjUxOTg0Nzg5NDc2OTAxMzU2MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac703e84f66153efc48290884956c5ddab92c46571e57c705d284761f875054429
hovercard-subject-tagpull_request:2789691216
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/138338/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/bb9a783624a986e138fa18eb0b928c5f35566eb5557e7577e613b7c0d36f3177/python/cpython/pull/138338
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bb9a783624a986e138fa18eb0b928c5f35566eb5557e7577e613b7c0d36f3177/python/cpython/pull/138338
og:image:altThis reverts commits 9be91f6, 3ea16f9 and 6f1dd95. I mistakenly assumed that immutable empty types also needed to support the GC protocol but this is not the case. Issue: Heap types implemented i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138338#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138338
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138338
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138338
Reloadhttps://github.com/python/cpython/pull/138338
Reloadhttps://github.com/python/cpython/pull/138338
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138338
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/138338
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/138338#issue-comment-box
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/315/gc/revert-for-immutable-empty-typeshttps://github.com/picnixz/cpython/tree/fix/315/gc/revert-for-immutable-empty-types
gh-116946: Revert GC protocol for immutable empty heap types (GH-138266, GH-138288, GH-138289) https://github.com/python/cpython/pull/138338#top
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/315/gc/revert-for-immutable-empty-typeshttps://github.com/picnixz/cpython/tree/fix/315/gc/revert-for-immutable-empty-types
Conversation 1 https://github.com/python/cpython/pull/138338
Commits 3 https://github.com/python/cpython/pull/138338/commits
Checks 45 https://github.com/python/cpython/pull/138338/checks
Files changed 3 https://github.com/python/cpython/pull/138338/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 1, 2025https://github.com/python/cpython/pull/138338#issue-3372539995
Please reload this pagehttps://github.com/python/cpython/pull/138338
9be91f6https://github.com/python/cpython/commit/9be91f6a20ed2fd9b491c3e779dc45c7392f60ca
3ea16f9https://github.com/python/cpython/commit/3ea16f990f81e1e3b2892f1dfd213937b1df2a68
6f1dd95https://github.com/python/cpython/commit/6f1dd9551a69c8c76d066a04e94db6dbc6c7597c
Heap types implemented in C must have Py_TPFLAGS_HAVE_GC and implement tp_traverse #116946https://github.com/python/cpython/issues/116946
Please reload this pagehttps://github.com/python/cpython/pull/138338
picnixzhttps://github.com/picnixz
September 1, 2025 14:38https://github.com/python/cpython/pull/138338#commits-pushed-131bab6
https://github.com/picnixz
Revert "https://github.com/python/cpython/pull/138338/commits/131bab6d057b75de9f092075b564defd007c2dbe
pythongh-116946https://github.com/python/cpython/issues/116946
: fully implement GC protocol forhttps://github.com/python/cpython/pull/138338/commits/131bab6d057b75de9f092075b564defd007c2dbe
bz2https://github.com/python/cpython/pull/138338/commits/131bab6d057b75de9f092075b564defd007c2dbe
objects (https://github.com/python/cpython/pull/138338/commits/131bab6d057b75de9f092075b564defd007c2dbe
131bab6https://github.com/python/cpython/pull/138338/commits/131bab6d057b75de9f092075b564defd007c2dbe
python#138266https://github.com/python/cpython/pull/138266
9be91f6https://github.com/picnixz/cpython/commit/9be91f6a20ed2fd9b491c3e779dc45c7392f60ca
https://github.com/picnixz
Revert "https://github.com/python/cpython/pull/138338/commits/fa86d1d9fb9bb316a266f6e4fc76f6d75486fa33
pythongh-116946https://github.com/python/cpython/issues/116946
: fully implement GC protocol forhttps://github.com/python/cpython/pull/138338/commits/fa86d1d9fb9bb316a266f6e4fc76f6d75486fa33
lzmahttps://github.com/python/cpython/pull/138338/commits/fa86d1d9fb9bb316a266f6e4fc76f6d75486fa33
objec…https://github.com/python/cpython/pull/138338/commits/fa86d1d9fb9bb316a266f6e4fc76f6d75486fa33
fa86d1dhttps://github.com/python/cpython/pull/138338/commits/fa86d1d9fb9bb316a266f6e4fc76f6d75486fa33
python#138288https://github.com/python/cpython/pull/138288
3ea16f9https://github.com/picnixz/cpython/commit/3ea16f990f81e1e3b2892f1dfd213937b1df2a68
https://github.com/picnixz
picnixzhttps://github.com/picnixz
kumaraditya303https://github.com/kumaraditya303
September 1, 2025 12:41https://github.com/python/cpython/pull/138338#event-19441530575
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Sep 1, 2025https://github.com/python/cpython/pull/138338#event-19441531085
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 1, 2025https://github.com/python/cpython/pull/138338#event-19441533187
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Sep 1, 2025 https://github.com/python/cpython/pull/138338#ref-issue-2191475400
Heap types implemented in C must have Py_TPFLAGS_HAVE_GC and implement tp_traverse #116946 https://github.com/python/cpython/issues/116946
https://github.com/picnixz
Revert "https://github.com/python/cpython/pull/138338/commits/dc8f5a037623ef54228980a09d558923137d4ece
pythongh-116946https://github.com/python/cpython/issues/116946
: fully implement GC protocol forhttps://github.com/python/cpython/pull/138338/commits/dc8f5a037623ef54228980a09d558923137d4ece
_hashlibhttps://github.com/python/cpython/pull/138338/commits/dc8f5a037623ef54228980a09d558923137d4ece
o…https://github.com/python/cpython/pull/138338/commits/dc8f5a037623ef54228980a09d558923137d4ece
dc8f5a0https://github.com/python/cpython/pull/138338/commits/dc8f5a037623ef54228980a09d558923137d4ece
python#138289https://github.com/python/cpython/pull/138289
6f1dd95https://github.com/picnixz/cpython/commit/6f1dd9551a69c8c76d066a04e94db6dbc6c7597c
https://github.com/picnixz
picnixzhttps://github.com/picnixz
gpsheadhttps://github.com/gpshead
code ownerhttps://github.com/python/cpython/blob/2a54acf3c3d9f388c3d878a17ea804a801affca9/.github/CODEOWNERS#L375
September 1, 2025 12:47https://github.com/python/cpython/pull/138338#event-19441667076
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 1, 2025https://github.com/python/cpython/pull/138338#event-19441678422
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 1, 2025https://github.com/python/cpython/pull/138338#event-19441679512
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 1, 2025 https://github.com/python/cpython/pull/138338#ref-pullrequest-3372999402
gh-138342: Use a common utility for visiting an object's type #138343 https://github.com/python/cpython/pull/138343
https://github.com/picnixz
picnixzhttps://github.com/picnixz
ZeroIntensityhttps://github.com/ZeroIntensity
September 1, 2025 15:35https://github.com/python/cpython/pull/138338#event-19444810165
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
Sep 1, 2025 https://github.com/python/cpython/pull/138338#pullrequestreview-3174084682
View reviewed changes https://github.com/python/cpython/pull/138338/files/dc8f5a037623ef54228980a09d558923137d4ece
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 1, 2025https://github.com/python/cpython/pull/138338#event-19444928105
https://github.com/kumaraditya303
kumaraditya303https://github.com/kumaraditya303
c9b252chttps://github.com/python/cpython/commit/c9b252c2c007cd2cec3b33fc7476ae85dede8e42
Sep 1, 2025https://github.com/python/cpython/pull/138338#event-19444960866
Please reload this pagehttps://github.com/python/cpython/pull/138338
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 1, 2025https://github.com/python/cpython/pull/138338#event-19444961502
https://github.com/picnixz
picnixzhttps://github.com/picnixz
September 1, 2025 15:49https://github.com/python/cpython/pull/138338#event-19445022147
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Sep 1, 2025https://github.com/python/cpython/pull/138338#issuecomment-3242798108
Please reload this pagehttps://github.com/python/cpython/pull/138338
lkollarhttps://github.com/lkollar
Sep 9, 2025 https://github.com/python/cpython/pull/138338#ref-commit-a6c052e
https://github.com/picnixz
https://github.com/lkollar
pythongh-116946https://github.com/python/cpython/issues/116946
: Revert GC protocol for immutable empty heap types (https://github.com/lkollar/cpython/commit/a6c052e0fbae21a17e55ca78bb5175fd14425b37
p…https://github.com/python/cpython/pull/138266
a6c052ehttps://github.com/lkollar/cpython/commit/a6c052e0fbae21a17e55ca78bb5175fd14425b37
…ythonGH-138266https://github.com/python/cpython/pull/138266
pythonGH-138288https://github.com/python/cpython/pull/138288
pythonGH-138289https://github.com/python/cpython/pull/138289
python#138338https://github.com/python/cpython/pull/138338
pythongh-116946https://github.com/python/cpython/issues/116946
python#138266https://github.com/python/cpython/pull/138266
9be91f6https://github.com/lkollar/cpython/commit/9be91f6a20ed2fd9b491c3e779dc45c7392f60ca
pythongh-116946https://github.com/python/cpython/issues/116946
python#138288https://github.com/python/cpython/pull/138288
3ea16f9https://github.com/lkollar/cpython/commit/3ea16f990f81e1e3b2892f1dfd213937b1df2a68
pythongh-116946https://github.com/python/cpython/issues/116946
python#138289https://github.com/python/cpython/pull/138289
6f1dd95https://github.com/lkollar/cpython/commit/6f1dd9551a69c8c76d066a04e94db6dbc6c7597c
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138338
https://github.com/kumaraditya303
kumaraditya303 https://github.com/kumaraditya303
https://github.com/python/cpython/pull/138338/files/dc8f5a037623ef54228980a09d558923137d4ece
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/ZeroIntensity
ZeroIntensity https://github.com/ZeroIntensity
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/138338
https://github.com/picnixz
https://github.com/kumaraditya303
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.