René's URL Explorer Experiment


Title: gh-116946: fully implement GC protocol for `bz2` objects by picnixz · Pull Request #138266 · python/cpython · GitHub

Open Graph Title: gh-116946: fully implement GC protocol for `bz2` objects by picnixz · Pull Request #138266 · python/cpython

X Title: gh-116946: fully implement GC protocol for `bz2` objects by picnixz · Pull Request #138266 · python/cpython

Description: AFAIU, tp_traverse will not be called if Py_TPFLAGS_HAVE_GC is not specified. Quoting the specs: Instances of heap-allocated types hold a reference to their type. Their traversal function must therefore either visit Py_TYPE(self), or delegate this responsibility by calling tp_traverse of another heap-allocated type (such as a heap-allocated superclass). If they do not, the type object may not be garbage-collected. As such, I believe that this is the correct fix (that is, we need tp_traverse to be called). cc @vstinner Issue: gh-116946

Open Graph Description: AFAIU, tp_traverse will not be called if Py_TPFLAGS_HAVE_GC is not specified. Quoting the specs: Instances of heap-allocated types hold a reference to their type. Their traversal function must the...

X Description: AFAIU, tp_traverse will not be called if Py_TPFLAGS_HAVE_GC is not specified. Quoting the specs: Instances of heap-allocated types hold a reference to their type. Their traversal function must the...

Opengraph URL: https://github.com/python/cpython/pull/138266

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:62aad7b3-7875-8937-4c5a-137309d9191d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD13C:1E1D6F:40F5AB:5A7B3B:696A7553
html-safe-nonce3ba9fff8a693a7b0c9b07ed26f1f76df251192b729628f07a459b317c62297ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTNDOjFFMUQ2Rjo0MEY1QUI6NUE3QjNCOjY5NkE3NTUzIiwidmlzaXRvcl9pZCI6IjI5MjM2NTkyMjE2OTQ4MzgwOTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8f801ae665a6b8b17959275d9aad317d53ad911b4e2d2ea30204aadb69466a61
hovercard-subject-tagpull_request:2786835278
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/138266/files
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altAFAIU, tp_traverse will not be called if Py_TPFLAGS_HAVE_GC is not specified. Quoting the specs: Instances of heap-allocated types hold a reference to their type. Their traversal function must the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecfa223d62d272274e0b68350b4bd7741f3ca7498b8c4b8b1bc1e6deabbdbc09d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6a0b6893c221f98f607598e939299fdf5763435d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138266/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138266%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138266%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138266/files
Reloadhttps://github.com/python/cpython/pull/138266/files
Reloadhttps://github.com/python/cpython/pull/138266/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138266/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/138266/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:fix/gc/bz2-heap-types-116946https://github.com/picnixz/cpython/tree/fix/gc/bz2-heap-types-116946
Conversation 37 https://github.com/python/cpython/pull/138266
Commits 6 https://github.com/python/cpython/pull/138266/commits
Checks 57 https://github.com/python/cpython/pull/138266/checks
Files changed https://github.com/python/cpython/pull/138266/files
Please reload this pagehttps://github.com/python/cpython/pull/138266/files
gh-116946: fully implement GC protocol for bz2 objects https://github.com/python/cpython/pull/138266/files#top
Show all changes 6 commits https://github.com/python/cpython/pull/138266/files
a8e8501 fully implement GC protocol for `bz2` objects picnixz Aug 30, 2025 https://github.com/python/cpython/pull/138266/commits/a8e850147d67a01c2c94db4c79f260d583b0bdb1
c9d3ab6 remove redundant casts picnixz Aug 31, 2025 https://github.com/python/cpython/pull/138266/commits/c9d3ab625007062ec49bfe150a621ca0d8511f7a
81f77b6 define fields post zero-initialization when needed picnixz Aug 31, 2025 https://github.com/python/cpython/pull/138266/commits/81f77b68143132e12122fa8ddf408d7f71407eca
2b50446 use `PyObject_GC_Del` for clarity picnixz Aug 31, 2025 https://github.com/python/cpython/pull/138266/commits/2b50446ad7559bd44732b91f0032ce8b517d2319
a9b6096 reduce diff for 3.14 and later picnixz Aug 31, 2025 https://github.com/python/cpython/pull/138266/commits/a9b609685e2b0ecb94661c52ea5c7ee4ffec4edf
91a3e21 smash diff picnixz Aug 31, 2025 https://github.com/python/cpython/pull/138266/commits/91a3e215e1c7a0067fd434df7af24640cc9843a4
Clear filters https://github.com/python/cpython/pull/138266/files
Please reload this pagehttps://github.com/python/cpython/pull/138266/files
Please reload this pagehttps://github.com/python/cpython/pull/138266/files
Modules/_bz2module.chttps://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
View file https://github.com/picnixz/cpython/blob/91a3e215e1c7a0067fd434df7af24640cc9843a4/Modules/_bz2module.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138266/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
https://github.com/python/cpython/pull/138266/files#diff-6b7a70749b23278bf36e74a08f378b3645598912d7fa8c33f45d34dc95b7a6b7
Please reload this pagehttps://github.com/python/cpython/pull/138266/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.