René's URL Explorer Experiment

Title: gh-116738: Make cProfile module thread-safe by yoney · Pull Request #138229 · python/cpython · GitHub

Open Graph Title: gh-116738: Make cProfile module thread-safe by yoney · Pull Request #138229 · python/cpython

X Title: gh-116738: Make cProfile module thread-safe by yoney · Pull Request #138229 · python/cpython

Description: This change uses critical sections to make cProfile (_lsprof) thread-safe when the GIL is disabled. It does this by applying the @critical_section clinic directive to ProfilerObject. Protecting ProfilerObject prevents crashes, and the thread sanitizer does not report errors for the new FT test. However, the stats still show incorrect recursive call information. ncalls tottime percall cumtime percall filename:lineno(function) 10000/538 0.085 0.000 0.186 0.000 {method 'insert' of 'list' objects} This happens because of limitations in the cProfile module, and these issues are not directly related to the FT Python build. By adjusting sys.setswitchinterval(), you can see similar incorrect recursive call reports even in a non-FT Python build. This is a quick fix to prevent crashes. It is also a request for comments on whether we should make bigger changes to the cProfile module to handle multithreading better, such as collecting profile data per thread. cc: @mpage, @colesbury, @Yhg1s Issue: gh-116738

Open Graph Description: This change uses critical sections to make cProfile (_lsprof) thread-safe when the GIL is disabled. It does this by applying the @critical_section clinic directive to ProfilerObject. Protecting Pro...

X Description: This change uses critical sections to make cProfile (_lsprof) thread-safe when the GIL is disabled. It does this by applying the @critical_section clinic directive to ProfilerObject. Protecting Pro...

Opengraph URL: https://github.com/python/cpython/pull/138229

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width