René's URL Explorer Experiment


Title: gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac by yihong0618 · Pull Request #138089 · python/cpython · GitHub

Open Graph Title: gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac by yihong0618 · Pull Request #138089 · python/cpython

X Title: gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac by yihong0618 · Pull Request #138089 · python/cpython

Description: for mac if environ is valid and it will retrigger all of it so I checked the code base in repr the os is from init so make it in__init__ is better and can avoid and that is not enough, we also need fix it the same way in _can_colorize theme cc @pablogsal in my env it fixed the issue, and I wonder it maybe a litter faster Issue: gh-128636

Open Graph Description: for mac if environ is valid and it will retrigger all of it so I checked the code base in repr the os is from init so make it in__init__ is better and can avoid and that is not enough, we also need...

X Description: for mac if environ is valid and it will retrigger all of it so I checked the code base in repr the os is from init so make it in__init__ is better and can avoid and that is not enough, we also need...

Opengraph URL: https://github.com/python/cpython/pull/138089

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:46a2cf71-e353-eb58-6199-2b3d2cb6a3c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90F8:237DC:2C13B5F:3FB20FA:6A55199F
html-safe-noncee039a1b837c28d96e548a953c6eaf75574c93d02dae354c02c51745d66c87999
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEY4OjIzN0RDOjJDMTNCNUY6M0ZCMjBGQTo2QTU1MTk5RiIsInZpc2l0b3JfaWQiOiIxNzA5NTkyNjM0MjM3MTk2NzAzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac19c2df76744296f4b472aa33f9872f7134f81a60ef7d67064226c03fcd60c789
hovercard-subject-tagpull_request:2768808291
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/138089/files
twitter:imagehttps://avatars.githubusercontent.com/u/15976103?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15976103?s=400&v=4
og:image:altfor mac if environ is valid and it will retrigger all of it so I checked the code base in repr the os is from init so make it in__init__ is better and can avoid and that is not enough, we also need...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None682d273eacb2ac51680c6eb9c0b270f029f7ce74c32090f319083c34497e28a5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b6d37c6470adadff4194742daaab9a817cc4980
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/138089/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138089%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F138089%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/138089/files
Reloadhttps://github.com/python/cpython/pull/138089/files
Reloadhttps://github.com/python/cpython/pull/138089/files
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:mainhttps://github.com/python/cpython/tree/main
Conversation 57 https://github.com/python/cpython/pull/138089
Commits 16 https://github.com/python/cpython/pull/138089/commits
Checks 59 https://github.com/python/cpython/pull/138089/checks
Files changed https://github.com/python/cpython/pull/138089/files
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
gh-128636: Fix crash in PyREPL when os.environ is overwritten with an invalid value for mac https://github.com/python/cpython/pull/138089/files#top
Show all changes 16 commits https://github.com/python/cpython/pull/138089/files
1b8a228 fix: close issue #128636 for mac make is_mac at init yihong0618 Aug 23, 2025 https://github.com/python/cpython/pull/138089/commits/1b8a228730ad129f75f527fde167bacda2467224
ae9d55f fix: mypy check issue yihong0618 Aug 23, 2025 https://github.com/python/cpython/pull/138089/commits/ae9d55fa77cf34389a8e4a120e63baf7477683c9
b838c04 fix: delete copilot tab useless comments yihong0618 Aug 23, 2025 https://github.com/python/cpython/pull/138089/commits/b838c04057987850cba90b9298d78a04d375c9dc
738d41e fix: address comments yihong0618 Aug 23, 2025 https://github.com/python/cpython/pull/138089/commits/738d41e928b4352281948d8429b34e893af99e2e
a0a5cf3 fix: add tests for the change yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/a0a5cf32dd6d2806cc61aaabaa540616221e6c90
2e9faf7 fix: test is wrong yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/2e9faf78d7547432e0ec23a0237c5e164bc8c09e
3a25033 Merge branch 'main' into hy/close_issue_128636_for_mac yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/3a25033a1edcfa5c2305285326e8e7ec27b5d4a7
c7cbd22 fix: address review comments yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/c7cbd228077ce29dc58b39a308a55fe21037223b
53aa617 Merge branch 'hy/close_issue_128636_for_mac' of https://github.com/yi… yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/53aa6173931f72afd105c49b9d8ace77b44ccf5e
02e8f9d fix: address comments better test for it yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/02e8f9d81e46229b913aae5c083fbf2150b8761c
e4acbd0 fix: better way for already colorized yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/e4acbd0af3c9668da4443b4279e5ddcbf44aa7a2
aa37996 fix: mypy check yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/aa379965b6b6175ddca286f6ff0f03a97ba5e04c
72867e0 fix: useless code check yihong0618 Aug 24, 2025 https://github.com/python/cpython/pull/138089/commits/72867e03725d237e9e719d7007f86c44877e5699
fe34228 fix: address commnets better way with safe_get yihong0618 Aug 25, 2025 https://github.com/python/cpython/pull/138089/commits/fe34228d498a22e8f310df7fe0dfbbdf66a93cec
3177b0a fix: address comments again yihong0618 Aug 25, 2025 https://github.com/python/cpython/pull/138089/commits/3177b0aaa21f863427aee855bb2c78e26b449820
5b6c7b3 fix: add news for it yihong0618 Sep 10, 2025 https://github.com/python/cpython/pull/138089/commits/5b6c7b3d943ac8ca5a7d7bc87fcbbb393eae251a
Clear filters https://github.com/python/cpython/pull/138089/files
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
_colorize.py https://github.com/python/cpython/pull/138089/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
unix_console.py https://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
__init__.py https://github.com/python/cpython/pull/138089/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
test_unix_console.py https://github.com/python/cpython/pull/138089/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
2025-09-10-10-02-59.gh-issue-128636.ldRKGZ.rst https://github.com/python/cpython/pull/138089/files#diff-ecb81f513b5996873ef6ebf90b7c67f6276a3bf1472b80dd699386631e29994a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L416
Lib/_colorize.pyhttps://github.com/python/cpython/pull/138089/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
View file https://github.com/python/cpython/blob/5b6c7b3d943ac8ca5a7d7bc87fcbbb393eae251a/Lib/_colorize.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138089/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
https://github.com/python/cpython/pull/138089/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
https://github.com/python/cpython/pull/138089/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
https://github.com/python/cpython/pull/138089/files#diff-9df1113be57dfbda10f44550069c7ad7d9c9ebec3e63ee5261897c6d5e30cf17
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L561
Lib/_pyrepl/unix_console.pyhttps://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
View file https://github.com/python/cpython/blob/5b6c7b3d943ac8ca5a7d7bc87fcbbb393eae251a/Lib/_pyrepl/unix_console.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
https://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
https://github.com/python/cpython/pull/138089/files#diff-0e46521e64c67a83699619343508f4e57968fb450c9075139d47786e1ed89cb1
Lib/test/support/__init__.pyhttps://github.com/python/cpython/pull/138089/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
View file https://github.com/python/cpython/blob/5b6c7b3d943ac8ca5a7d7bc87fcbbb393eae251a/Lib/test/support/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138089/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/pull/138089/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L562
Lib/test/test_pyrepl/test_unix_console.pyhttps://github.com/python/cpython/pull/138089/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
View file https://github.com/python/cpython/blob/5b6c7b3d943ac8ca5a7d7bc87fcbbb393eae251a/Lib/test/test_pyrepl/test_unix_console.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138089/{{ revealButtonHref }}
https://github.com/python/cpython/pull/138089/files#diff-bd56b95d174a8939e71984be3453d3a41315d3fdab37649a87f5c79703f9d304
Misc/NEWS.d/next/Library/2025-09-10-10-02-59.gh-issue-128636.ldRKGZ.rsthttps://github.com/python/cpython/pull/138089/files#diff-ecb81f513b5996873ef6ebf90b7c67f6276a3bf1472b80dd699386631e29994a
View file https://github.com/python/cpython/blob/5b6c7b3d943ac8ca5a7d7bc87fcbbb393eae251a/Misc/NEWS.d/next/Library/2025-09-10-10-02-59.gh-issue-128636.ldRKGZ.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/138089/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/138089/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.