René's URL Explorer Experiment


Title: gh-137191: Fix how type parameters are collected from `Protocol` and `Generic` bases with parameters by sobolevn · Pull Request #137281 · python/cpython · GitHub

Open Graph Title: gh-137191: Fix how type parameters are collected from `Protocol` and `Generic` bases with parameters by sobolevn · Pull Request #137281 · python/cpython

X Title: gh-137191: Fix how type parameters are collected from `Protocol` and `Generic` bases with parameters by sobolevn · Pull Request #137281 · python/cpython

Description: While fixing this problem, I've also noticed that code like class ExtraTypeVars(P1[S], Protocol[T, T2]): ... never produced any TypeError, it is in contrast to class ExtraTypeVars(P1[S], Generic[T, T2]): ... which produced this error as it should. I've fixed this as well. Issue: gh-137191

Open Graph Description: While fixing this problem, I've also noticed that code like class ExtraTypeVars(P1[S], Protocol[T, T2]): ... never produced any TypeError, it is in contrast to class ExtraTypeVars(P1[S], Generi...

X Description: While fixing this problem, I've also noticed that code like class ExtraTypeVars(P1[S], Protocol[T, T2]): ... never produced any TypeError, it is in contrast to class ExtraTypeVars(P1[S], Ge...

Opengraph URL: https://github.com/python/cpython/pull/137281

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/checks(.:format)
route-controllerpull_requests
route-actionchecks
fetch-noncev2:d2597796-a46e-2f74-87d6-900951ec40de
current-catalog-service-hash87dc3bc62d9b466312751bfd5f889726f4f1337bdff4e8be7da7c93d6c00a25a
request-idB9CA:388B78:615065:7D7AE5:696AE7BF
html-safe-nonced4098ac24c20de2258cd9e9fec37a16ea483624d02c19259ec8b2ce3c9a7862b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUNBOjM4OEI3ODo2MTUwNjU6N0Q3QUU1OjY5NkFFN0JGIiwidmlzaXRvcl9pZCI6IjM1OTI3NTYzNzU1NTQwMjU0MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8583dd8da6697466ff62d16d8ef0f9e4660fd81bd3fc91784fc52e41070cab9c
hovercard-subject-tagpull_request:2710202017
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,checks,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/checks
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/137281/checks
twitter:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
og:image:altWhile fixing this problem, I've also noticed that code like class ExtraTypeVars(P1[S], Protocol[T, T2]): ... never produced any TypeError, it is in contrast to class ExtraTypeVars(P1[S], Generi...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width full-width-p-0
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d84d50b3c75fa36755c3cf392edbc09e626f979
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/137281/checks#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137281%2Fchecks
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137281%2Fchecks
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fchecks&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/137281/checks
Reloadhttps://github.com/python/cpython/pull/137281/checks
Reloadhttps://github.com/python/cpython/pull/137281/checks
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/137281/checks
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/137281/checks
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-137191https://github.com/sobolevn/cpython/tree/issue-137191
Conversation 5 https://github.com/python/cpython/pull/137281
Commits 3 https://github.com/python/cpython/pull/137281/commits
Checks 43 https://github.com/python/cpython/pull/137281/checks
Files changed https://github.com/python/cpython/pull/137281/files
Please reload this pagehttps://github.com/python/cpython/pull/137281/checks
Please reload this pagehttps://github.com/python/cpython/pull/137281/checks
Sign in for the full log viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137281%2Fchecks
gh-137191: Fix how type parameters are collected from Protocol and Generic bases with parameters https://github.com/python/cpython/pull/137281/checks#top
Please reload this pagehttps://github.com/python/cpython/pull/137281/checks
Tests on: pull_request https://github.com/python/cpython/actions/runs/16652897389
Change detection / Create context from changed files https://github.com/python/cpython/actions/runs/16652897389/job/47130163346?pr=137281
Docs / Docs https://github.com/python/cpython/actions/runs/16652897389/job/47130182761?pr=137281
Docs / Doctest https://github.com/python/cpython/actions/runs/16652897389/job/47130182731?pr=137281
Check if Autoconf files are up to date https://github.com/python/cpython/actions/runs/16652897389/job/47130181611?pr=137281
Check if generated files are up to date https://github.com/python/cpython/actions/runs/16652897389/job/47130181855?pr=137281
Windows / Build and test (x64) https://github.com/python/cpython/actions/runs/16652897389/job/47130182294?pr=137281
Windows (free-threading) / Build and test (x64) https://github.com/python/cpython/actions/runs/16652897389/job/47130182322?pr=137281
Windows / Build and test (Win32) https://github.com/python/cpython/actions/runs/16652897389/job/47130182338?pr=137281
Windows / Build and test (arm64) https://github.com/python/cpython/actions/runs/16652897389/job/47130182351?pr=137281
Windows (free-threading) / Build and test (arm64) https://github.com/python/cpython/actions/runs/16652897389/job/47130182315?pr=137281
Windows MSI${{ '' }} https://github.com/python/cpython/actions/runs/16652897389/job/47130181842?pr=137281
macOS / build and test (ghcr.io/cirruslabs/macos-runner:sonoma) https://github.com/python/cpython/actions/runs/16652897389/job/47130182693?pr=137281
macOS (free-threading) / build and test (ghcr.io/cirruslabs/macos-runner:sonoma) https://github.com/python/cpython/actions/runs/16652897389/job/47130182699?pr=137281
macOS / build and test (macos-13) https://github.com/python/cpython/actions/runs/16652897389/job/47130182787?pr=137281
Ubuntu / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/16652897389/job/47130182572?pr=137281
Ubuntu / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/16652897389/job/47130182614?pr=137281
Ubuntu (free-threading) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/16652897389/job/47130182638?pr=137281
Ubuntu (free-threading) / build and test (ubuntu-24.04-arm) https://github.com/python/cpython/actions/runs/16652897389/job/47130182674?pr=137281
Ubuntu (bolt) / build and test (ubuntu-24.04) https://github.com/python/cpython/actions/runs/16652897389/job/47130182646?pr=137281
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.0.16) https://github.com/python/cpython/actions/runs/16652897389/job/47130181944?pr=137281
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.1.8) https://github.com/python/cpython/actions/runs/16652897389/job/47130181969?pr=137281
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.2.4) https://github.com/python/cpython/actions/runs/16652897389/job/47130181990?pr=137281
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.3.3) https://github.com/python/cpython/actions/runs/16652897389/job/47130181950?pr=137281
Ubuntu SSL tests with OpenSSL (ubuntu-24.04, 3.4.1) https://github.com/python/cpython/actions/runs/16652897389/job/47130181971?pr=137281
Ubuntu SSL tests with AWS-LC (ubuntu-24.04, 1.55.0) https://github.com/python/cpython/actions/runs/16652897389/job/47130181905?pr=137281
WASI / build and test https://github.com/python/cpython/actions/runs/16652897389/job/47130182259?pr=137281
Hypothesis tests on Ubuntu https://github.com/python/cpython/actions/runs/16652897389/job/47130181903?pr=137281
Address sanitizer (ubuntu-24.04) https://github.com/python/cpython/actions/runs/16652897389/job/47130181967?pr=137281
Sanitizers / TSan https://github.com/python/cpython/actions/runs/16652897389/job/47130182505?pr=137281
Sanitizers / TSan (free-threading) https://github.com/python/cpython/actions/runs/16652897389/job/47130182556?pr=137281
Sanitizers / UBSan https://github.com/python/cpython/actions/runs/16652897389/job/47130182566?pr=137281
Cross build Linux https://github.com/python/cpython/actions/runs/16652897389/job/47130181919?pr=137281
CIFuzz https://github.com/python/cpython/actions/runs/16652897389/job/47130181867?pr=137281
All required checks pass https://github.com/python/cpython/actions/runs/16652897389/job/47132185921?pr=137281
Lint on: pull_request https://github.com/python/cpython/actions/runs/16652897414
lint https://github.com/python/cpython/actions/runs/16652897414/job/47130163076?pr=137281
Check labels on: pull_request https://github.com/python/cpython/actions/runs/16652897416
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/16652897416/job/47130163237?pr=137281
Unresolved review https://github.com/python/cpython/actions/runs/16652897416/job/47130163168?pr=137281
Check labels on: pull_request https://github.com/python/cpython/actions/runs/16653041751
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/16653041751/job/47130669103?pr=137281
Unresolved review https://github.com/python/cpython/actions/runs/16653041751/job/47130669059?pr=137281
Check labels on: pull_request https://github.com/python/cpython/actions/runs/16653041871
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/16653041871/job/47130669323?pr=137281
Unresolved review https://github.com/python/cpython/actions/runs/16653041871/job/47130669400?pr=137281
Check labels on: pull_request https://github.com/python/cpython/actions/runs/16702644037
DO-NOT-MERGE https://github.com/python/cpython/actions/runs/16702644037/job/47276033536?pr=137281
Unresolved review https://github.com/python/cpython/actions/runs/16702644037/job/47276033534?pr=137281
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.