René's URL Explorer Experiment


Title: bpo-35431: Refactor math.comb() implementation. by serhiy-storchaka · Pull Request #13725 · python/cpython · GitHub

Open Graph Title: bpo-35431: Refactor math.comb() implementation. by serhiy-storchaka · Pull Request #13725 · python/cpython

X Title: bpo-35431: Refactor math.comb() implementation. by serhiy-storchaka · Pull Request #13725 · python/cpython

Description: It now accepts arbitrary index-likes objects, not just int. Fixed some subtle bugs which may be exposed when arguments are int subclasses with overridden __sub__, __lt__, etc. MemoryError is now always raised for too large min(k, n-k). Previously MemoryError or OverflowError could be raised depending on the value. Fixed leaks. Improved error messages. Cleaned up and optimized the code. Optimization is technical, not algorithmic. https://bugs.python.org/issue35431

Open Graph Description: It now accepts arbitrary index-likes objects, not just int. Fixed some subtle bugs which may be exposed when arguments are int subclasses with overridden __sub__, __lt__, etc. MemoryError is now al...

X Description: It now accepts arbitrary index-likes objects, not just int. Fixed some subtle bugs which may be exposed when arguments are int subclasses with overridden __sub__, __lt__, etc. MemoryError is now al...

Opengraph URL: https://github.com/python/cpython/pull/13725

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:e9fce745-8136-443a-7131-907602a0132b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD44E:33B84F:38E2B0F:4E8094F:6A54B6D5
html-safe-nonce74bfe0200e5f6adc33693183d26ccebf74c06c5d20107de9a99dbed167847963
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENDRFOjMzQjg0RjozOEUyQjBGOjRFODA5NEY6NkE1NEI2RDUiLCJ2aXNpdG9yX2lkIjoiMzIwMzE1MTI2MzU1OTg5MDY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac468a5add66af314adebe3d93a2bd970f26216a6ef172904afe183d48e19c10d3
hovercard-subject-tagpull_request:284277223
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13725/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altIt now accepts arbitrary index-likes objects, not just int. Fixed some subtle bugs which may be exposed when arguments are int subclasses with overridden __sub__, __lt__, etc. MemoryError is now al...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5d343e1152573ef294b28f54e4a14fb5fdb3a5a1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13725/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13725%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13725%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13725/files
Reloadhttps://github.com/python/cpython/pull/13725/files
Reloadhttps://github.com/python/cpython/pull/13725/files
Please reload this pagehttps://github.com/python/cpython/pull/13725/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13725/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
serhiy-storchaka:math-combhttps://github.com/serhiy-storchaka/cpython/tree/math-comb
Conversation 22 https://github.com/python/cpython/pull/13725
Commits 8 https://github.com/python/cpython/pull/13725/commits
Checks 0 https://github.com/python/cpython/pull/13725/checks
Files changed https://github.com/python/cpython/pull/13725/files
Please reload this pagehttps://github.com/python/cpython/pull/13725/files
bpo-35431: Refactor math.comb() implementation. https://github.com/python/cpython/pull/13725/files#top
Show all changes 8 commits https://github.com/python/cpython/pull/13725/files
2a53a87 Refactor math.comb() implementation. serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/2a53a871377aaedd19a9079aac34fda02000d739
678efbb Restore using long long. serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/678efbb3893dfc0772e055f0b048150eb990a714
605121a Address review comments. serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/605121ac6fd71b9e5f9ee29331d09b40ca2729a1
e1922de Make arguments positional-only. serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/e1922de062d1e1fd4d600be2b77ed8739868bd1c
18fe65e Tweak docs. serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/18fe65e6e80cdf2615e874aac4883538314eba7d
492b211 Update Doc/library/math.rst serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/492b211a4ef6ff161b4b5492e32aabf26185e97c
fb66ce7 Address review comments. serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/fb66ce7c995b4984524cfc3682aec4a415cc2791
0477acb Merge branch 'math-comb' of github.com:serhiy-storchaka/cpython into … serhiy-storchaka Jun 1, 2019 https://github.com/python/cpython/pull/13725/commits/0477acb8c2c998927494d747501df8f5739a6e50
Clear filters https://github.com/python/cpython/pull/13725/files
Please reload this pagehttps://github.com/python/cpython/pull/13725/files
Please reload this pagehttps://github.com/python/cpython/pull/13725/files
math.rst https://github.com/python/cpython/pull/13725/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
test_math.py https://github.com/python/cpython/pull/13725/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
mathmodule.c.h https://github.com/python/cpython/pull/13725/files#diff-be28b04d80a581f81971deb34bb269241521f2aae3517b952fcfeba9f073bbf1
mathmodule.c https://github.com/python/cpython/pull/13725/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
Doc/library/math.rsthttps://github.com/python/cpython/pull/13725/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
View file https://github.com/serhiy-storchaka/cpython/blob/0477acb8c2c998927494d747501df8f5739a6e50/Doc/library/math.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13725/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13725/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
https://github.com/python/cpython/pull/13725/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
Lib/test/test_math.pyhttps://github.com/python/cpython/pull/13725/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
View file https://github.com/serhiy-storchaka/cpython/blob/0477acb8c2c998927494d747501df8f5739a6e50/Lib/test/test_math.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13725/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13725/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
https://github.com/python/cpython/pull/13725/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
Modules/clinic/mathmodule.c.hhttps://github.com/python/cpython/pull/13725/files#diff-be28b04d80a581f81971deb34bb269241521f2aae3517b952fcfeba9f073bbf1
View file https://github.com/serhiy-storchaka/cpython/blob/0477acb8c2c998927494d747501df8f5739a6e50/Modules/clinic/mathmodule.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/13725/files
Modules/mathmodule.chttps://github.com/python/cpython/pull/13725/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
View file https://github.com/serhiy-storchaka/cpython/blob/0477acb8c2c998927494d747501df8f5739a6e50/Modules/mathmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13725/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13725/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
Please reload this pagehttps://github.com/python/cpython/pull/13725/files
https://github.com/python/cpython/pull/13725/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/13725/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.