René's URL Explorer Experiment


Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #13714 · python/cpython · GitHub

Open Graph Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #13714 · python/cpython

X Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #13714 · python/cpython

Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 different bugs in the original PRs and have fixed them here. I also tried again (with some tweaks) in #12360, which I ended up reverting in #12806. For this attempt I am dropping the code that calls any remaining pending calls during runtime finalization. We'll see if the FreeBSD buildbot still hates me. :) https://bugs.python.org/issue33608

Open Graph Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 diffe...

X Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 diffe...

Opengraph URL: https://github.com/python/cpython/pull/13714

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8aff4bb0-fde5-09f0-c47b-f86796dfbe9a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE53E:155AC0:9A1A7C:D52ED5:6A5132BF
html-safe-noncef23d66587617ff6a27cb691d0ac0cf3a619df85265b09241f1730fbb2b5f8d90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTNFOjE1NUFDMDo5QTFBN0M6RDUyRUQ1OjZBNTEzMkJGIiwidmlzaXRvcl9pZCI6IjYwMzA3MjY2MTkwNTU4NjI0NjMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8fe64409b7d5f9ce853110ff3707fc7a884203bafcfc7e00001b046795ce042f
hovercard-subject-tagpull_request:284242078
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13714/files
twitter:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1152074?s=400&v=4
og:image:altThis is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 diffe...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee840f405b2718e8f2d55aafa9ff27dbce17e29d0c253011d05ea0fea3c78baff
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4ae6027e8ba70c79dc08249bb6cdc1a09d788496
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13714/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13714%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13714%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13714/files
Reloadhttps://github.com/python/cpython/pull/13714/files
Reloadhttps://github.com/python/cpython/pull/13714/files
Please reload this pagehttps://github.com/python/cpython/pull/13714/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13714/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:pending-calls-unreverthttps://github.com/ericsnowcurrently/cpython/tree/pending-calls-unrevert
Conversation 1 https://github.com/python/cpython/pull/13714
Commits 20 https://github.com/python/cpython/pull/13714/commits
Checks 0 https://github.com/python/cpython/pull/13714/checks
Files changed https://github.com/python/cpython/pull/13714/files
Please reload this pagehttps://github.com/python/cpython/pull/13714/files
bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). https://github.com/python/cpython/pull/13714/files#top
Show all changes 20 commits https://github.com/python/cpython/pull/13714/files
59b2d34 ceval -> ceval_r ericsnowcurrently May 31, 2019 https://github.com/python/cpython/pull/13714/commits/59b2d34234c76af3e7aac7bd952f8fc69a1aface
ceceab7 _Py_FinishPendingCalls -> _PyEval_FinishPendingCalls ericsnowcurrently May 31, 2019 https://github.com/python/cpython/pull/13714/commits/ceceab7c5346710da2ad4454879e00d84799d0d3
3fbc879 Drop the GIL_REQUEST macro. ericsnowcurrently May 31, 2019 https://github.com/python/cpython/pull/13714/commits/3fbc8796cbf4973c3a0eb8541de76950ffb05bfb
dedcf7f Move pending calls from _PyRuntimeState to PyIntepreterState. ericsnowcurrently Jul 13, 2018 https://github.com/python/cpython/pull/13714/commits/dedcf7f23d9e19544d801624498b3d34cf8158c7
b2c8a7b Release the pending calls lock *after* updating the eval breaker flag. ericsnowcurrently Mar 15, 2019 https://github.com/python/cpython/pull/13714/commits/b2c8a7b52715b74fe905a33a2dc4c2d1a038e9c8
05e2808 Use the internal function. ericsnowcurrently Sep 14, 2018 https://github.com/python/cpython/pull/13714/commits/05e2808f28ead6ba3c7d931fbd0e8c5ddd06856d
d9d70e8 Add a NEWS entry. ericsnowcurrently Sep 15, 2018 https://github.com/python/cpython/pull/13714/commits/d9d70e8974f5b07da1b184f24d39950f06336af7
b02a36b Optionally lock a pending call to a specific thread. ericsnowcurrently Sep 15, 2018 https://github.com/python/cpython/pull/13714/commits/b02a36b916fe397257690b24c49c0ddbd0557f75
28a4583 Move core-only field to end of struct. ericsnowcurrently Feb 1, 2019 https://github.com/python/cpython/pull/13714/commits/28a4583e6863113e9ed5771700c8fb0836610a2c
b7150c7 Add a TODO. ericsnowcurrently Feb 18, 2019 https://github.com/python/cpython/pull/13714/commits/b7150c7e20afcc2172b9c90c0d0e85504731913d
87e15fe Use _Py_AddPendingCall() for releasing shared data. ericsnowcurrently Sep 14, 2018 https://github.com/python/cpython/pull/13714/commits/87e15fe7aeccf3c1b2dd5f51e65e2730966009f9
07957ba Check the result of adding the pending call (for releasing XID). ericsnowcurrently Jan 28, 2019 https://github.com/python/cpython/pull/13714/commits/07957ba5701b2834d756c4e3a41b62fbcc681a50
78c49a0 Make a copy of data-to-be-deleted. ericsnowcurrently Jan 29, 2019 https://github.com/python/cpython/pull/13714/commits/78c49a0952aa0c8ea5a1bb3872845baee00c2b7a
70ef8f9 Fix the pending-for-other-thread case. ericsnowcurrently Apr 5, 2019 https://github.com/python/cpython/pull/13714/commits/70ef8f9c4873ea73d27d135ad559388901ece3ad
b392d32 Ignore any lingering pending calls. ericsnowcurrently Jun 1, 2019 https://github.com/python/cpython/pull/13714/commits/b392d32f62427908d463ef9a6ae47109df3c89a3
d8ac442 Always use the main interpreter for signals. ericsnowcurrently Jun 1, 2019 https://github.com/python/cpython/pull/13714/commits/d8ac4429ff2c2d834bf4bfa8123faed2d6db4824
7c0e3cb Add more information to the TODO in Py_FinalizeEx(). ericsnowcurrently Jun 1, 2019 https://github.com/python/cpython/pull/13714/commits/7c0e3cb53bc6fbc0e42f47fd25d1ffc46483753d
b8cfc36 Drop a superfluous comment. ericsnowcurrently Jun 1, 2019 https://github.com/python/cpython/pull/13714/commits/b8cfc365a6706edfbd6b6ae3fe52d29e525b3689
652c7bc Do not assume that tstate->interp is not NULL. ericsnowcurrently Jun 1, 2019 https://github.com/python/cpython/pull/13714/commits/652c7bced5701f0ff1c15ff2206df4dfe91ad36b
fb0fe21 _pending_calls -> _ceval_pending_calls ericsnowcurrently Jun 1, 2019 https://github.com/python/cpython/pull/13714/commits/fb0fe21738e1cd6a5c086117790339716c90eaeb
Clear filters https://github.com/python/cpython/pull/13714/files
Please reload this pagehttps://github.com/python/cpython/pull/13714/files
Please reload this pagehttps://github.com/python/cpython/pull/13714/files
pycore_ceval.h https://github.com/python/cpython/pull/13714/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
pycore_pystate.h https://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
test_capi.py https://github.com/python/cpython/pull/13714/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
2018-09-15-12-13-46.bpo-33608.avmvVP.rst https://github.com/python/cpython/pull/13714/files#diff-9180afc508bd25efb07dc85c316ba046bcb38b63d0c8fc078688e29a46cf3aaf
_testcapimodule.c https://github.com/python/cpython/pull/13714/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
signalmodule.c https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
ceval.c https://github.com/python/cpython/pull/13714/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
ceval_gil.h https://github.com/python/cpython/pull/13714/files#diff-a752fe0b500ba9e2a169c27f43c58c1e354039fffa5ad64852e0978006f45660
pylifecycle.c https://github.com/python/cpython/pull/13714/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
pystate.c https://github.com/python/cpython/pull/13714/files#diff-7ac11e526f79b42d6ea9d3592cb99da46775640c69fa5510f4a6de87cced7141
Include/internal/pycore_ceval.hhttps://github.com/python/cpython/pull/13714/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
View file https://github.com/ericsnowcurrently/cpython/blob/fb0fe21738e1cd6a5c086117790339716c90eaeb/Include/internal/pycore_ceval.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13714/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13714/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
https://github.com/python/cpython/pull/13714/files#diff-9e7eb7e81667528dfa3a35bbf32fe622d4721c3c71385ea0ea2250abbd15d545
Include/internal/pycore_pystate.hhttps://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
View file https://github.com/ericsnowcurrently/cpython/blob/fb0fe21738e1cd6a5c086117790339716c90eaeb/Include/internal/pycore_pystate.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13714/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
https://github.com/python/cpython/pull/13714/files#diff-76818a128869986e3de4f16dae0257c430008546f04764cd7ad8254abfa5ce83
Lib/test/test_capi.pyhttps://github.com/python/cpython/pull/13714/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
View file https://github.com/ericsnowcurrently/cpython/blob/fb0fe21738e1cd6a5c086117790339716c90eaeb/Lib/test/test_capi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13714/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13714/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
https://github.com/python/cpython/pull/13714/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
Misc/NEWS.d/next/Core and Builtins/2018-09-15-12-13-46.bpo-33608.avmvVP.rsthttps://github.com/python/cpython/pull/13714/files#diff-9180afc508bd25efb07dc85c316ba046bcb38b63d0c8fc078688e29a46cf3aaf
View file https://github.com/ericsnowcurrently/cpython/blob/fb0fe21738e1cd6a5c086117790339716c90eaeb/Misc/NEWS.d/next/Core%20and%20Builtins/2018-09-15-12-13-46.bpo-33608.avmvVP.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13714/{{ revealButtonHref }}
Modules/_testcapimodule.chttps://github.com/python/cpython/pull/13714/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
View file https://github.com/ericsnowcurrently/cpython/blob/fb0fe21738e1cd6a5c086117790339716c90eaeb/Modules/_testcapimodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13714/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13714/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/13714/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
Modules/signalmodule.chttps://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
View file https://github.com/ericsnowcurrently/cpython/blob/fb0fe21738e1cd6a5c086117790339716c90eaeb/Modules/signalmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13714/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
https://github.com/python/cpython/pull/13714/files#diff-99fb04b208835118fdca0d54b76a00c450da3eaff09d2b53e8a03d63bbe88e30
Please reload this pagehttps://github.com/python/cpython/pull/13714/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.