René's URL Explorer Experiment


Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #13714 · python/cpython · GitHub

Open Graph Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #13714 · python/cpython

X Title: bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). by ericsnowcurrently · Pull Request #13714 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 diffe...

X Description: This is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 diffe...

Opengraph URL: https://github.com/python/cpython/pull/13714

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2a9b43b3-4f5b-a451-4f55-1655b275783c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE258:DBD6A:16D48C:1E92EA:6A511452
html-safe-nonce3b889021a984ba9131aa52f5e49d5c111fcabdc4818b4cd0891eeb2ef4e0fe2c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjU4OkRCRDZBOjE2RDQ4QzoxRTkyRUE6NkE1MTE0NTIiLCJ2aXNpdG9yX2lkIjoiNzM2MTg3NTc4ODgzOTMyNjgwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf961326ee772f8a746a1a016dd5d0d6f9bb9f44072cf73dbf4bc862015fa92c7
hovercard-subject-tagpull_request:284242078
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13714/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a21f48f9fb0e7ec9fba6cd196843f55c8c43474acc23ec3b81805d75ee69de9b/python/cpython/pull/13714
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a21f48f9fb0e7ec9fba6cd196843f55c8c43474acc23ec3b81805d75ee69de9b/python/cpython/pull/13714
og:image:altThis is effectively an un-revert of #11617 and #12024 (reverted in #12159). Portions of those were merged in other PRs (with lower risk) and this represents the remainder. Note that I found 3 diffe...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameericsnowcurrently
hostnamegithub.com
expected-hostnamegithub.com
Noneb076e100febaa00374cd89239f915d00dd3187f7c68b12bc2b7688181305344d
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef9137f6d981cbbfd780af369f80ce890b2d0d2d4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13714#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13714
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13714
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13714
Reloadhttps://github.com/python/cpython/pull/13714
Reloadhttps://github.com/python/cpython/pull/13714
Please reload this pagehttps://github.com/python/cpython/pull/13714
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13714
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:pending-calls-unreverthttps://github.com/ericsnowcurrently/cpython/tree/pending-calls-unrevert
Conversationhttps://github.com/python/cpython/pull/13714
Commits20 (20)https://github.com/python/cpython/pull/13714/commits
Checkshttps://github.com/python/cpython/pull/13714/checks
Files changedhttps://github.com/python/cpython/pull/13714/files
bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall().https://github.com/python/cpython/pull/13714#top
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
python:masterhttps://github.com/python/cpython/tree/master
ericsnowcurrently:pending-calls-unreverthttps://github.com/ericsnowcurrently/cpython/tree/pending-calls-unrevert
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
Jun 1, 2019https://github.com/python/cpython/pull/13714#issue-451043342
Please reload this pagehttps://github.com/python/cpython/pull/13714
#11617https://github.com/python/cpython/pull/11617
#12024https://github.com/python/cpython/pull/12024
#12159https://github.com/python/cpython/pull/12159
#12360https://github.com/python/cpython/pull/12360
#12806https://github.com/python/cpython/pull/12806
https://bugs.python.org/issue33608https://bugs.python.org/issue33608
Please reload this pagehttps://github.com/python/cpython/pull/13714
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
May 31, 2019 22:20https://github.com/python/cpython/pull/13714#commits-pushed-59b2d34
https://github.com/ericsnowcurrently
ceval -> ceval_rhttps://github.com/python/cpython/pull/13714/commits/59b2d34234c76af3e7aac7bd952f8fc69a1aface
59b2d34https://github.com/python/cpython/pull/13714/commits/59b2d34234c76af3e7aac7bd952f8fc69a1aface
https://github.com/ericsnowcurrently
_Py_FinishPendingCalls -> _PyEval_FinishPendingCallshttps://github.com/python/cpython/pull/13714/commits/ceceab7c5346710da2ad4454879e00d84799d0d3
ceceab7https://github.com/python/cpython/pull/13714/commits/ceceab7c5346710da2ad4454879e00d84799d0d3
https://github.com/ericsnowcurrently
Drop the GIL_REQUEST macro.https://github.com/python/cpython/pull/13714/commits/3fbc8796cbf4973c3a0eb8541de76950ffb05bfb
3fbc879https://github.com/python/cpython/pull/13714/commits/3fbc8796cbf4973c3a0eb8541de76950ffb05bfb
https://github.com/ericsnowcurrently
Move pending calls from _PyRuntimeState to PyIntepreterState.https://github.com/python/cpython/pull/13714/commits/dedcf7f23d9e19544d801624498b3d34cf8158c7
dedcf7fhttps://github.com/python/cpython/pull/13714/commits/dedcf7f23d9e19544d801624498b3d34cf8158c7
https://github.com/ericsnowcurrently
Release the pending calls lock *after* updating the eval breaker flag.https://github.com/python/cpython/pull/13714/commits/b2c8a7b52715b74fe905a33a2dc4c2d1a038e9c8
b2c8a7bhttps://github.com/python/cpython/pull/13714/commits/b2c8a7b52715b74fe905a33a2dc4c2d1a038e9c8
https://github.com/ericsnowcurrently
Use the internal function.https://github.com/python/cpython/pull/13714/commits/05e2808f28ead6ba3c7d931fbd0e8c5ddd06856d
05e2808https://github.com/python/cpython/pull/13714/commits/05e2808f28ead6ba3c7d931fbd0e8c5ddd06856d
https://github.com/ericsnowcurrently
Add a NEWS entry.https://github.com/python/cpython/pull/13714/commits/d9d70e8974f5b07da1b184f24d39950f06336af7
d9d70e8https://github.com/python/cpython/pull/13714/commits/d9d70e8974f5b07da1b184f24d39950f06336af7
https://github.com/ericsnowcurrently
Optionally lock a pending call to a specific thread.https://github.com/python/cpython/pull/13714/commits/b02a36b916fe397257690b24c49c0ddbd0557f75
b02a36bhttps://github.com/python/cpython/pull/13714/commits/b02a36b916fe397257690b24c49c0ddbd0557f75
https://github.com/ericsnowcurrently
Move core-only field to end of struct.https://github.com/python/cpython/pull/13714/commits/28a4583e6863113e9ed5771700c8fb0836610a2c
28a4583https://github.com/python/cpython/pull/13714/commits/28a4583e6863113e9ed5771700c8fb0836610a2c
https://github.com/ericsnowcurrently
Add a TODO.https://github.com/python/cpython/pull/13714/commits/b7150c7e20afcc2172b9c90c0d0e85504731913d
b7150c7https://github.com/python/cpython/pull/13714/commits/b7150c7e20afcc2172b9c90c0d0e85504731913d
https://github.com/ericsnowcurrently
Use _Py_AddPendingCall() for releasing shared data.https://github.com/python/cpython/pull/13714/commits/87e15fe7aeccf3c1b2dd5f51e65e2730966009f9
87e15fehttps://github.com/python/cpython/pull/13714/commits/87e15fe7aeccf3c1b2dd5f51e65e2730966009f9
https://github.com/ericsnowcurrently
Check the result of adding the pending call (for releasing XID).https://github.com/python/cpython/pull/13714/commits/07957ba5701b2834d756c4e3a41b62fbcc681a50
07957bahttps://github.com/python/cpython/pull/13714/commits/07957ba5701b2834d756c4e3a41b62fbcc681a50
https://github.com/ericsnowcurrently
Make a copy of data-to-be-deleted.https://github.com/python/cpython/pull/13714/commits/78c49a0952aa0c8ea5a1bb3872845baee00c2b7a
78c49a0https://github.com/python/cpython/pull/13714/commits/78c49a0952aa0c8ea5a1bb3872845baee00c2b7a
https://github.com/ericsnowcurrently
Fix the pending-for-other-thread case.https://github.com/python/cpython/pull/13714/commits/70ef8f9c4873ea73d27d135ad559388901ece3ad
70ef8f9https://github.com/python/cpython/pull/13714/commits/70ef8f9c4873ea73d27d135ad559388901ece3ad
https://github.com/ericsnowcurrently
Ignore any lingering pending calls.https://github.com/python/cpython/pull/13714/commits/b392d32f62427908d463ef9a6ae47109df3c89a3
b392d32https://github.com/python/cpython/pull/13714/commits/b392d32f62427908d463ef9a6ae47109df3c89a3
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jun 1, 2019https://github.com/python/cpython/pull/13714#event-2382507727
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 1, 2019https://github.com/python/cpython/pull/13714#event-2382507744
https://github.com/csabella
csabellahttps://github.com/csabella
Jun 1, 2019https://github.com/python/cpython/pull/13714#issuecomment-497935268
Please reload this pagehttps://github.com/python/cpython/pull/13714
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
June 1, 2019 12:12https://github.com/python/cpython/pull/13714#commits-pushed-d8ac442
https://github.com/ericsnowcurrently
Always use the main interpreter for signals.https://github.com/python/cpython/pull/13714/commits/d8ac4429ff2c2d834bf4bfa8123faed2d6db4824
d8ac442https://github.com/python/cpython/pull/13714/commits/d8ac4429ff2c2d834bf4bfa8123faed2d6db4824
https://github.com/ericsnowcurrently
Add more information to the TODO in Py_FinalizeEx().https://github.com/python/cpython/pull/13714/commits/7c0e3cb53bc6fbc0e42f47fd25d1ffc46483753d
7c0e3cbhttps://github.com/python/cpython/pull/13714/commits/7c0e3cb53bc6fbc0e42f47fd25d1ffc46483753d
https://github.com/ericsnowcurrently
Drop a superfluous comment.https://github.com/python/cpython/pull/13714/commits/b8cfc365a6706edfbd6b6ae3fe52d29e525b3689
b8cfc36https://github.com/python/cpython/pull/13714/commits/b8cfc365a6706edfbd6b6ae3fe52d29e525b3689
https://github.com/ericsnowcurrently
Do not assume that tstate->interp is not NULL.https://github.com/python/cpython/pull/13714/commits/652c7bced5701f0ff1c15ff2206df4dfe91ad36b
652c7bchttps://github.com/python/cpython/pull/13714/commits/652c7bced5701f0ff1c15ff2206df4dfe91ad36b
https://github.com/ericsnowcurrently
_pending_calls -> _ceval_pending_callshttps://github.com/python/cpython/pull/13714/commits/fb0fe21738e1cd6a5c086117790339716c90eaeb
fb0fe21https://github.com/python/cpython/pull/13714/commits/fb0fe21738e1cd6a5c086117790339716c90eaeb
https://github.com/ericsnowcurrently
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
6a150bchttps://github.com/python/cpython/commit/6a150bcaeb190d1731b38ab9c7a5d1a352847ddc
Jun 1, 2019https://github.com/python/cpython/pull/13714#event-2382902003
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 1, 2019https://github.com/python/cpython/pull/13714#event-2382902015
vstinnerhttps://github.com/vstinner
Jun 3, 2019 https://github.com/python/cpython/pull/13714#ref-commit-e225beb
https://github.com/vstinner
Revert "https://github.com/python/cpython/commit/e225bebc1409bcf68db74a35ed3c31222883bf8f
bpo-33608https://bugs.python.org/issue?@action=redirect&bpo=33608
: Factor out a private, per-interpreter _Py_AddPendi…https://github.com/python/cpython/commit/e225bebc1409bcf68db74a35ed3c31222883bf8f
e225bebhttps://github.com/python/cpython/commit/e225bebc1409bcf68db74a35ed3c31222883bf8f
gh-13714https://github.com/python/cpython/pull/13714
GH-13780https://github.com/python/cpython/pull/13780
6a150bchttps://github.com/python/cpython/commit/6a150bcaeb190d1731b38ab9c7a5d1a352847ddc
DinoVhttps://github.com/DinoV
Jan 14, 2020 https://github.com/python/cpython/pull/13714#ref-commit-fb6351a
https://github.com/ericsnowcurrently
https://github.com/DinoV
bpo-33608: Factor out a private, per-interpreter _Py_AddPendingCall(). (https://github.com/DinoV/cpython/commit/fb6351a48ddc7438c52d907a146f9478e838000f
fb6351ahttps://github.com/DinoV/cpython/commit/fb6351a48ddc7438c52d907a146f9478e838000f
pythongh-13714https://github.com/python/cpython/pull/13714
DinoVhttps://github.com/DinoV
Jan 14, 2020 https://github.com/python/cpython/pull/13714#ref-commit-a405d90
https://github.com/vstinner
https://github.com/DinoV
Revert "bpo-33608: Factor out a private, per-interpreter _Py_AddPendi…https://github.com/DinoV/cpython/commit/a405d90d66c04689b451419a33a743b4f706e50c
a405d90https://github.com/DinoV/cpython/commit/a405d90d66c04689b451419a33a743b4f706e50c
pythongh-13714https://github.com/python/cpython/pull/13714
pythonGH-13780https://github.com/python/cpython/pull/13780
6a150bchttps://github.com/DinoV/cpython/commit/6a150bcaeb190d1731b38ab9c7a5d1a352847ddc
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13714
Please reload this pagehttps://github.com/python/cpython/pull/13714
https://github.com/ericsnowcurrently
https://github.com/csabella
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.