René's URL Explorer Experiment


Title: gh-132551: add missing critical sections on BytesIO methods by kumaraditya303 · Pull Request #137073 · python/cpython · GitHub

Open Graph Title: gh-132551: add missing critical sections on BytesIO methods by kumaraditya303 · Pull Request #137073 · python/cpython

X Title: gh-132551: add missing critical sections on BytesIO methods by kumaraditya303 · Pull Request #137073 · python/cpython

Description: Follow up for #132616 and adds missing critical sections, this fixes data races on self->buf when checking for closed object: ARNING: ThreadSanitizer: data race (pid=80476) Write of size 8 at 0x000118135d60 by thread T26239: #0 resize_buffer_lock_held bytesio.c:172 (libpython3.15t.dylib:arm64+0x3d484c) #1 write_bytes_lock_held bytesio.c:216 (libpython3.15t.dylib:arm64+0x3d4658) #2 _io_BytesIO_write bytesio.c.h:489 (libpython3.15t.dylib:arm64+0x3d1e84) #3 _PyEval_EvalFrameDefault generated_cases.c.h:2487 (libpython3.15t.dylib:arm64+0x277ea0) #4 _PyEval_Vector ceval.c:1977 (libpython3.15t.dylib:arm64+0x26a148) #5 _PyFunction_Vectorcall call.c (libpython3.15t.dylib:arm64+0x7fe5c) #6 method_vectorcall classobject.c:73 (libpython3.15t.dylib:arm64+0x8439c) #7 context_run context.c:728 (libpython3.15t.dylib:arm64+0x2b4bfc) #8 _PyEval_EvalFrameDefault generated_cases.c.h:3766 (libpython3.15t.dylib:arm64+0x27f484) #9 _PyEval_Vector ceval.c:1977 (libpython3.15t.dylib:arm64+0x26a148) #10 _PyFunction_Vectorcall call.c (libpython3.15t.dylib:arm64+0x7fe5c) #11 method_vectorcall classobject.c:73 (libpython3.15t.dylib:arm64+0x8439c) #12 _PyObject_Call call.c:348 (libpython3.15t.dylib:arm64+0x7fad4) #13 PyObject_Call call.c:373 (libpython3.15t.dylib:arm64+0x7fb48) #14 thread_run _threadmodule.c:373 (libpython3.15t.dylib:arm64+0x4174f4) #15 pythread_wrapper thread_pthread.h:232 (libpython3.15t.dylib:arm64+0x356b4c) Previous read of size 8 at 0x000118135d60 by thread T26238: #0 _io_BytesIO_isatty bytesio.c.h:155 (libpython3.15t.dylib:arm64+0x3d1c10) #1 method_vectorcall_NOARGS descrobject.c:448 (libpython3.15t.dylib:arm64+0x96e1c) #2 PyObject_VectorcallMethod call.c:859 (libpython3.15t.dylib:arm64+0x81550) #3 _io_TextIOWrapper_isatty textio.c.h:1114 (libpython3.15t.dylib:arm64+0x3e7c5c) #4 method_vectorcall_NOARGS descrobject.c:448 (libpython3.15t.dylib:arm64+0x96e1c) #5 PyObject_Vectorcall call.c:327 (libpython3.15t.dylib:arm64+0x7f824) #6 _PyEval_EvalFrameDefault generated_cases.c.h:1620 (libpython3.15t.dylib:arm64+0x276f24) #7 _PyEval_Vector ceval.c:1977 (libpython3.15t.dylib:arm64+0x26a148) #8 _PyFunction_Vectorcall call.c (libpython3.15t.dylib:arm64+0x7fe5c) #9 method_vectorcall classobject.c:73 (libpython3.15t.dylib:arm64+0x8439c) #10 context_run context.c:728 (libpython3.15t.dylib:arm64+0x2b4bfc) #11 _PyEval_EvalFrameDefault generated_cases.c.h:3766 (libpython3.15t.dylib:arm64+0x27f484) #12 _PyEval_Vector ceval.c:1977 (libpython3.15t.dylib:arm64+0x26a148) #13 _PyFunction_Vectorcall call.c (libpython3.15t.dylib:arm64+0x7fe5c) #14 method_vectorcall classobject.c:73 (libpython3.15t.dylib:arm64+0x8439c) #15 _PyObject_Call call.c:348 (libpython3.15t.dylib:arm64+0x7fad4) #16 PyObject_Call call.c:373 (libpython3.15t.dylib:arm64+0x7fb48) #17 thread_run _threadmodule.c:373 (libpython3.15t.dylib:arm64+0x4174f4) #18 pythread_wrapper thread_pthread.h:232 (libpython3.15t.dylib:arm64+0x356b4c) Issue: gh-132551

Open Graph Description: Follow up for #132616 and adds missing critical sections, this fixes data races on self->buf when checking for closed object: ARNING: ThreadSanitizer: data race (pid=80476) Write of size 8 at ...

X Description: Follow up for #132616 and adds missing critical sections, this fixes data races on self->buf when checking for closed object: ARNING: ThreadSanitizer: data race (pid=80476) Write of size 8...

Opengraph URL: https://github.com/python/cpython/pull/137073

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9ecb7fc2-dc84-03ab-59ee-e402a9bf4900
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA83A:2180CA:1C6805D:260AE82:6A5456D4
html-safe-nonce857cb81611205e20e35eca55ec935d2a073a2ed1db9387cd968861c9503a7164
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODNBOjIxODBDQToxQzY4MDVEOjI2MEFFODI6NkE1NDU2RDQiLCJ2aXNpdG9yX2lkIjoiNzM0MTg2MzU0NzYzNzYxODM4OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1c70a119f3649870875bce1dd79a1a7ec9ee10449e2be17e59d110f2438fbf2a
hovercard-subject-tagpull_request:2691636296
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/137073/files
twitter:imagehttps://avatars.githubusercontent.com/u/59607654?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/59607654?s=400&v=4
og:image:altFollow up for #132616 and adds missing critical sections, this fixes data races on self->buf when checking for closed object: ARNING: ThreadSanitizer: data race (pid=80476) Write of size 8 at ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/137073/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137073%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137073%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/137073/files
Reloadhttps://github.com/python/cpython/pull/137073/files
Reloadhttps://github.com/python/cpython/pull/137073/files
Please reload this pagehttps://github.com/python/cpython/pull/137073/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/137073/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
kumaraditya303https://github.com/kumaraditya303
python:mainhttps://github.com/python/cpython/tree/main
kumaraditya303:bytesiohttps://github.com/kumaraditya303/cpython/tree/bytesio
Conversation 2 https://github.com/python/cpython/pull/137073
Commits 1 https://github.com/python/cpython/pull/137073/commits
Checks 48 https://github.com/python/cpython/pull/137073/checks
Files changed https://github.com/python/cpython/pull/137073/files
Please reload this pagehttps://github.com/python/cpython/pull/137073/files
gh-132551: add missing critical sections on BytesIO methods https://github.com/python/cpython/pull/137073/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/137073/files
d526d63 add missing critical sections on BytesIO kumaraditya303 Jul 24, 2025 https://github.com/python/cpython/pull/137073/commits/d526d631f7ae779717eef2953f15b5b34fe54679
Clear filters https://github.com/python/cpython/pull/137073/files
Please reload this pagehttps://github.com/python/cpython/pull/137073/files
Please reload this pagehttps://github.com/python/cpython/pull/137073/files
bytesio.c https://github.com/python/cpython/pull/137073/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
bytesio.c.h https://github.com/python/cpython/pull/137073/files#diff-911b08697dbf4065002832267252cc88474bf15e45fbe5d8464fcdf1ae566f86
Modules/_io/bytesio.chttps://github.com/python/cpython/pull/137073/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
View file https://github.com/kumaraditya303/cpython/blob/d526d631f7ae779717eef2953f15b5b34fe54679/Modules/_io/bytesio.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/137073/{{ revealButtonHref }}
https://github.com/python/cpython/pull/137073/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
https://github.com/python/cpython/pull/137073/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
https://github.com/python/cpython/pull/137073/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
https://github.com/python/cpython/pull/137073/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
https://github.com/python/cpython/pull/137073/files#diff-fbdbc4e9c4c46bb4d0afb3927ea0ba919e62c1a79c390aa695a50fc317e48e09
Modules/_io/clinic/bytesio.c.hhttps://github.com/python/cpython/pull/137073/files#diff-911b08697dbf4065002832267252cc88474bf15e45fbe5d8464fcdf1ae566f86
View file https://github.com/kumaraditya303/cpython/blob/d526d631f7ae779717eef2953f15b5b34fe54679/Modules/_io/clinic/bytesio.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/137073/files
Please reload this pagehttps://github.com/python/cpython/pull/137073/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.