René's URL Explorer Experiment


Title: Revert "gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (#136893)" by JelleZijlstra · Pull Request #137014 · python/cpython · GitHub

Open Graph Title: Revert "gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (#136893)" by JelleZijlstra · Pull Request #137014 · python/cpython

X Title: Revert "gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (#136893)" by JelleZijlstra · Pull Request #137014 · python/cpython

Description: This reverts commit 46cbdf9. Issue: 3.14 regression: slot dataclasses classes leak original class #135228

Open Graph Description: This reverts commit 46cbdf9. Issue: 3.14 regression: slot dataclasses classes leak original class #135228

X Description: This reverts commit 46cbdf9. Issue: 3.14 regression: slot dataclasses classes leak original class #135228

Opengraph URL: https://github.com/python/cpython/pull/137014

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:10fc9425-f630-24e9-d9d1-4d0575dabe9b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE1C8:3DA736:2C533EB:3AE8E8F:696F1420
html-safe-noncec800292ff1a4ae54e1a69a712959faa43a00bbfe96575f9eea10b8a97bf8ed19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMUM4OjNEQTczNjoyQzUzM0VCOjNBRThFOEY6Njk2RjE0MjAiLCJ2aXNpdG9yX2lkIjoiMzIzMzEzMDMxOTk1NDUxNDk3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb83a0c04e364cdad0abc70fc5bb3bf8badf4e489f297286156659eb0ac75dead
hovercard-subject-tagpull_request:2686074192
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/137014/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/915fde9ff411fa7df21c738ef541688084b9ebaef0c7c94db7985d9ad3a22608/python/cpython/pull/137014
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/915fde9ff411fa7df21c738ef541688084b9ebaef0c7c94db7985d9ad3a22608/python/cpython/pull/137014
og:image:altThis reverts commit 46cbdf9. Issue: 3.14 regression: slot dataclasses classes leak original class #135228
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/137014#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137014
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137014
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/137014
Reloadhttps://github.com/python/cpython/pull/137014
Reloadhttps://github.com/python/cpython/pull/137014
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/137014
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.2k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/137014
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/137014#issue-comment-box
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:back-to-leakinghttps://github.com/JelleZijlstra/cpython/tree/back-to-leaking
Revert "gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (#136893)" https://github.com/python/cpython/pull/137014#top
JelleZijlstrahttps://github.com/JelleZijlstra
python:mainhttps://github.com/python/cpython/tree/main
JelleZijlstra:back-to-leakinghttps://github.com/JelleZijlstra/cpython/tree/back-to-leaking
Conversation 0 https://github.com/python/cpython/pull/137014
Commits 1 https://github.com/python/cpython/pull/137014/commits
Checks 41 https://github.com/python/cpython/pull/137014/checks
Files changed 3 https://github.com/python/cpython/pull/137014/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Jul 22, 2025https://github.com/python/cpython/pull/137014#issue-3253253523
Please reload this pagehttps://github.com/python/cpython/pull/137014
46cbdf9https://github.com/python/cpython/commit/46cbdf967ada11b0286060488b61635fd6a2bb23
3.14 regression: slot dataclasses classes leak original class #135228https://github.com/python/cpython/issues/135228
Please reload this pagehttps://github.com/python/cpython/pull/137014
https://github.com/JelleZijlstra
Revert "https://github.com/python/cpython/pull/137014/commits/7a083f3ae914ae03b7f181e0fe59d33b606564bd
pythongh-135228https://github.com/python/cpython/issues/135228
: Whenhttps://github.com/python/cpython/pull/137014/commits/7a083f3ae914ae03b7f181e0fe59d33b606564bd
@DataClasshttps://github.com/DataClass
(slots=True) replaces a datac…https://github.com/python/cpython/pull/137014/commits/7a083f3ae914ae03b7f181e0fe59d33b606564bd
7a083f3https://github.com/python/cpython/pull/137014/commits/7a083f3ae914ae03b7f181e0fe59d33b606564bd
python#136893https://github.com/python/cpython/pull/136893
46cbdf9https://github.com/JelleZijlstra/cpython/commit/46cbdf967ada11b0286060488b61635fd6a2bb23
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
ericvsmithhttps://github.com/ericvsmith
code ownerhttps://github.com/python/cpython/blob/a6678005587526dac969b4cadd016c7da14f018b/.github/CODEOWNERS#L245
July 22, 2025 16:00https://github.com/python/cpython/pull/137014#event-18755872325
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 22, 2025https://github.com/python/cpython/pull/137014#event-18755873461
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jul 22, 2025 https://github.com/python/cpython/pull/137014#ref-issue-3126086443
3.14 regression: slot dataclasses classes leak original class #135228 https://github.com/python/cpython/issues/135228
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
6a285f9https://github.com/python/cpython/commit/6a285f94c63f6e40ae1495d7efc61694d988e9ed
Jul 23, 2025https://github.com/python/cpython/pull/137014#event-18776850829
Please reload this pagehttps://github.com/python/cpython/pull/137014
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 23, 2025https://github.com/python/cpython/pull/137014#event-18776851970
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
July 23, 2025 15:13https://github.com/python/cpython/pull/137014#event-18776855323
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/137014#ref-commit-9df2cfe
https://github.com/JelleZijlstra
https://github.com/taegyunkim
Revert "https://github.com/taegyunkim/cpython/commit/9df2cfeaa45fafe4ecea51c81eb145f6693b1cbf
pythongh-135228https://github.com/python/cpython/issues/135228
: Whenhttps://github.com/taegyunkim/cpython/commit/9df2cfeaa45fafe4ecea51c81eb145f6693b1cbf
@DataClasshttps://github.com/DataClass
(slots=True) replaces a datac…https://github.com/taegyunkim/cpython/commit/9df2cfeaa45fafe4ecea51c81eb145f6693b1cbf
9df2cfehttps://github.com/taegyunkim/cpython/commit/9df2cfeaa45fafe4ecea51c81eb145f6693b1cbf
python#136893https://github.com/python/cpython/pull/136893
python#137014https://github.com/python/cpython/pull/137014
46cbdf9https://github.com/taegyunkim/cpython/commit/46cbdf967ada11b0286060488b61635fd6a2bb23
Agent-Hellboyhttps://github.com/Agent-Hellboy
Aug 19, 2025 https://github.com/python/cpython/pull/137014#ref-commit-b41a7bd
https://github.com/JelleZijlstra
https://github.com/Agent-Hellboy
Revert "https://github.com/Agent-Hellboy/cpython/commit/b41a7bd265c546995a8a66a433a954109c8bcac3
pythongh-135228https://github.com/python/cpython/issues/135228
: Whenhttps://github.com/Agent-Hellboy/cpython/commit/b41a7bd265c546995a8a66a433a954109c8bcac3
@DataClasshttps://github.com/DataClass
(slots=True) replaces a datac…https://github.com/Agent-Hellboy/cpython/commit/b41a7bd265c546995a8a66a433a954109c8bcac3
b41a7bdhttps://github.com/Agent-Hellboy/cpython/commit/b41a7bd265c546995a8a66a433a954109c8bcac3
python#136893https://github.com/python/cpython/pull/136893
python#137014https://github.com/python/cpython/pull/137014
46cbdf9https://github.com/Agent-Hellboy/cpython/commit/46cbdf967ada11b0286060488b61635fd6a2bb23
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137014
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/137014
https://github.com/JelleZijlstra
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.