René's URL Explorer Experiment


Title: [3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces… by JelleZijlstra · Pull Request #137013 · python/cpython · GitHub

Open Graph Title: [3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces… by JelleZijlstra · Pull Request #137013 · python/cpython

X Title: [3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces… by JelleZijlstra · Pull Request #137013 · python/cpython

Description: … a dataclass, make the original class collectible (GH-136893) (#136960)" This reverts commit 6e1b31b. Modifying the __dict__ is likely to cause crashes Issue: 3.14 regression: slot dataclasses ...

Open Graph Description: … a dataclass, make the original class collectible (GH-136893) (#136960)" This reverts commit 6e1b31b. Modifying the __dict__ is likely to cause crashes Issue: 3.14 regression: slot datacla...

X Description: … a dataclass, make the original class collectible (GH-136893) (#136960)" This reverts commit 6e1b31b. Modifying the __dict__ is likely to cause crashes Issue: 3.14 regression: slot dat...

Opengraph URL: https://github.com/python/cpython/pull/137013

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:360f3f02-14cf-6c24-05b0-cd38d4f09e88
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD152:73878:2BC8AD1:3A37833:696F13F3
html-safe-nonce691e18befa0095e01d01183c7883d6a00a4b802753515321c9290e82a8150470
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTUyOjczODc4OjJCQzhBRDE6M0EzNzgzMzo2OTZGMTNGMyIsInZpc2l0b3JfaWQiOiIyODk1Njg5NjAwMDk0NjM5MDkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6929b88ecec0c1d44512efd65b2544c9ad876af01be00c44170f3cc3c895677f
hovercard-subject-tagpull_request:2686069033
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/137013/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/e0253c82188b5012262bb99ce9f878b5ed9c2cb21d5841f77f7c90571cd4801a/python/cpython/pull/137013
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e0253c82188b5012262bb99ce9f878b5ed9c2cb21d5841f77f7c90571cd4801a/python/cpython/pull/137013
og:image:alt… a dataclass, make the original class collectible (GH-136893) (#136960)" This reverts commit 6e1b31b. Modifying the __dict__ is likely to cause crashes Issue: 3.14 regression: slot datacla...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJelleZijlstra
hostnamegithub.com
expected-hostnamegithub.com
Noneb278ad162d35332b6de714dfb005de04386c4d92df6475522bef910f491a35ee
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release39aed5006635ab6f45e6b77d23e73b08a00272a3
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/137013#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137013
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137013
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/137013
Reloadhttps://github.com/python/cpython/pull/137013
Reloadhttps://github.com/python/cpython/pull/137013
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/137013
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.2k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/137013
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/137013#issue-comment-box
hugovkhttps://github.com/hugovk
python:3.14https://github.com/python/cpython/tree/3.14
JelleZijlstra:no-fun-allowedhttps://github.com/JelleZijlstra/cpython/tree/no-fun-allowed
[3.14] Revert "[3.14] gh-135228: When @dataclass(slots=True) replaces… https://github.com/python/cpython/pull/137013#top
hugovkhttps://github.com/hugovk
python:3.14https://github.com/python/cpython/tree/3.14
JelleZijlstra:no-fun-allowedhttps://github.com/JelleZijlstra/cpython/tree/no-fun-allowed
Conversation 1 https://github.com/python/cpython/pull/137013
Commits 1 https://github.com/python/cpython/pull/137013/commits
Checks 45 https://github.com/python/cpython/pull/137013/checks
Files changed https://github.com/python/cpython/pull/137013/files
Please reload this pagehttps://github.com/python/cpython/pull/137013
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
Jul 22, 2025https://github.com/python/cpython/pull/137013#issue-3253247601
Please reload this pagehttps://github.com/python/cpython/pull/137013
GH-136893https://github.com/python/cpython/pull/136893
#136960https://github.com/python/cpython/pull/136960
6e1b31bhttps://github.com/python/cpython/commit/6e1b31b87e7a42c7911b517b78fc418217e6480c
3.14 regression: slot dataclasses classes leak original class #135228https://github.com/python/cpython/issues/135228
Please reload this pagehttps://github.com/python/cpython/pull/137013
https://github.com/JelleZijlstra
[3.14] Revert "[3.14]https://github.com/python/cpython/pull/137013/commits/58b43b2114e527ab136651a55272998ac72e7ac8
pythongh-135228https://github.com/python/cpython/issues/135228
: Whenhttps://github.com/python/cpython/pull/137013/commits/58b43b2114e527ab136651a55272998ac72e7ac8
@DataClasshttps://github.com/DataClass
(slots=True) re…https://github.com/python/cpython/pull/137013/commits/58b43b2114e527ab136651a55272998ac72e7ac8
58b43b2https://github.com/python/cpython/pull/137013/commits/58b43b2114e527ab136651a55272998ac72e7ac8
pythonGH-136893https://github.com/python/cpython/pull/136893
python#136960https://github.com/python/cpython/pull/136960
6e1b31bhttps://github.com/JelleZijlstra/cpython/commit/6e1b31b87e7a42c7911b517b78fc418217e6480c
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
ericvsmithhttps://github.com/ericvsmith
code ownerhttps://github.com/python/cpython/blob/591019e1f2345d2f7520569c78927add5950a5ef/.github/CODEOWNERS#L242
July 22, 2025 15:58https://github.com/python/cpython/pull/137013#event-18755834243
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 22, 2025https://github.com/python/cpython/pull/137013#event-18755835393
3.14 regression: slot dataclasses classes leak original class #135228 https://github.com/python/cpython/issues/135228
[3.14] gh-135228: When @dataclass(slots=True) replaces a dataclass, make the original class collectible (GH-136893) #136960 https://github.com/python/cpython/pull/136960
https://github.com/JelleZijlstra
JelleZijlstrahttps://github.com/JelleZijlstra
hugovkhttps://github.com/hugovk
Jul 22, 2025https://github.com/python/cpython/pull/137013#event-18756030561
https://github.com/hugovk
hugovkhttps://github.com/hugovk
Jul 22, 2025 https://github.com/python/cpython/pull/137013#pullrequestreview-3043779602
View reviewed changes https://github.com/python/cpython/pull/137013/files/58b43b2114e527ab136651a55272998ac72e7ac8
hugovkhttps://github.com/hugovk
https://github.com/python/cpython/pull/137013#pullrequestreview-3043779602
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/137013
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jul 22, 2025https://github.com/python/cpython/pull/137013#event-18756056971
https://github.com/hugovk
hugovkhttps://github.com/hugovk
July 22, 2025 16:11https://github.com/python/cpython/pull/137013#event-18756058182
https://github.com/hugovk
hugovkhttps://github.com/hugovk
70990edhttps://github.com/python/cpython/commit/70990ed5cad5b886a7f595923724706a222c5945
Jul 22, 2025https://github.com/python/cpython/pull/137013#event-18756273156
Please reload this pagehttps://github.com/python/cpython/pull/137013
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jul 22, 2025https://github.com/python/cpython/pull/137013#event-18756273975
kumaraditya303https://github.com/kumaraditya303
Sep 9, 2025 https://github.com/python/cpython/pull/137013#ref-commit-bba0a52
https://github.com/JelleZijlstra
https://github.com/kumaraditya303
[3.14] Revert "[3.14]https://github.com/miss-islington/cpython/commit/bba0a52e4078eb23d36ccda996b274b778ed2349
pythongh-135228https://github.com/python/cpython/issues/135228
: Whenhttps://github.com/miss-islington/cpython/commit/bba0a52e4078eb23d36ccda996b274b778ed2349
@DataClasshttps://github.com/DataClass
(slots=True) re…https://github.com/miss-islington/cpython/commit/bba0a52e4078eb23d36ccda996b274b778ed2349
bba0a52https://github.com/miss-islington/cpython/commit/bba0a52e4078eb23d36ccda996b274b778ed2349
python#137013https://github.com/python/cpython/pull/137013
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F137013
https://github.com/hugovk
hugovk https://github.com/hugovk
https://github.com/python/cpython/pull/137013/files/58b43b2114e527ab136651a55272998ac72e7ac8
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
https://github.com/hugovk
hugovk https://github.com/hugovk
Please reload this pagehttps://github.com/python/cpython/pull/137013
https://github.com/JelleZijlstra
https://github.com/hugovk
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.