René's URL Explorer Experiment


Title: bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types by encukou · Pull Request #13699 · python/cpython · GitHub

Open Graph Title: bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types by encukou · Pull Request #13699 · python/cpython

X Title: bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types by encukou · Pull Request #13699 · python/cpython

Description: When inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call does not work for it. This attempts to solve the issue by: always inheriting tp_vectorcall_offset unless tp_call is overridden in the subclass inheriting _Py_TPFLAGS_HAVE_VECTORCALL for static types, unless tp_call is overridden making PyVectorcall_Call ignore _Py_TPFLAGS_HAVE_VECTORCALL This means it'll be ever more important to only call PyVectorcall_Call on classes that support vectorcall. In PyVectorcall_Call's intended role as tp_call filler, that's not a problem. cc @jdemeyer (not Mark, as he seemed to want to stay out of subclassing – but he's nosy on the issue) https://bugs.python.org/issue36974

Open Graph Description: When inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call ...

X Description: When inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call ...

Opengraph URL: https://github.com/python/cpython/pull/13699

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:721483c5-1016-1e6b-7f9d-1b1be2160d2a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CC0:FC5BE:34E6AE1:4648390:6B01FE2B
html-safe-nonce7990a782663724be149f816bfb234a86fd9659c4341d8cd7e1f638460fe662fb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0MwOkZDNUJFOjM0RTZBRTE6NDY0ODM5MDo2QjAxRkUyQiIsInZpc2l0b3JfaWQiOiIzMTA1MjAzMTM4NTIxNTk1NDM1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccc8d61d44a46ae92ade950495684f83d893b86874797ff3a8693da7daef0fdba
hovercard-subject-tagpull_request:284066954
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/13699/files
twitter:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/302922?s=400&v=4
og:image:altWhen inheriting a heap subclass from a vectorcall class that sets .tp_call=PyVectorcall_Call (as recommended), the subclass does not inherit _Py_TPFLAGS_HAVE_VECTORCALL, and thus PyVectorcall_Call ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13699/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13699%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13699%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13699/files
Reloadhttps://github.com/python/cpython/pull/13699/files
Reloadhttps://github.com/python/cpython/pull/13699/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:pep590inherithttps://github.com/encukou/cpython/tree/pep590inherit
Conversation 3 https://github.com/python/cpython/pull/13699
Commits 2 https://github.com/python/cpython/pull/13699/commits
Checks 0 https://github.com/python/cpython/pull/13699/checks
Files changed https://github.com/python/cpython/pull/13699/files
Please reload this pagehttps://github.com/python/cpython/pull/13699/files
bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types https://github.com/python/cpython/pull/13699/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/13699/files
eb8fca9 bpo-36974: Make tp_call=PyVectorcall_Call work for inherited types encukou May 31, 2019 https://github.com/python/cpython/pull/13699/commits/eb8fca988472c66b9051df863ef28fa85e87d5f1
73bef62 inherit_slots: Group code related to tp_call/vectorcall inheritance encukou Jun 2, 2019 https://github.com/python/cpython/pull/13699/commits/73bef62492ee5f1b26851052ca7328a6d5f72670
Clear filters https://github.com/python/cpython/pull/13699/files
Please reload this pagehttps://github.com/python/cpython/pull/13699/files
Please reload this pagehttps://github.com/python/cpython/pull/13699/files
test_capi.py https://github.com/python/cpython/pull/13699/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
_testcapimodule.c https://github.com/python/cpython/pull/13699/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
call.c https://github.com/python/cpython/pull/13699/files#diff-b876797aa8c96d633b0b869447e7e14da64b9f53e48561149446939e7c6257e9
typeobject.c https://github.com/python/cpython/pull/13699/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Lib/test/test_capi.pyhttps://github.com/python/cpython/pull/13699/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
View file https://github.com/encukou/cpython/blob/73bef62492ee5f1b26851052ca7328a6d5f72670/Lib/test/test_capi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13699/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13699/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
https://github.com/python/cpython/pull/13699/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
https://github.com/python/cpython/pull/13699/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
https://github.com/python/cpython/pull/13699/files#diff-a537c794ffb51531649e2b81f9ae6978c25077de6aa10c9134576ac628fcc345
Modules/_testcapimodule.chttps://github.com/python/cpython/pull/13699/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
View file https://github.com/encukou/cpython/blob/73bef62492ee5f1b26851052ca7328a6d5f72670/Modules/_testcapimodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13699/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13699/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
https://github.com/python/cpython/pull/13699/files#diff-b2d7540efa4f376350ef77b923a6dfcc54bb90424970477f66275f19bad0d30f
Objects/call.chttps://github.com/python/cpython/pull/13699/files#diff-b876797aa8c96d633b0b869447e7e14da64b9f53e48561149446939e7c6257e9
View file https://github.com/encukou/cpython/blob/73bef62492ee5f1b26851052ca7328a6d5f72670/Objects/call.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13699/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13699/files#diff-b876797aa8c96d633b0b869447e7e14da64b9f53e48561149446939e7c6257e9
https://github.com/python/cpython/pull/13699/files#diff-b876797aa8c96d633b0b869447e7e14da64b9f53e48561149446939e7c6257e9
Objects/typeobject.chttps://github.com/python/cpython/pull/13699/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
View file https://github.com/encukou/cpython/blob/73bef62492ee5f1b26851052ca7328a6d5f72670/Objects/typeobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/13699/{{ revealButtonHref }}
https://github.com/python/cpython/pull/13699/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com/python/cpython/pull/13699/files#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.