Title: gh-135621: Simplify TermInfo by encukou · Pull Request #136916 · python/cpython · GitHub
Open Graph Title: gh-135621: Simplify TermInfo by encukou · Pull Request #136916 · python/cpython
X Title: gh-135621: Simplify TermInfo by encukou · Pull Request #136916 · python/cpython
Description: _pyrepl.terminfo's terminfo parsing follows ncurses and does a bunch of unnecessary (and untested) work. It can be simplified: Don't parse names, booleans, and numbers. (I hope I left enough code & comments to make it easy to add these if needed.) Don't store the strings as a list; populate the dict directly. Use struct.iter_unpack and string_table.find instead of for loops Issue: gh-135621
Open Graph Description: _pyrepl.terminfo's terminfo parsing follows ncurses and does a bunch of unnecessary (and untested) work. It can be simplified: Don't parse names, booleans, and numbers. (I hope I left enou...
X Description: _pyrepl.terminfo's terminfo parsing follows ncurses and does a bunch of unnecessary (and untested) work. It can be simplified: Don't parse names, booleans, and numbers. (I hope I l...
Opengraph URL: https://github.com/python/cpython/pull/136916
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:92a5d8f9-1880-f793-0ee2-225354f7fee1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A6D2:1B00D1:CBEEEE:10D032A:6A5195D4 |
| html-safe-nonce | dca818964365ce0e0ebd7f9e8512d07c4087c71e1fabef5c72df900f68fdd7b5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNkQyOjFCMDBEMTpDQkVFRUU6MTBEMDMyQTo2QTUxOTVENCIsInZpc2l0b3JfaWQiOiIxMDIxMTcyMTQ3NjM1MTk3Mzk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7a57b30526a28c88ae224ea435722f16733f07faa85f4378c3ff8c69e4e3aa7b |
| hovercard-subject-tag | pull_request:2681323432 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/136916/files |
| twitter:image | https://avatars.githubusercontent.com/u/302922?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302922?s=400&v=4 |
| og:image:alt | _pyrepl.terminfo's terminfo parsing follows ncurses and does a bunch of unnecessary (and untested) work. It can be simplified: Don't parse names, booleans, and numbers. (I hope I left enou... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width