René's URL Explorer Experiment


Title: bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None by ZackerySpytz · Pull Request #13688 · python/cpython · GitHub

Open Graph Title: bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None by ZackerySpytz · Pull Request #13688 · python/cpython

X Title: bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None by ZackerySpytz · Pull Request #13688 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: msilib.Directory.start_component() was passing an extra argument to CAB.gen_id(). https://bugs.python.org/issue12639

X Description: msilib.Directory.start_component() was passing an extra argument to CAB.gen_id(). https://bugs.python.org/issue12639

Opengraph URL: https://github.com/python/cpython/pull/13688

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:944b02e0-c032-2697-fe20-5e91a9ffa1a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE48C:73D9:CBA7ED:12A0D9D:6A4E290E
html-safe-noncefb436e5a18a5cc76c5fba6aaed86a1deeece2f852e6f489c8dc210758f06bd0d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNDhDOjczRDk6Q0JBN0VEOjEyQTBEOUQ6NkE0RTI5MEUiLCJ2aXNpdG9yX2lkIjoiNzI2NTg1MDEwNDAzNjA3NTc5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb59fbf30e7ae882cfa4c48ddd6d3f024b37b69c27952088e524c5018d69c03d8
hovercard-subject-tagpull_request:283834700
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13688/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aaabebe254f71ba1347f20383c0e449a9c8de76032537f8238f4caabf125e4b8/python/cpython/pull/13688
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aaabebe254f71ba1347f20383c0e449a9c8de76032537f8238f4caabf125e4b8/python/cpython/pull/13688
og:image:altmsilib.Directory.start_component() was passing an extra argument to CAB.gen_id(). https://bugs.python.org/issue12639
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameZackerySpytz
hostnamegithub.com
expected-hostnamegithub.com
None030096ee0db095447bfe77409d33bfac127ca7128299c58deef27c52eaa1b1f0
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released9dd20d38f8ae3c4cb6b597807431db300d0bd2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13688#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13688
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13688
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13688
Reloadhttps://github.com/python/cpython/pull/13688
Reloadhttps://github.com/python/cpython/pull/13688
Please reload this pagehttps://github.com/python/cpython/pull/13688
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13688
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
ZackerySpytz:bpo-12639-msilib-start_component-keyfilehttps://github.com/ZackerySpytz/cpython/tree/bpo-12639-msilib-start_component-keyfile
Conversationhttps://github.com/python/cpython/pull/13688
Commits1 (1)https://github.com/python/cpython/pull/13688/commits
Checkshttps://github.com/python/cpython/pull/13688/checks
Files changedhttps://github.com/python/cpython/pull/13688/files
bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not Nonehttps://github.com/python/cpython/pull/13688#top
zoobahttps://github.com/zooba
python:masterhttps://github.com/python/cpython/tree/master
ZackerySpytz:bpo-12639-msilib-start_component-keyfilehttps://github.com/ZackerySpytz/cpython/tree/bpo-12639-msilib-start_component-keyfile
https://github.com/ZackerySpytz
ZackerySpytzhttps://github.com/ZackerySpytz
May 30, 2019https://github.com/python/cpython/pull/13688#issue-450533399
Please reload this pagehttps://github.com/python/cpython/pull/13688
https://bugs.python.org/issue12639https://bugs.python.org/issue12639
Please reload this pagehttps://github.com/python/cpython/pull/13688
https://github.com/ZackerySpytz
bpo-12639: msilib.Directory.start_component() fails if *keyfile* is n…https://github.com/python/cpython/pull/13688/commits/0d2f46f42fc31fc0ca9d3d6b01589eeeeeb0ece7
0d2f46fhttps://github.com/python/cpython/pull/13688/commits/0d2f46f42fc31fc0ca9d3d6b01589eeeeeb0ece7
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 30, 2019https://github.com/python/cpython/pull/13688#event-2379474474
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 30, 2019https://github.com/python/cpython/pull/13688#event-2379474500
https://github.com/auvipy
auvipyhttps://github.com/auvipy
May 31, 2019 https://github.com/python/cpython/pull/13688#pullrequestreview-244132938
View reviewed changes https://github.com/python/cpython/pull/13688/files/0d2f46f42fc31fc0ca9d3d6b01589eeeeeb0ece7
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 31, 2019https://github.com/python/cpython/pull/13688#event-2379931245
https://github.com/zooba
zoobahttps://github.com/zooba
c8d5bf6https://github.com/python/cpython/commit/c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c
May 31, 2019https://github.com/python/cpython/pull/13688#event-2381545279
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 31, 2019https://github.com/python/cpython/pull/13688#event-2381545379
https://github.com/zooba
zoobahttps://github.com/zooba
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
May 31, 2019https://github.com/python/cpython/pull/13688#event-2381545785
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 31, 2019https://github.com/python/cpython/pull/13688#issuecomment-497779468
@ZackerySpytzhttps://github.com/ZackerySpytz
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/13688
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 31, 2019https://github.com/python/cpython/pull/13688#issuecomment-497779469
@ZackerySpytzhttps://github.com/ZackerySpytz
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/13688
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 31, 2019https://github.com/python/cpython/pull/13688#issuecomment-497779471
@ZackerySpytzhttps://github.com/ZackerySpytz
@zoobahttps://github.com/zooba
Please reload this pagehttps://github.com/python/cpython/pull/13688
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 31, 2019https://github.com/python/cpython/pull/13688#issuecomment-497779575
GH-13703https://github.com/python/cpython/pull/13703
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/13688
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
May 31, 2019https://github.com/python/cpython/pull/13688#event-2381546419
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 31, 2019https://github.com/python/cpython/pull/13688#issuecomment-497779646
GH-13704https://github.com/python/cpython/pull/13704
2.7 branchhttps://github.com/python/cpython/tree/2.7
Please reload this pagehttps://github.com/python/cpython/pull/13688
miss-islingtonhttps://github.com/miss-islington
May 31, 2019 https://github.com/python/cpython/pull/13688#ref-commit-33b7ed4
https://github.com/ZackerySpytz
https://github.com/miss-islington
bpo-12639: msilib.Directory.start_component() fails if *keyfile* is n…https://github.com/miss-islington/cpython/commit/33b7ed40bb35c638d4c41e87b94074f1234e460f
33b7ed4https://github.com/miss-islington/cpython/commit/33b7ed40bb35c638d4c41e87b94074f1234e460f
pythonGH-13688https://github.com/python/cpython/pull/13688
c8d5bf6https://github.com/miss-islington/cpython/commit/c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
May 31, 2019https://github.com/python/cpython/pull/13688#event-2381547099
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 31, 2019https://github.com/python/cpython/pull/13688#issuecomment-497779714
GH-13705https://github.com/python/cpython/pull/13705
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/13688
miss-islingtonhttps://github.com/miss-islington
May 31, 2019 https://github.com/python/cpython/pull/13688#ref-commit-b7d6c11
https://github.com/ZackerySpytz
https://github.com/miss-islington
bpo-12639: msilib.Directory.start_component() fails if *keyfile* is n…https://github.com/miss-islington/cpython/commit/b7d6c1195ced587e81e95fca66d21f69582856df
b7d6c11https://github.com/miss-islington/cpython/commit/b7d6c1195ced587e81e95fca66d21f69582856df
pythonGH-13688https://github.com/python/cpython/pull/13688
c8d5bf6https://github.com/miss-islington/cpython/commit/c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c
miss-islingtonhttps://github.com/miss-islington
May 31, 2019 https://github.com/python/cpython/pull/13688#ref-commit-fba11b8
https://github.com/ZackerySpytz
https://github.com/miss-islington
bpo-12639: msilib.Directory.start_component() fails if *keyfile* is n…https://github.com/miss-islington/cpython/commit/fba11b815e2661b6c6b37247e0eadfa24863fc43
fba11b8https://github.com/miss-islington/cpython/commit/fba11b815e2661b6c6b37247e0eadfa24863fc43
pythonGH-13688https://github.com/python/cpython/pull/13688
c8d5bf6https://github.com/miss-islington/cpython/commit/c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c
miss-islingtonhttps://github.com/miss-islington
May 31, 2019 https://github.com/python/cpython/pull/13688#ref-commit-49fc57a
https://github.com/miss-islington
https://github.com/ZackerySpytz
bpo-12639https://bugs.python.org/issue?@action=redirect&bpo=12639
: msilib.Directory.start_component() fails if *keyfile* is n…https://github.com/python/cpython/commit/49fc57abf5fcf60129e460046d78c9bf20a19931
49fc57ahttps://github.com/python/cpython/commit/49fc57abf5fcf60129e460046d78c9bf20a19931
GH-13688https://github.com/python/cpython/pull/13688
c8d5bf6https://github.com/python/cpython/commit/c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c
zoobahttps://github.com/zooba
May 31, 2019 https://github.com/python/cpython/pull/13688#ref-commit-bfc1f60
https://github.com/miss-islington
https://github.com/ZackerySpytz
https://github.com/zooba
[2.7]https://github.com/python/cpython/commit/bfc1f605609218b9734d3cf3eab3531a2f4624e1
bpo-12639https://bugs.python.org/issue?@action=redirect&bpo=12639
: msilib.Directory.start_component() fails if *keyfile…https://github.com/python/cpython/commit/bfc1f605609218b9734d3cf3eab3531a2f4624e1
bfc1f60https://github.com/python/cpython/commit/bfc1f605609218b9734d3cf3eab3531a2f4624e1
GH-13688https://github.com/python/cpython/pull/13688
bpo-12639https://bugs.python.org/issue?@action=redirect&bpo=12639
GH-13688https://github.com/python/cpython/pull/13688
c8d5bf6https://github.com/python/cpython/commit/c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c
https://github.com/ZackerySpytz
ZackerySpytzhttps://github.com/ZackerySpytz
Jun 1, 2019 https://github.com/python/cpython/pull/13688#ref-pullrequest-450995334
bpo-12202: Properly check MsiSummaryInfoGetProperty() calls in msilib #13711 https://github.com/python/cpython/pull/13711
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Jun 1, 2019https://github.com/python/cpython/pull/13688#issuecomment-497957062
https://buildbot.python.org/all/#/builders/132/builds/505/steps/4/logs/stdiohttps://buildbot.python.org/all/#/builders/132/builds/505/steps/4/logs/stdio
https://buildbot.python.org/all/#/builders/33/builds/604https://buildbot.python.org/all/#/builders/33/builds/604
Please reload this pagehttps://github.com/python/cpython/pull/13688
DinoVhttps://github.com/DinoV
Jan 14, 2020 https://github.com/python/cpython/pull/13688#ref-commit-4ab3dbb
https://github.com/ZackerySpytz
https://github.com/DinoV
bpo-12639: msilib.Directory.start_component() fails if *keyfile* is n…https://github.com/DinoV/cpython/commit/4ab3dbb116fc6de4076a9e63e3db4c65587e7fd1
4ab3dbbhttps://github.com/DinoV/cpython/commit/4ab3dbb116fc6de4076a9e63e3db4c65587e7fd1
pythonGH-13688https://github.com/python/cpython/pull/13688
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13688
https://github.com/auvipy
auvipy https://github.com/auvipy
https://github.com/python/cpython/pull/13688/files/0d2f46f42fc31fc0ca9d3d6b01589eeeeeb0ece7
Please reload this pagehttps://github.com/python/cpython/pull/13688
https://github.com/ZackerySpytz
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/pablogsal
https://github.com/auvipy
https://github.com/zooba
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.