René's URL Explorer Experiment


Title: bpo-37015: Ensure tasks created by _accept_connection2 due to AsyncMock are completed by tirkarthi · Pull Request #13661 · python/cpython · GitHub

Open Graph Title: bpo-37015: Ensure tasks created by _accept_connection2 due to AsyncMock are completed by tirkarthi · Pull Request #13661 · python/cpython

X Title: bpo-37015: Ensure tasks created by _accept_connection2 due to AsyncMock are completed by tirkarthi · Pull Request #13661 · python/cpython

Description: From 3.8 async functions used with mock.patch return an AsyncMock. _accept_connection2 is an async function where create_task is also mocked. Don't mock create_task so that tasks are created out of...

Open Graph Description: From 3.8 async functions used with mock.patch return an AsyncMock. _accept_connection2 is an async function where create_task is also mocked. Don't mock create_task so that tasks are created ou...

X Description: From 3.8 async functions used with mock.patch return an AsyncMock. _accept_connection2 is an async function where create_task is also mocked. Don't mock create_task so that tasks are create...

Opengraph URL: https://github.com/python/cpython/pull/13661

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3075c42a-b698-79b8-d4a4-99ee94fe82a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA5D6:1FC3E6:23329C:319A22:696A0676
html-safe-nonceae5c7b52fded37bf73c2a47475ac95564b36890b78ef26fd117b11669ee9df34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNUQ2OjFGQzNFNjoyMzMyOUM6MzE5QTIyOjY5NkEwNjc2IiwidmlzaXRvcl9pZCI6IjMzNDAyMDA5MzcwOTc4MDU5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6edd374cb7f96e63c4566706bcd6c1814f109e0e14f1cddf5c00896d36061031
hovercard-subject-tagpull_request:283390782
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/13661/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f5b1c29a3b1b3d46989319b31ad27d244f5bd9860ad18acf6b77a7c97a78c255/python/cpython/pull/13661
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f5b1c29a3b1b3d46989319b31ad27d244f5bd9860ad18acf6b77a7c97a78c255/python/cpython/pull/13661
og:image:altFrom 3.8 async functions used with mock.patch return an AsyncMock. _accept_connection2 is an async function where create_task is also mocked. Don't mock create_task so that tasks are created ou...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametirkarthi
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/13661#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13661
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13661
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/13661
Reloadhttps://github.com/python/cpython/pull/13661
Reloadhttps://github.com/python/cpython/pull/13661
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/13661
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/13661
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/13661#issue-comment-box
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo37015https://github.com/tirkarthi/cpython/tree/bpo37015
bpo-37015: Ensure tasks created by _accept_connection2 due to AsyncMock are completed https://github.com/python/cpython/pull/13661#top
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
tirkarthi:bpo37015https://github.com/tirkarthi/cpython/tree/bpo37015
Conversation 6 https://github.com/python/cpython/pull/13661
Commits 3 https://github.com/python/cpython/pull/13661/commits
Checks 0 https://github.com/python/cpython/pull/13661/checks
Files changed https://github.com/python/cpython/pull/13661/files
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
May 29, 2019https://github.com/python/cpython/pull/13661#issue-449970518
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://bugs.python.org/issue37015https://bugs.python.org/issue37015
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://github.com/tirkarthi
Use MagicMock for _accept_connection2 which is an async function not …https://github.com/python/cpython/pull/13661/commits/5e06482b8c953a79bc13b17470a1752c457d3721
5e06482https://github.com/python/cpython/pull/13661/commits/5e06482b8c953a79bc13b17470a1752c457d3721
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/0c2f9305640f7655ba0cd5f478948b2763b376b3/.github/CODEOWNERS#L8
May 29, 2019 19:00https://github.com/python/cpython/pull/13661#event-2376136575
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 29, 2019https://github.com/python/cpython/pull/13661#event-2376136763
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 29, 2019https://github.com/python/cpython/pull/13661#event-2376136846
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
May 29, 2019https://github.com/python/cpython/pull/13661#issuecomment-497069677
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
May 29, 2019https://github.com/python/cpython/pull/13661#event-2376373422
https://github.com/mariocj89
mariocj89https://github.com/mariocj89
May 29, 2019 https://github.com/python/cpython/pull/13661#pullrequestreview-243507254
View reviewed changes https://github.com/python/cpython/pull/13661/files/5e06482b8c953a79bc13b17470a1752c457d3721
Lib/test/test_asyncio/test_selector_events.pyhttps://github.com/python/cpython/pull/13661/files/5e06482b8c953a79bc13b17470a1752c457d3721#diff-6e37e524632f0e5f40ac46ea06ed508dc3b08f9ec1e8c07cf97537913f056a6b
mariocj89https://github.com/mariocj89
May 29, 2019https://github.com/python/cpython/pull/13661#discussion_r288760296
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13661
tirkarthihttps://github.com/tirkarthi
May 30, 2019https://github.com/python/cpython/pull/13661#discussion_r288840765
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://docs.python.org/3/library/unittest.mock.html#patchhttps://docs.python.org/3/library/unittest.mock.html#patch
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 29, 2019https://github.com/python/cpython/pull/13661#event-2376398298
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
May 29, 2019https://github.com/python/cpython/pull/13661#issuecomment-497113116
Please reload this pagehttps://github.com/python/cpython/pull/13661
tirkarthihttps://github.com/tirkarthi
May 30, 2019 08:14https://github.com/python/cpython/pull/13661#commits-pushed-39ddfcf
https://github.com/tirkarthi
Ensure tasks created out of _accept_connection2 patched as AsyncMock …https://github.com/python/cpython/pull/13661/commits/39ddfcfe24a401de051c0c072a6b163f1f91f937
39ddfcfhttps://github.com/python/cpython/pull/13661/commits/39ddfcfe24a401de051c0c072a6b163f1f91f937
https://github.com/tirkarthi
Fix whitespace errorhttps://github.com/python/cpython/pull/13661/commits/dfc83bbc253a50784e8639d29b9ea34cc7f9ab39
dfc83bbhttps://github.com/python/cpython/pull/13661/commits/dfc83bbc253a50784e8639d29b9ea34cc7f9ab39
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
May 30, 2019https://github.com/python/cpython/pull/13661#issuecomment-497185763
@asvetlovhttps://github.com/asvetlov
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://github.com/tirkarthi
tirkarthihttps://github.com/tirkarthi
May 30, 2019https://github.com/python/cpython/pull/13661#event-2377000711
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
May 30, 2019 https://github.com/python/cpython/pull/13661#pullrequestreview-243717405
View reviewed changes https://github.com/python/cpython/pull/13661/files/dfc83bbc253a50784e8639d29b9ea34cc7f9ab39
asvetlovhttps://github.com/asvetlov
https://github.com/python/cpython/pull/13661#pullrequestreview-243717405
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 30, 2019https://github.com/python/cpython/pull/13661#event-2377652483
https://github.com/asvetlov
asvetlovhttps://github.com/asvetlov
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
May 30, 2019https://github.com/python/cpython/pull/13661#event-2377652893
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
0f39c2bhttps://github.com/python/cpython/commit/0f39c2b1919727904f4fac2d79cb41dc6bfe41fe
May 30, 2019https://github.com/python/cpython/pull/13661#event-2377653044
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 30, 2019https://github.com/python/cpython/pull/13661#event-2377653165
DinoVhttps://github.com/DinoV
Jan 14, 2020 https://github.com/python/cpython/pull/13661#ref-commit-16472c6
https://github.com/tirkarthi
https://github.com/DinoV
bpo-37015: Ensure tasks created by _accept_connection2 due to AsyncMo…https://github.com/DinoV/cpython/commit/16472c6205d0ab05cd2057dded2e67b01cdf8ebc
16472c6https://github.com/DinoV/cpython/commit/16472c6205d0ab05cd2057dded2e67b01cdf8ebc
pythonGH-13661https://github.com/python/cpython/pull/13661
https://bugs.python.org/issue37015https://bugs.python.org/issue37015
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13661
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/python/cpython/pull/13661/files/dfc83bbc253a50784e8639d29b9ea34cc7f9ab39
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/mariocj89
mariocj89 https://github.com/mariocj89
https://github.com/python/cpython/pull/13661/files/5e06482b8c953a79bc13b17470a1752c457d3721
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/13661
https://github.com/tirkarthi
https://github.com/asvetlov
https://github.com/mariocj89
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/miss-islington
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.