Title: gh-136438: Make sure `test_builtins` pass with all optimization levels by sobolevn · Pull Request #136474 · python/cpython · GitHub
Open Graph Title: gh-136438: Make sure `test_builtins` pass with all optimization levels by sobolevn · Pull Request #136474 · python/cpython
X Title: gh-136438: Make sure `test_builtins` pass with all optimization levels by sobolevn · Pull Request #136474 · python/cpython
Description: Now tests pass with all combinations of -OO and --without-doc-strings. Before: ====================================================================== FAIL: test_compile (test.test_builtin.BuiltinTest.test_compile) (optval=0) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/Lib/test/test_builtin.py", line 445, in test_compile self.assertEqual(rv, tuple(expected)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^ AssertionError: Tuples differ: (True, None, True, True) != (True, 'doc', True, True) First differing element 1: None 'doc' - (True, None, True, True) ? ^ ^^ + (True, 'doc', True, True) ? ^^ ^^ ====================================================================== FAIL: test_compile (test.test_builtin.BuiltinTest.test_compile) (optval=1) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/Lib/test/test_builtin.py", line 445, in test_compile self.assertEqual(rv, tuple(expected)) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^ AssertionError: Tuples differ: (False, None, False, False) != (False, 'doc', False, False) First differing element 1: None 'doc' - (False, None, False, False) ? ^ ^^ + (False, 'doc', False, False) ? ^^ ^^ ====================================================================== FAIL: test_compile_ast (test.test_builtin.BuiltinTest.test_compile_ast) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/sobolev/Desktop/cpython/Lib/test/test_builtin.py", line 627, in test_compile_ast self.assertEqual(opt_right.value, True) ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^ AssertionError: False != True ---------------------------------------------------------------------- Ran 131 tests in 0.211s Issue: gh-136438
Open Graph Description: Now tests pass with all combinations of -OO and --without-doc-strings. Before: ====================================================================== FAIL: test_compile (test.test_builtin.BuiltinTe...
X Description: Now tests pass with all combinations of -OO and --without-doc-strings. Before: ====================================================================== FAIL: test_compile (test.test_builtin.BuiltinTe...
Opengraph URL: https://github.com/python/cpython/pull/136474
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files/:range(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6c26c728-8624-e104-26c1-850bc045ea01 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B58:1A81C4:8319D7C:B28978D:699623FC |
| html-safe-nonce | 2aaaf24a0affae4efd80d080331efe215b749965e23e532d9c7facd018af6b10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjU4OjFBODFDNDo4MzE5RDdDOkIyODk3OEQ6Njk5NjIzRkMiLCJ2aXNpdG9yX2lkIjoiMTUyOTc0NjUwNTExMTgzOTc0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ce6ca8ca323355b083bd6a6616d886f500b15b8bbadd154b5a6f51b24f681f42 |
| hovercard-subject-tag | pull_request:2653332606 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/136474/files/e670cadb6561f826e92cc27dc043d5f8be763dc2 |
| twitter:image | https://avatars.githubusercontent.com/u/4660275?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4660275?s=400&v=4 |
| og:image:alt | Now tests pass with all combinations of -OO and --without-doc-strings. Before: ====================================================================== FAIL: test_compile (test.test_builtin.BuiltinTe... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 979c1ab77a40e0dbb8d76f1c427190824693a0e72e7a954636654843f3881905 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1605bed97fda6bdbde604a211037a953da95d035 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width