| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e08aaf0e-3d1f-b4d3-b4ab-b308f34be264 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D1A0:1672C1:21903CF:2BF26CE:696B4DB4 |
| html-safe-nonce | e79f7e7ef3d9ff84088e9bf6f8cfc0501eb6fbf0a3be7373c2b99f834c9659a4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUEwOjE2NzJDMToyMTkwM0NGOjJCRjI2Q0U6Njk2QjREQjQiLCJ2aXNpdG9yX2lkIjoiMTY4MjIxMDI2MzQ5OTc1NDkzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 6aa0b774cdddf5c29ea71b77bc4334a9e075f8f5ebd1c4b443fa651dd861fd66 |
| hovercard-subject-tag | pull_request:2642267113 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/136304/files |
| twitter:image | https://avatars.githubusercontent.com/u/67315?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/67315?s=400&v=4 |
| og:image:alt | Tests for #136189
Issue: gh-135552 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/136304/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F136304%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F136304%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/136304/files |
| Reload | https://github.com/python/cpython/pull/136304/files |
| Reload | https://github.com/python/cpython/pull/136304/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/136304/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/136304/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| nascheme | https://github.com/nascheme |
| python:main | https://github.com/python/cpython/tree/main |
| sergey-miryanov:gh-135552-add-tests-gc-weakref-tp_subclasses | https://github.com/sergey-miryanov/cpython/tree/gh-135552-add-tests-gc-weakref-tp_subclasses |
|
Conversation
11
| https://github.com/python/cpython/pull/136304 |
|
Commits
13
| https://github.com/python/cpython/pull/136304/commits |
|
Checks
38
| https://github.com/python/cpython/pull/136304/checks |
|
Files changed
| https://github.com/python/cpython/pull/136304/files |
| Please reload this page | https://github.com/python/cpython/pull/136304/files |
|
gh-135552: Add tests that check if weakref for tp_subclasses cleared after finalization
| https://github.com/python/cpython/pull/136304/files#top |
|
Show all changes
13 commits
| https://github.com/python/cpython/pull/136304/files |
|
4d648b4
Add tests
fxeqxmulfx Jun 22, 2025
| https://github.com/python/cpython/pull/136304/commits/4d648b48aaabb1bf0cf76414d1ac629cadaf7534 |
|
77e9ca7
Organize tests
sergey-miryanov Jun 22, 2025
| https://github.com/python/cpython/pull/136304/commits/77e9ca7b9a0b5c5aed790735d7653120d34516e0 |
|
b6825da
Simplify tests
sergey-miryanov Jun 24, 2025
| https://github.com/python/cpython/pull/136304/commits/b6825da9df07a27a19a8ef36a870c8f0b46d5f29 |
|
f62d43e
Remove extra line
sergey-miryanov Jul 4, 2025
| https://github.com/python/cpython/pull/136304/commits/f62d43e6af2dc76a6c96f950ec3acce03e8dbf41 |
|
398c4f5
Add extra comments
sergey-miryanov Jul 4, 2025
| https://github.com/python/cpython/pull/136304/commits/398c4f58f5dd07746a5969d63676e509efa5669d |
|
7dd9669
Add tests for checking that weakrefs clears before and after finaliza…
sergey-miryanov Jul 4, 2025
| https://github.com/python/cpython/pull/136304/commits/7dd966925f469f715b1503bf44954ab002ac47d0 |
|
1da73b3
Make tests a little bit reliable
sergey-miryanov Jul 5, 2025
| https://github.com/python/cpython/pull/136304/commits/1da73b37fe813c77bae73adf9b29f4a898cf3cb8 |
|
0510539
Simplify tests
sergey-miryanov Jul 5, 2025
| https://github.com/python/cpython/pull/136304/commits/05105397ead70678bf2484f11772e845c038b407 |
|
50410d6
Use unittest asserts
sergey-miryanov Jul 6, 2025
| https://github.com/python/cpython/pull/136304/commits/50410d6b90ec8fd4a957678ada48431b648b1a22 |
|
aa18e74
Move test_clearing_weakrefs_in_gc to test_weakref
sergey-miryanov Jul 8, 2025
| https://github.com/python/cpython/pull/136304/commits/aa18e7431ec27e9049f2c7badc024469979d8591 |
|
7788e55
Apply suggestions from code review
sergey-miryanov Jul 8, 2025
| https://github.com/python/cpython/pull/136304/commits/7788e5537014c96d729c73d7982cf208c16deef5 |
|
d125d06
Merge branch 'main' into gh-135552-add-tests-gc-weakref-tp_subclasses
nascheme Aug 7, 2025
| https://github.com/python/cpython/pull/136304/commits/d125d06f762e60cdafd9ab9dbe34a650134a472c |
|
0339d54
Revise test_clearing_weakrefs_in_gc test
nascheme Aug 7, 2025
| https://github.com/python/cpython/pull/136304/commits/0339d544908326dfb5a9c0c3bb138f40b654c65f |
|
Clear filters
| https://github.com/python/cpython/pull/136304/files |
| Please reload this page | https://github.com/python/cpython/pull/136304/files |
| Please reload this page | https://github.com/python/cpython/pull/136304/files |
|
test_gc.py
| https://github.com/python/cpython/pull/136304/files#diff-9d9e863bd2a456b669ec9600be793699e861340d91d7c417a8a5b5b8cfbd09a7 |
|
test_weakref.py
| https://github.com/python/cpython/pull/136304/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575 |
| Lib/test/test_gc.py | https://github.com/python/cpython/pull/136304/files#diff-9d9e863bd2a456b669ec9600be793699e861340d91d7c417a8a5b5b8cfbd09a7 |
|
View file
| https://github.com/sergey-miryanov/cpython/blob/0339d544908326dfb5a9c0c3bb138f40b654c65f/Lib/test/test_gc.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/136304/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/136304/files#diff-9d9e863bd2a456b669ec9600be793699e861340d91d7c417a8a5b5b8cfbd09a7 |
|
| https://github.com/python/cpython/pull/136304/files#diff-9d9e863bd2a456b669ec9600be793699e861340d91d7c417a8a5b5b8cfbd09a7 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L620 |
| Lib/test/test_weakref.py | https://github.com/python/cpython/pull/136304/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575 |
|
View file
| https://github.com/sergey-miryanov/cpython/blob/0339d544908326dfb5a9c0c3bb138f40b654c65f/Lib/test/test_weakref.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/136304/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/136304/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575 |
|
| https://github.com/python/cpython/pull/136304/files#diff-937b32719db22ef614ad443f33d3c274ccc905bb58badd4167d6720e0e45d575 |
| Please reload this page | https://github.com/python/cpython/pull/136304/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |