| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e5fd139c-f81a-bc0e-2bcb-242b6037909e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 872E:E2378:176C441:204778C:6A4EA6F2 |
| html-safe-nonce | 2fffb79d10d8b54fc1426984d988c173b113c5dfe67935cdcc95113b3280811c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzJFOkUyMzc4OjE3NkM0NDE6MjA0Nzc4Qzo2QTRFQTZGMiIsInZpc2l0b3JfaWQiOiI2Njc1Mjc3ODkzMDg0MjkyODUwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c153471df494d868667fdc20540744772a2ae834152b2a8e57610056b76b6544 |
| hovercard-subject-tag | pull_request:282899248 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/13630/files |
| twitter:image | https://avatars.githubusercontent.com/u/356399?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/356399?s=400&v=4 |
| og:image:alt | Implementation adds MultiLoopChildWatcher and uses it by default.
https://bugs.python.org/issue35621 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e6a744804e8e70f97b4d5a18a94dcc63db22f97a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/13630/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13630%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F13630%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/13630/files |
| Reload | https://github.com/python/cpython/pull/13630/files |
| Reload | https://github.com/python/cpython/pull/13630/files |
| Please reload this page | https://github.com/python/cpython/pull/13630/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/13630/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| asvetlov | https://github.com/asvetlov |
| python:master | https://github.com/python/cpython/tree/master |
| asvetlov:multiloop-watcher | https://github.com/asvetlov/cpython/tree/multiloop-watcher |
|
Conversation
16
| https://github.com/python/cpython/pull/13630 |
|
Commits
24
| https://github.com/python/cpython/pull/13630/commits |
|
Checks
0
| https://github.com/python/cpython/pull/13630/checks |
|
Files changed
| https://github.com/python/cpython/pull/13630/files |
| Please reload this page | https://github.com/python/cpython/pull/13630/files |
|
bpo-35621: Support running subprocesses in asyncio when loop is executed in non-main thread
| https://github.com/python/cpython/pull/13630/files#top |
|
Show all changes
24 commits
| https://github.com/python/cpython/pull/13630/files |
|
673bdb4
Work on
asvetlov May 28, 2019
| https://github.com/python/cpython/pull/13630/commits/673bdb4d35ecccc882f410e9eddf9387946cc19b |
|
ce3a5d3
Merge branch 'master' into multiloop-watcher
asvetlov May 28, 2019
| https://github.com/python/cpython/pull/13630/commits/ce3a5d3316e2aaf5da0b2966e8d1c1b8e136e1ff |
|
2fc2737
Support subprocesses in threads
asvetlov May 28, 2019
| https://github.com/python/cpython/pull/13630/commits/2fc273787d884ad63ba17c74550a6152b0def418 |
|
60bdb45
Merge branch 'master' into multiloop-watcher
asvetlov May 29, 2019
| https://github.com/python/cpython/pull/13630/commits/60bdb45dc4c34e02fef0692c87a41ea4a77ef29c |
|
75e0495
Fix typo in comment
asvetlov May 29, 2019
| https://github.com/python/cpython/pull/13630/commits/75e0495136ac5c0473e3889e5c13d6d44aaaa155 |
|
df1b1ba
Merge branch 'master' into multiloop-watcher
asvetlov May 30, 2019
| https://github.com/python/cpython/pull/13630/commits/df1b1bac6ce04fbfc4aced699612bd3fe407eeb0 |
|
2d2db05
Init MultiLoopChildWatcher in UnixEventLoopPolicy constructor
asvetlov May 30, 2019
| https://github.com/python/cpython/pull/13630/commits/2d2db05229a724491b3c986c5e0f5364ce08a7da |
|
5c9fc12
Merge branch 'master' into multiloop-watcher
asvetlov May 30, 2019
| https://github.com/python/cpython/pull/13630/commits/5c9fc122e1e7b111d14483a79ac7a726a2bb6227 |
|
e2f59e8
Revert tests change
asvetlov May 30, 2019
| https://github.com/python/cpython/pull/13630/commits/e2f59e8e90470f231e1efd4451e019cd0f6f8378 |
|
eaea9f9
Work on
asvetlov May 30, 2019
| https://github.com/python/cpython/pull/13630/commits/eaea9f9b8243806edaff59ccbb0dd1e09757d3e7 |
|
798a7fb
Add ThreadedChildWatcher and make it default
asvetlov May 31, 2019
| https://github.com/python/cpython/pull/13630/commits/798a7fbba55426b2d3080b08ae9345372829dbaa |
|
7ba175e
Add check for is_active()
asvetlov May 31, 2019
| https://github.com/python/cpython/pull/13630/commits/7ba175e0b4939a86a1de2665bcd6d80bbe40ef5b |
|
4ed22ba
Add new watcher classes to test suite
asvetlov May 31, 2019
| https://github.com/python/cpython/pull/13630/commits/4ed22baccbabf10c3e0bd0ffb214cbf6ba44e094 |
|
318f5a0
Merge branch 'master' into multiloop-watcher
asvetlov Jun 1, 2019
| https://github.com/python/cpython/pull/13630/commits/318f5a0ac665dd8f92b731601c3a2411216b5f20 |
|
4c464e7
Correctly close watcher in tests
asvetlov Jun 1, 2019
| https://github.com/python/cpython/pull/13630/commits/4c464e79f73e600def3b6d780e62d65013e9a92f |
|
c07e3f3
Clarify text
asvetlov Jun 1, 2019
| https://github.com/python/cpython/pull/13630/commits/c07e3f3b46a21c20b1785f5d29d61ca6b22f4d1d |
|
03fa4b9
Make checkers stricter
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/03fa4b91bb51a8591bf645dd033b4ca00f12c0c1 |
|
fd56fc7
Add specific test for non-active watcher
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/fd56fc7628b36f9f631a1cef2bd181384c91c4b6 |
|
e7805a6
Fix typo
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/e7805a6b9a22e068396e3f021feefcbb9b050b03 |
|
e849af5
Fix comment
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/e849af50c675def6cf910c7fb9d3a81262a4f62c |
|
ae7f11d
Drop redundant check
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/ae7f11dd2b8c9c7d7cf53ab22ca101544b42aed3 |
|
6fb36f2
Fix comment
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/6fb36f2be4025cdfe1727033e866a8e4e2d39f71 |
|
d071f19
Code cleanup
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/d071f19d49f6add662da3b60ecf877316bc99920 |
|
de56eb9
Improve logging message
asvetlov Jun 2, 2019
| https://github.com/python/cpython/pull/13630/commits/de56eb9c4b405fadcc33710341f55c1b397643f2 |
|
Clear filters
| https://github.com/python/cpython/pull/13630/files |
| Please reload this page | https://github.com/python/cpython/pull/13630/files |
| Please reload this page | https://github.com/python/cpython/pull/13630/files |
|
unix_events.py
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
test_subprocess.py
| https://github.com/python/cpython/pull/13630/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2 |
|
test_unix_events.py
| https://github.com/python/cpython/pull/13630/files#diff-78695ed3f8e6b470fdf3701f14dd71a2ef5c039e21f398f043cd78c7dda6135c |
|
2019-05-28-19-03-46.bpo-35621.Abc1lf.rst
| https://github.com/python/cpython/pull/13630/files#diff-05d96389a4d2ced8368a5ebfdab9e64a27d2dbf2c6af476d94b133e03fb6ab6a |
| Lib/asyncio/unix_events.py | https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
View file
| https://github.com/asvetlov/cpython/blob/de56eb9c4b405fadcc33710341f55c1b397643f2/Lib/asyncio/unix_events.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/13630/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
| Please reload this page | https://github.com/python/cpython/pull/13630/files |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
|
| https://github.com/python/cpython/pull/13630/files#diff-59eb90ea71c294e306140c76e079c867bcd69a6faf7f96831ce7152eb6e37fc4 |
| Lib/test/test_asyncio/test_subprocess.py | https://github.com/python/cpython/pull/13630/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2 |
|
View file
| https://github.com/asvetlov/cpython/blob/de56eb9c4b405fadcc33710341f55c1b397643f2/Lib/test/test_asyncio/test_subprocess.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/13630/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/13630/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2 |
|
| https://github.com/python/cpython/pull/13630/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2 |
|
| https://github.com/python/cpython/pull/13630/files#diff-3a12ea0e8988b2edcb96962049a9cca2db1ee02db133cd99493ccc87a81d08e2 |
| Please reload this page | https://github.com/python/cpython/pull/13630/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |