René's URL Explorer Experiment


Title: gh-135878: Fix crash in `types.SimpleNamespace.__repr__` by sobolevn · Pull Request #135889 · python/cpython · GitHub

Open Graph Title: gh-135878: Fix crash in `types.SimpleNamespace.__repr__` by sobolevn · Pull Request #135889 · python/cpython

X Title: gh-135878: Fix crash in `types.SimpleNamespace.__repr__` by sobolevn · Pull Request #135889 · python/cpython

Description: Note, that there's a small behavior change. We now treat missing keys as errors, because it is the correct thing to do. When ->ns_dict does not have keys from its PyObject_GetIter(keys) - this is strange. Any suggestions about the test case here are welcome! Issue: gh-135878

Open Graph Description: Note, that there's a small behavior change. We now treat missing keys as errors, because it is the correct thing to do. When ->ns_dict does not have keys from its PyObject_GetIter(keys) - th...

X Description: Note, that there's a small behavior change. We now treat missing keys as errors, because it is the correct thing to do. When ->ns_dict does not have keys from its PyObject_GetIter(ke...

Opengraph URL: https://github.com/python/cpython/pull/135889

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:5958c4bd-3ecc-a382-7393-534c5270f816
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD99C:D5B7F:3A5E35:4D23BA:6B0238D1
html-safe-noncef32477fdd62d0752728fb71f04eec76533792095393c0921abd21e78b0375161
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOTlDOkQ1QjdGOjNBNUUzNTo0RDIzQkE6NkIwMjM4RDEiLCJ2aXNpdG9yX2lkIjoiODE1OTM5NzcwNDcyMDU5NTE1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbabdf1735934940bd0dd595cda3ff9782fe6c4d5eaa4cba805d7350c727929cb
hovercard-subject-tagpull_request:2614749574
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135889/files
twitter:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4660275?s=400&v=4
og:image:altNote, that there's a small behavior change. We now treat missing keys as errors, because it is the correct thing to do. When ->ns_dict does not have keys from its PyObject_GetIter(keys) - th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135889/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135889%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135889%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135889/files
Reloadhttps://github.com/python/cpython/pull/135889/files
Reloadhttps://github.com/python/cpython/pull/135889/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
sobolevnhttps://github.com/sobolevn
python:mainhttps://github.com/python/cpython/tree/main
sobolevn:issue-135878https://github.com/sobolevn/cpython/tree/issue-135878
Conversation 14 https://github.com/python/cpython/pull/135889
Commits 4 https://github.com/python/cpython/pull/135889/commits
Checks 0 https://github.com/python/cpython/pull/135889/checks
Files changed 2 https://github.com/python/cpython/pull/135889/files
gh-135878: Fix crash in types.SimpleNamespace.__repr__ https://github.com/python/cpython/pull/135889/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/135889/files
a9a99c7 gh-135878: Fix crash in `types.SimpleNamespace.__repr__` sobolevn Jun 24, 2025 https://github.com/python/cpython/pull/135889/commits/a9a99c75741667772741aa13538b727ae3c89358
eeb23d4 Update Misc/NEWS.d/next/Library/2025-06-24-14-43-24.gh-issue-135878.D… sobolevn Jun 24, 2025 https://github.com/python/cpython/pull/135889/commits/eeb23d47e55a9fa5769faf8fcf1f386564c0de66
3e83d3a Address review sobolevn Jun 24, 2025 https://github.com/python/cpython/pull/135889/commits/3e83d3a97f997ff4c69ccecff98a061d4875ff73
deb9223 Address review sobolevn Jun 24, 2025 https://github.com/python/cpython/pull/135889/commits/deb9223161f05ee2028fd21353b804f4665e954d
Clear filters https://github.com/python/cpython/pull/135889/files
Please reload this pagehttps://github.com/python/cpython/pull/135889/files
Please reload this pagehttps://github.com/python/cpython/pull/135889/files
2025-06-24-14-43-24.gh-issue-135878.Db4roX.rst https://github.com/python/cpython/pull/135889/files#diff-a110f5639c5982287b2cb06626e5142ffadab27aef175a7a0308820ff9070687
namespaceobject.c https://github.com/python/cpython/pull/135889/files#diff-b3ba6c9311e0a50e14133a1e17c661712ebe5293f1c511967add86d423c47db2
Misc/NEWS.d/next/Library/2025-06-24-14-43-24.gh-issue-135878.Db4roX.rsthttps://github.com/python/cpython/pull/135889/files#diff-a110f5639c5982287b2cb06626e5142ffadab27aef175a7a0308820ff9070687
View file https://github.com/sobolevn/cpython/blob/deb9223161f05ee2028fd21353b804f4665e954d/Misc/NEWS.d/next/Library/2025-06-24-14-43-24.gh-issue-135878.Db4roX.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135889/{{ revealButtonHref }}
Objects/namespaceobject.chttps://github.com/python/cpython/pull/135889/files#diff-b3ba6c9311e0a50e14133a1e17c661712ebe5293f1c511967add86d423c47db2
View file https://github.com/sobolevn/cpython/blob/deb9223161f05ee2028fd21353b804f4665e954d/Objects/namespaceobject.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135889/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135889/files#diff-b3ba6c9311e0a50e14133a1e17c661712ebe5293f1c511967add86d423c47db2
Please reload this pagehttps://github.com/python/cpython/pull/135889/files
https://github.com/python/cpython/pull/135889/files#diff-b3ba6c9311e0a50e14133a1e17c661712ebe5293f1c511967add86d423c47db2
https://github.com/python/cpython/pull/135889/files#diff-b3ba6c9311e0a50e14133a1e17c661712ebe5293f1c511967add86d423c47db2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.