René's URL Explorer Experiment


Title: gh-135853: add `math.fmax` and `math.fmin` by picnixz · Pull Request #135888 · python/cpython · GitHub

Open Graph Title: gh-135853: add `math.fmax` and `math.fmin` by picnixz · Pull Request #135888 · python/cpython

X Title: gh-135853: add `math.fmax` and `math.fmin` by picnixz · Pull Request #135888 · python/cpython

Description: I've added math.fmin and math.fmax as I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument. WDYT of this proposal @skirpichev @rhettinger? Issue: gh-135853 📚 Documentation preview 📚: https://cpython-previews--135888.org.readthedocs.build/

Open Graph Description: I've added math.fmin and math.fmax as I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument. WDYT of this propo...

X Description: I've added math.fmin and math.fmax as I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument. WDYT o...

Opengraph URL: https://github.com/python/cpython/pull/135888

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:424b1ea5-71e6-e799-236b-242692c11a4c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idECC0:38EE04:1AF80B9:2391BAB:6B021ADA
html-safe-nonce493917952377cf83382ec7554bad4833a9b86a3537dd5d4761a19a13af0e1dd2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0MwOjM4RUUwNDoxQUY4MEI5OjIzOTFCQUI6NkIwMjFBREEiLCJ2aXNpdG9yX2lkIjoiNzgzNjI3NzQ2MjM4NzUzMDQ1OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6ae0c106e4fd86d1aaeeca293935887e60a1da16117c7a73b14a8675c3540aa7
hovercard-subject-tagpull_request:2614742357
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135888/files
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altI've added math.fmin and math.fmax as I think it'd be nice to have the NaN handling as per C99. I didn't make those functions generic or accept any iterable argument. WDYT of this propo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135888/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135888%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135888%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135888/files
Reloadhttps://github.com/python/cpython/pull/135888/files
Reloadhttps://github.com/python/cpython/pull/135888/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:feat/math/fmin-fmax-135853https://github.com/picnixz/cpython/tree/feat/math/fmin-fmax-135853
Conversation 37 https://github.com/python/cpython/pull/135888
Commits 13 https://github.com/python/cpython/pull/135888/commits
Checks 0 https://github.com/python/cpython/pull/135888/checks
Files changed https://github.com/python/cpython/pull/135888/files
Please reload this pagehttps://github.com/python/cpython/pull/135888/files
gh-135853: add math.fmax and math.fmin https://github.com/python/cpython/pull/135888/files#top
Show all changes 13 commits https://github.com/python/cpython/pull/135888/files
a82d298 add math.fmax and math.fmin picnixz Jun 24, 2025 https://github.com/python/cpython/pull/135888/commits/a82d2984b06b204ac398838eb63ce738ce87c003
afb0a91 address review picnixz Jun 24, 2025 https://github.com/python/cpython/pull/135888/commits/afb0a9195b51a8e8cc0427a20fe61396c1742c97
62597d6 revert un-necessary change picnixz Jun 24, 2025 https://github.com/python/cpython/pull/135888/commits/62597d6e21900e80234539afdcdb89886ab48701
a858aa1 Update Lib/test/test_math.py picnixz Jun 24, 2025 https://github.com/python/cpython/pull/135888/commits/a858aa12a726ec1e080a0e13844493d28734a7fd
f23a339 Update Lib/test/test_math.py picnixz Jun 24, 2025 https://github.com/python/cpython/pull/135888/commits/f23a33965651c80864465f5c398e7cefead345fb
a61eca5 address review and align tests with C11 standard picnixz Jun 27, 2025 https://github.com/python/cpython/pull/135888/commits/a61eca5c7f715fe7eaec662b1c2490087c383749
92732bb Apply suggestions from code review picnixz Jun 27, 2025 https://github.com/python/cpython/pull/135888/commits/92732bb47053d93e53c8aaf5af716e9279010d46
e1bc272 Update Lib/test/test_math.py picnixz Jun 27, 2025 https://github.com/python/cpython/pull/135888/commits/e1bc27277a556e72c4c17ff552afd0bc0b7729d7
4e8277f improve test coverage picnixz Jun 27, 2025 https://github.com/python/cpython/pull/135888/commits/4e8277ff2aa8bff5d8a444b423d34f65743b7c94
ba2e77c remove misleading test picnixz Jun 27, 2025 https://github.com/python/cpython/pull/135888/commits/ba2e77c33d313ceda6272096c9d43a7fac657578
c1742a6 align signature style picnixz Jun 28, 2025 https://github.com/python/cpython/pull/135888/commits/c1742a68d070101a2303f7d55acab4922a3426c7
2d3967a Merge remote-tracking branch 'upstream/main' into feat/math/fmin-fmax… picnixz Jun 28, 2025 https://github.com/python/cpython/pull/135888/commits/2d3967a8c8259a74b07f6aae9916cdd86631a8ed
18bdee6 Merge branch 'main' into feat/math/fmin-fmax-135853 picnixz Jul 12, 2025 https://github.com/python/cpython/pull/135888/commits/18bdee6c3702360811793c82eae5609f060da1b6
Clear filters https://github.com/python/cpython/pull/135888/files
Please reload this pagehttps://github.com/python/cpython/pull/135888/files
Please reload this pagehttps://github.com/python/cpython/pull/135888/files
math.rst https://github.com/python/cpython/pull/135888/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
3.15.rst https://github.com/python/cpython/pull/135888/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
test_math.py https://github.com/python/cpython/pull/135888/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
2025-06-24-13-30-47.gh-issue-135853.7ejTvK.rst https://github.com/python/cpython/pull/135888/files#diff-9f38dfe6726a27aad78d8bbe662ed3d0238722d7d1ae9f658cb1d24caa4547b2
mathmodule.c.h https://github.com/python/cpython/pull/135888/files#diff-be28b04d80a581f81971deb34bb269241521f2aae3517b952fcfeba9f073bbf1
mathmodule.c https://github.com/python/cpython/pull/135888/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
Doc/library/math.rsthttps://github.com/python/cpython/pull/135888/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
View file https://github.com/picnixz/cpython/blob/18bdee6c3702360811793c82eae5609f060da1b6/Doc/library/math.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135888/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135888/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
https://github.com/python/cpython/pull/135888/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
https://github.com/python/cpython/pull/135888/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
Please reload this pagehttps://github.com/python/cpython/pull/135888/files
Please reload this pagehttps://github.com/python/cpython/pull/135888/files
https://github.com/python/cpython/pull/135888/files#diff-cda4d855eb1739006a497bdead4e353aef302d1837ee7271ec5e4ba45f675221
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L116
Doc/whatsnew/3.15.rsthttps://github.com/python/cpython/pull/135888/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
View file https://github.com/picnixz/cpython/blob/18bdee6c3702360811793c82eae5609f060da1b6/Doc/whatsnew/3.15.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135888/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135888/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
https://github.com/python/cpython/pull/135888/files#diff-bd7a9c5b54eeb2b40e6db5e48e8d79d309d8738e776a40918773c6840189edf9
Lib/test/test_math.pyhttps://github.com/python/cpython/pull/135888/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
View file https://github.com/picnixz/cpython/blob/18bdee6c3702360811793c82eae5609f060da1b6/Lib/test/test_math.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135888/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135888/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
https://github.com/python/cpython/pull/135888/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
https://github.com/python/cpython/pull/135888/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
Please reload this pagehttps://github.com/python/cpython/pull/135888/files
https://github.com/python/cpython/pull/135888/files#diff-a39b1e44e20048f5b8207fee83df00a2541a7f02716113e6243c33165e628cd5
Misc/NEWS.d/next/Library/2025-06-24-13-30-47.gh-issue-135853.7ejTvK.rsthttps://github.com/python/cpython/pull/135888/files#diff-9f38dfe6726a27aad78d8bbe662ed3d0238722d7d1ae9f658cb1d24caa4547b2
View file https://github.com/picnixz/cpython/blob/18bdee6c3702360811793c82eae5609f060da1b6/Misc/NEWS.d/next/Library/2025-06-24-13-30-47.gh-issue-135853.7ejTvK.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135888/{{ revealButtonHref }}
Modules/clinic/mathmodule.c.hhttps://github.com/python/cpython/pull/135888/files#diff-be28b04d80a581f81971deb34bb269241521f2aae3517b952fcfeba9f073bbf1
View file https://github.com/picnixz/cpython/blob/18bdee6c3702360811793c82eae5609f060da1b6/Modules/clinic/mathmodule.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/135888/files
Modules/mathmodule.chttps://github.com/python/cpython/pull/135888/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
View file https://github.com/picnixz/cpython/blob/18bdee6c3702360811793c82eae5609f060da1b6/Modules/mathmodule.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135888/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135888/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/135888/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/135888/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com/python/cpython/pull/135888/files#diff-5b1186dfcc44670529aa53cb728a1c005f58f38324c24787a49f22cec36841c7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.