René's URL Explorer Experiment


Title: gh-135532: use `defining_class` for copying BLAKE-2 and SHA-3 objects by picnixz · Pull Request #135838 · python/cpython · GitHub

Open Graph Title: gh-135532: use `defining_class` for copying BLAKE-2 and SHA-3 objects by picnixz · Pull Request #135838 · python/cpython

X Title: gh-135532: use `defining_class` for copying BLAKE-2 and SHA-3 objects by picnixz · Pull Request #135838 · python/cpython

Description: Performance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in the future, this saves some work as we would only need to touch constructors and not the methods themselves. Issue: gh-135532

Open Graph Description: Performance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in the future...

X Description: Performance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in th...

Opengraph URL: https://github.com/python/cpython/pull/135838

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c08649aa-c631-4a6f-c3df-3c5ddf039544
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE2F2:361639:3749E9F:49B8697:6B0216CA
html-safe-nonce49818e092ed0f359988c7f16de7384a87a7386169c4f9b004f8c884de7e31402
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkYyOjM2MTYzOTozNzQ5RTlGOjQ5Qjg2OTc6NkIwMjE2Q0EiLCJ2aXNpdG9yX2lkIjoiNDQ1OTQwNTYwNTM5NTg5NjAxMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca722f6f75c1f8988884d52f4640367494043ccb96333dadffad6af8a38436c92
hovercard-subject-tagpull_request:2611167440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/135838/files
twitter:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/10796600?s=400&v=4
og:image:altPerformance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in the future...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/135838/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135838/files
Reloadhttps://github.com/python/cpython/pull/135838/files
Reloadhttps://github.com/python/cpython/pull/135838/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:refactor/hashlib/defining-class-135532https://github.com/picnixz/cpython/tree/refactor/hashlib/defining-class-135532
Conversation 4 https://github.com/python/cpython/pull/135838
Commits 2 https://github.com/python/cpython/pull/135838/commits
Checks 0 https://github.com/python/cpython/pull/135838/checks
Files changed https://github.com/python/cpython/pull/135838/files
Please reload this pagehttps://github.com/python/cpython/pull/135838/files
gh-135532: use defining_class for copying BLAKE-2 and SHA-3 objects https://github.com/python/cpython/pull/135838/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/135838/files
f631476 use 'defining_class' when copying HACL*-based hashes picnixz Jun 23, 2025 https://github.com/python/cpython/pull/135838/commits/f6314764fd253d520809c73bf82ec1567992b145
26a029c simplify test picnixz Jun 23, 2025 https://github.com/python/cpython/pull/135838/commits/26a029c12d3403636360172f54603bc006e4f3cb
Clear filters https://github.com/python/cpython/pull/135838/files
Please reload this pagehttps://github.com/python/cpython/pull/135838/files
Please reload this pagehttps://github.com/python/cpython/pull/135838/files
test_hashlib.py https://github.com/python/cpython/pull/135838/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
blake2module.c https://github.com/python/cpython/pull/135838/files#diff-c7440bf2e8c27b17a856c469b7839a7c0bfd93008e3c4f553616df6f1c33d854
blake2module.c.h https://github.com/python/cpython/pull/135838/files#diff-34e215fcc7258c831253ec29048ccdd4c325672f5422291a989f2401b80e1932
sha3module.c.h https://github.com/python/cpython/pull/135838/files#diff-ff992abeef679d7f61edf9fec1e0a536e93cce4cd95966f4d37ee13f9a2db628
sha3module.c https://github.com/python/cpython/pull/135838/files#diff-8d15b65b0c06f6b2f51318fdcc4596e8e1e41fdb6af8c113c5f3d326e6b61077
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L391
Lib/test/test_hashlib.pyhttps://github.com/python/cpython/pull/135838/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
View file https://github.com/picnixz/cpython/blob/26a029c12d3403636360172f54603bc006e4f3cb/Lib/test/test_hashlib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135838/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135838/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
https://github.com/python/cpython/pull/135838/files#diff-b19facaf857653d4f07afbb090181f595ef4c9381f2abcd2917abd4f3529e8fe
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L396
Modules/blake2module.chttps://github.com/python/cpython/pull/135838/files#diff-c7440bf2e8c27b17a856c469b7839a7c0bfd93008e3c4f553616df6f1c33d854
View file https://github.com/picnixz/cpython/blob/26a029c12d3403636360172f54603bc006e4f3cb/Modules/blake2module.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135838/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135838/files#diff-c7440bf2e8c27b17a856c469b7839a7c0bfd93008e3c4f553616df6f1c33d854
https://github.com/python/cpython/pull/135838/files#diff-c7440bf2e8c27b17a856c469b7839a7c0bfd93008e3c4f553616df6f1c33d854
Modules/clinic/blake2module.c.hhttps://github.com/python/cpython/pull/135838/files#diff-34e215fcc7258c831253ec29048ccdd4c325672f5422291a989f2401b80e1932
View file https://github.com/picnixz/cpython/blob/26a029c12d3403636360172f54603bc006e4f3cb/Modules/clinic/blake2module.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/135838/files
Modules/clinic/sha3module.c.hhttps://github.com/python/cpython/pull/135838/files#diff-ff992abeef679d7f61edf9fec1e0a536e93cce4cd95966f4d37ee13f9a2db628
View file https://github.com/picnixz/cpython/blob/26a029c12d3403636360172f54603bc006e4f3cb/Modules/clinic/sha3module.c.h
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/python/cpython/pull/135838/files
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L398
Modules/sha3module.chttps://github.com/python/cpython/pull/135838/files#diff-8d15b65b0c06f6b2f51318fdcc4596e8e1e41fdb6af8c113c5f3d326e6b61077
View file https://github.com/picnixz/cpython/blob/26a029c12d3403636360172f54603bc006e4f3cb/Modules/sha3module.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/135838/{{ revealButtonHref }}
https://github.com/python/cpython/pull/135838/files#diff-8d15b65b0c06f6b2f51318fdcc4596e8e1e41fdb6af8c113c5f3d326e6b61077
https://github.com/python/cpython/pull/135838/files#diff-8d15b65b0c06f6b2f51318fdcc4596e8e1e41fdb6af8c113c5f3d326e6b61077
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.