René's URL Explorer Experiment


Title: gh-135532: use `defining_class` for copying BLAKE-2 and SHA-3 objects by picnixz · Pull Request #135838 · python/cpython · GitHub

Open Graph Title: gh-135532: use `defining_class` for copying BLAKE-2 and SHA-3 objects by picnixz · Pull Request #135838 · python/cpython

X Title: gh-135532: use `defining_class` for copying BLAKE-2 and SHA-3 objects by picnixz · Pull Request #135838 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Performance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in the future...

X Description: Performance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in th...

Opengraph URL: https://github.com/python/cpython/pull/135838

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e703d40d-c1a6-f6ca-bd81-5881085e11ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8AE:39FDE1:4177FB:526B6A:6B01FDE6
html-safe-nonce4e0522781f27693ff78ed1482235c60c8763399205e67896a893344a4b22cf89
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEFFOjM5RkRFMTo0MTc3RkI6NTI2QjZBOjZCMDFGREU2IiwidmlzaXRvcl9pZCI6IjEzMjg3MjU2NjMyNjc1NTI3NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac60bbf6144e767793e16a6a65fea43b3baa62705df7669c18618b6ecc0b650578
hovercard-subject-tagpull_request:2611167440
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135838/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/60b75ba579dd5b3be98f0adab1e0127d540aa2c6abe362c36585035c33e59db9/python/cpython/pull/135838
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/60b75ba579dd5b3be98f0adab1e0127d540aa2c6abe362c36585035c33e59db9/python/cpython/pull/135838
og:image:altPerformance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in the future...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepicnixz
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/135838#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/135838
Reloadhttps://github.com/python/cpython/pull/135838
Reloadhttps://github.com/python/cpython/pull/135838
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:refactor/hashlib/defining-class-135532https://github.com/picnixz/cpython/tree/refactor/hashlib/defining-class-135532
Conversationhttps://github.com/python/cpython/pull/135838
Commits2 (2)https://github.com/python/cpython/pull/135838/commits
Checkshttps://github.com/python/cpython/pull/135838/checks
Files changedhttps://github.com/python/cpython/pull/135838/files
gh-135532: use defining_class for copying BLAKE-2 and SHA-3 objectshttps://github.com/python/cpython/pull/135838#top
picnixzhttps://github.com/picnixz
python:mainhttps://github.com/python/cpython/tree/main
picnixz:refactor/hashlib/defining-class-135532https://github.com/picnixz/cpython/tree/refactor/hashlib/defining-class-135532
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 23, 2025https://github.com/python/cpython/pull/135838#issue-3167631685
Please reload this pagehttps://github.com/python/cpython/pull/135838
Rewrite & cleanup HACL*-based extension modules #135532https://github.com/python/cpython/issues/135532
Please reload this pagehttps://github.com/python/cpython/pull/135838
https://github.com/picnixz
use 'defining_class' when copying HACL*-based hasheshttps://github.com/python/cpython/pull/135838/commits/f6314764fd253d520809c73bf82ec1567992b145
f631476https://github.com/python/cpython/pull/135838/commits/f6314764fd253d520809c73bf82ec1567992b145
https://github.com/picnixz
picnixzhttps://github.com/picnixz
gpsheadhttps://github.com/gpshead
tiranhttps://github.com/tiran
code ownershttps://github.com/python/cpython/blob/0d9d48959e050b66cb37a333940ebf4dc2a74e15/.github/CODEOWNERS#L111
June 23, 2025 10:22https://github.com/python/cpython/pull/135838#event-18270559059
https://github.com/picnixz
picnixzhttps://github.com/picnixz
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
type-refactor https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-refactor
Jun 23, 2025https://github.com/python/cpython/pull/135838#event-18270559250
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 23, 2025https://github.com/python/cpython/pull/135838#event-18270560323
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 23, 2025https://github.com/python/cpython/pull/135838#event-18270562688
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
Jun 23, 2025 https://github.com/python/cpython/pull/135838#ref-issue-3147263747
Rewrite & cleanup HACL*-based extension modules #135532 https://github.com/python/cpython/issues/135532
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 23, 2025https://github.com/python/cpython/pull/135838#issuecomment-2995848107
Please reload this pagehttps://github.com/python/cpython/pull/135838
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 23, 2025https://github.com/python/cpython/pull/135838#issuecomment-2995848255
@picnixzhttps://github.com/picnixz
f631476https://github.com/python/cpython/commit/f6314764fd253d520809c73bf82ec1567992b145
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/135838
https://github.com/picnixz
simplify testhttps://github.com/python/cpython/pull/135838/commits/26a029c12d3403636360172f54603bc006e4f3cb
26a029chttps://github.com/python/cpython/pull/135838/commits/26a029c12d3403636360172f54603bc006e4f3cb
https://github.com/picnixz
picnixzhttps://github.com/picnixz
Jun 23, 2025https://github.com/python/cpython/pull/135838#issuecomment-2996267594
Please reload this pagehttps://github.com/python/cpython/pull/135838
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jun 23, 2025https://github.com/python/cpython/pull/135838#issuecomment-2996267761
@picnixzhttps://github.com/picnixz
26a029chttps://github.com/python/cpython/commit/26a029c12d3403636360172f54603bc006e4f3cb
https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmergehttps://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmerge
Please reload this pagehttps://github.com/python/cpython/pull/135838
https://github.com/picnixz
picnixzhttps://github.com/picnixz
ef4fc86https://github.com/python/cpython/commit/ef4fc86afa297071cb0eb3db871640fc14694a36
Jun 24, 2025https://github.com/python/cpython/pull/135838#event-18288551702
https://github.com/picnixz
picnixzhttps://github.com/picnixz
June 24, 2025 07:58https://github.com/python/cpython/pull/135838#event-18288552484
https://github.com/apps/bedevere-app
bedevere-apphttps://github.com/apps/bedevere-app
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jun 24, 2025https://github.com/python/cpython/pull/135838#event-18288552709
AndPuQinghttps://github.com/AndPuQing
Jul 11, 2025 https://github.com/python/cpython/pull/135838#ref-commit-e856bb9
https://github.com/picnixz
https://github.com/AndPuQing
pythongh-135532https://github.com/python/cpython/issues/135532
: usehttps://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3
defining_classhttps://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3
for copying BLAKE-2 and SHA-3 o…https://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3
e856bb9https://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3
python#135838https://github.com/python/cpython/pull/135838
Pranjal095https://github.com/Pranjal095
Jul 12, 2025 https://github.com/python/cpython/pull/135838#ref-commit-9b530a9
https://github.com/picnixz
https://github.com/Pranjal095
pythongh-135532https://github.com/python/cpython/issues/135532
: usehttps://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e
defining_classhttps://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e
for copying BLAKE-2 and SHA-3 o…https://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e
9b530a9https://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e
python#135838https://github.com/python/cpython/pull/135838
taegyunkimhttps://github.com/taegyunkim
Aug 4, 2025 https://github.com/python/cpython/pull/135838#ref-commit-6c18125
https://github.com/picnixz
https://github.com/taegyunkim
pythongh-135532https://github.com/python/cpython/issues/135532
: usehttps://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d
defining_classhttps://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d
for copying BLAKE-2 and SHA-3 o…https://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d
6c18125https://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d
python#135838https://github.com/python/cpython/pull/135838
Agent-Hellboyhttps://github.com/Agent-Hellboy
Aug 19, 2025 https://github.com/python/cpython/pull/135838#ref-commit-4dc62a2
https://github.com/picnixz
https://github.com/Agent-Hellboy
pythongh-135532https://github.com/python/cpython/issues/135532
: usehttps://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc
defining_classhttps://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc
for copying BLAKE-2 and SHA-3 o…https://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc
4dc62a2https://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc
python#135838https://github.com/python/cpython/pull/135838
https://github.com/devdanzin
devdanzinhttps://github.com/devdanzin
Jul 2, 2026 https://github.com/python/cpython/pull/135838#ref-issue-4791701339
hashlib BLAKE2 .copy() crashes with Py_UNREACHABLE in py_blake2_clear when the copy's allocation fails #152851 https://github.com/python/cpython/issues/152851
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/tiran
tiran https://github.com/tiran
Please reload this pagehttps://github.com/python/cpython/pull/135838
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
type-refactor https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-refactor
Please reload this pagehttps://github.com/python/cpython/pull/135838
https://github.com/picnixz
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.