| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e703d40d-c1a6-f6ca-bd81-5881085e11ad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D8AE:39FDE1:4177FB:526B6A:6B01FDE6 |
| html-safe-nonce | 4e0522781f27693ff78ed1482235c60c8763399205e67896a893344a4b22cf89 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOEFFOjM5RkRFMTo0MTc3RkI6NTI2QjZBOjZCMDFGREU2IiwidmlzaXRvcl9pZCI6IjEzMjg3MjU2NjMyNjc1NTI3NDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 60bbf6144e767793e16a6a65fea43b3baa62705df7669c18618b6ecc0b650578 |
| hovercard-subject-tag | pull_request:2611167440 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/135838/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/60b75ba579dd5b3be98f0adab1e0127d540aa2c6abe362c36585035c33e59db9/python/cpython/pull/135838 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/60b75ba579dd5b3be98f0adab1e0127d540aa2c6abe362c36585035c33e59db9/python/cpython/pull/135838 |
| og:image:alt | Performance are left untouched even if we're not using a METH_NOARGS. I tried to remove the defining_class in existing code but it didn't help. If we were to allow subclassing in the future... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | picnixz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/python/cpython/pull/135838#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/135838 |
| Reload | https://github.com/python/cpython/pull/135838 |
| Reload | https://github.com/python/cpython/pull/135838 |
| python | https://github.com/python |
| cpython | https://github.com/python/cpython |
| Code | https://github.com/python/cpython |
| Issues5k+ (5k+) | https://github.com/python/cpython/issues |
| Pull requests2.4k (2.4k) | https://github.com/python/cpython/pulls |
| Actions | https://github.com/python/cpython/actions |
| Projects | https://github.com/python/cpython/projects |
| Security and quality | https://github.com/python/cpython/security |
| Insights | https://github.com/python/cpython/insights |
| https://github.com/python/cpython |
| picnixz | https://github.com/picnixz |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:refactor/hashlib/defining-class-135532 | https://github.com/picnixz/cpython/tree/refactor/hashlib/defining-class-135532 |
| Conversation | https://github.com/python/cpython/pull/135838 |
| Commits2 (2) | https://github.com/python/cpython/pull/135838/commits |
| Checks | https://github.com/python/cpython/pull/135838/checks |
| Files changed | https://github.com/python/cpython/pull/135838/files |
| gh-135532: use defining_class for copying BLAKE-2 and SHA-3 objects | https://github.com/python/cpython/pull/135838#top |
| picnixz | https://github.com/picnixz |
| python:main | https://github.com/python/cpython/tree/main |
| picnixz:refactor/hashlib/defining-class-135532 | https://github.com/picnixz/cpython/tree/refactor/hashlib/defining-class-135532 |
|
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#issue-3167631685 |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
| Rewrite & cleanup HACL*-based extension modules #135532 | https://github.com/python/cpython/issues/135532 |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
|
| https://github.com/picnixz |
| use 'defining_class' when copying HACL*-based hashes | https://github.com/python/cpython/pull/135838/commits/f6314764fd253d520809c73bf82ec1567992b145 |
| f631476 | https://github.com/python/cpython/pull/135838/commits/f6314764fd253d520809c73bf82ec1567992b145 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| gpshead | https://github.com/gpshead |
| tiran | https://github.com/tiran |
| code owners | https://github.com/python/cpython/blob/0d9d48959e050b66cb37a333940ebf4dc2a74e15/.github/CODEOWNERS#L111 |
| June 23, 2025 10:22 | https://github.com/python/cpython/pull/135838#event-18270559059 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
type-refactor
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-refactor |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#event-18270559250 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#event-18270560323 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#event-18270562688 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
Jun 23, 2025
| https://github.com/python/cpython/pull/135838#ref-issue-3147263747 |
|
Rewrite & cleanup HACL*-based extension modules
#135532
| https://github.com/python/cpython/issues/135532 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#issuecomment-2995848107 |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#issuecomment-2995848255 |
| @picnixz | https://github.com/picnixz |
| f631476 | https://github.com/python/cpython/commit/f6314764fd253d520809c73bf82ec1567992b145 |
| https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmerge | https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmerge |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
|
| https://github.com/picnixz |
| simplify test | https://github.com/python/cpython/pull/135838/commits/26a029c12d3403636360172f54603bc006e4f3cb |
| 26a029c | https://github.com/python/cpython/pull/135838/commits/26a029c12d3403636360172f54603bc006e4f3cb |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#issuecomment-2996267594 |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Jun 23, 2025 | https://github.com/python/cpython/pull/135838#issuecomment-2996267761 |
| @picnixz | https://github.com/picnixz |
| 26a029c | https://github.com/python/cpython/commit/26a029c12d3403636360172f54603bc006e4f3cb |
| https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmerge | https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135838%2Fmerge |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| ef4fc86 | https://github.com/python/cpython/commit/ef4fc86afa297071cb0eb3db871640fc14694a36 |
| Jun 24, 2025 | https://github.com/python/cpython/pull/135838#event-18288551702 |
| https://github.com/picnixz |
| picnixz | https://github.com/picnixz |
| June 24, 2025 07:58 | https://github.com/python/cpython/pull/135838#event-18288552484 |
| https://github.com/apps/bedevere-app |
| bedevere-app | https://github.com/apps/bedevere-app |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Jun 24, 2025 | https://github.com/python/cpython/pull/135838#event-18288552709 |
| AndPuQing | https://github.com/AndPuQing |
|
Jul 11, 2025
| https://github.com/python/cpython/pull/135838#ref-commit-e856bb9 |
|
| https://github.com/picnixz |
|
| https://github.com/AndPuQing |
| pythongh-135532 | https://github.com/python/cpython/issues/135532 |
| : use | https://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3 |
| defining_class | https://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3 |
| for copying BLAKE-2 and SHA-3 o… | https://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3 |
| e856bb9 | https://github.com/AndPuQing/cpython/commit/e856bb9c2c83022f8205bc826d717049eeed41b3 |
| python#135838 | https://github.com/python/cpython/pull/135838 |
| Pranjal095 | https://github.com/Pranjal095 |
|
Jul 12, 2025
| https://github.com/python/cpython/pull/135838#ref-commit-9b530a9 |
|
| https://github.com/picnixz |
|
| https://github.com/Pranjal095 |
| pythongh-135532 | https://github.com/python/cpython/issues/135532 |
| : use | https://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e |
| defining_class | https://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e |
| for copying BLAKE-2 and SHA-3 o… | https://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e |
| 9b530a9 | https://github.com/Pranjal095/cpython/commit/9b530a9ce358ce562ef2a33f9957cfc6cfa2a50e |
| python#135838 | https://github.com/python/cpython/pull/135838 |
| taegyunkim | https://github.com/taegyunkim |
|
Aug 4, 2025
| https://github.com/python/cpython/pull/135838#ref-commit-6c18125 |
|
| https://github.com/picnixz |
|
| https://github.com/taegyunkim |
| pythongh-135532 | https://github.com/python/cpython/issues/135532 |
| : use | https://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d |
| defining_class | https://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d |
| for copying BLAKE-2 and SHA-3 o… | https://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d |
| 6c18125 | https://github.com/taegyunkim/cpython/commit/6c181250431fa4b2cb66d8604955904c9f781b5d |
| python#135838 | https://github.com/python/cpython/pull/135838 |
| Agent-Hellboy | https://github.com/Agent-Hellboy |
|
Aug 19, 2025
| https://github.com/python/cpython/pull/135838#ref-commit-4dc62a2 |
|
| https://github.com/picnixz |
|
| https://github.com/Agent-Hellboy |
| pythongh-135532 | https://github.com/python/cpython/issues/135532 |
| : use | https://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc |
| defining_class | https://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc |
| for copying BLAKE-2 and SHA-3 o… | https://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc |
| 4dc62a2 | https://github.com/Agent-Hellboy/cpython/commit/4dc62a2343acae7a3a0556a58ecca9406d9175cc |
| python#135838 | https://github.com/python/cpython/pull/135838 |
| https://github.com/devdanzin |
| devdanzin | https://github.com/devdanzin |
|
Jul 2, 2026
| https://github.com/python/cpython/pull/135838#ref-issue-4791701339 |
|
hashlib BLAKE2 .copy() crashes with Py_UNREACHABLE in py_blake2_clear when the copy's allocation fails
#152851
| https://github.com/python/cpython/issues/152851 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F135838 |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
| https://github.com/tiran |
|
tiran
| https://github.com/tiran |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
|
type-refactor
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-refactor |
| Please reload this page | https://github.com/python/cpython/pull/135838 |
|
| https://github.com/picnixz |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |